My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 151847: No text in title
2 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by kenmo...@chromium.org, Sep 23, 2012
Version: 23.0.1271.2 (Official Build 157709) canary
Platform: 2913.3.0 (Official Build) canary-channel lumpy

What steps will reproduce the problem?
1. Play an mp3 file from File Manager

See attached screenshot for misaligned title, looks 2 or 3 pixels too low.
Screenshot 2012-09-23 at 7.08.27 AM.png
20.5 KB   View   Download
Sep 23, 2012
#1 kenmo...@chromium.org
(updating the bug title as apparently this issue affects all windows with titles)
Summary: Titles in titlebar are not vertically centered
Sep 23, 2012
#2 kenmo...@chromium.org
-joshwoodward, +kuscher, not a File Manager specific issue
Cc: -joshwood...@chromium.org Kusc...@chromium.org
Labels: -Feature-FileManager Feature-Ash
Sep 23, 2012
#3 Kusc...@chromium.org
+Vlad who worked on this

+Alcor/Glen. I believe the wish form UX was to have no titles in any window currently, correct?
Status: Assigned
Owner: kaznacheev@chromium.org
Cc: al...@google.com glen@chromium.org
Labels: Feature-Media-Audio Mstone-24
Sep 24, 2012
#4 kaznacheev@chromium.org
I have no control over the title text positioning. It is wherever the window manager put it.
Status: WontFix
Sep 24, 2012
#5 Kusc...@chromium.org
See C3 for the action item here. I believe UX wants us to not set a title if I am not mistaken? Glen/Alcor can you confirm or deny so this can become actionable?
Summary: No text in title
Status: Assigned
Sep 24, 2012
#6 joshwood...@chromium.org
Won't dropping the <title> leave a blank entry in the context menu for this item in the launcher? I saw this happen last week when we didn't have a title - see  Issue 147629  and the screenshot attached.
Blank entry in context menu (1).png
18.2 KB   View   Download
Sep 24, 2012
#7 Kusc...@chromium.org
You don't set the title in the filemanager and you were able to set the context menu title. Shouldn't the same be possible here?
Sep 24, 2012
#8 kaznacheev@chromium.org
Well, this is tricky. If I open the Audio Player window the same way I open the Video Player I would not be able to set its position (or at least it would be more difficult), plus Ash would remember the Audio player position and size and use them as a default when opening the next Files app window which is very ugly. 
Sep 24, 2012
#9 joshwood...@chromium.org
Sounds like two paths are forming...

a) Remove <title> but this seems tricky (Comment 8)
b) Keep <title> in there, but make it vertically aligned center (seems like an Aura bug)


(a) seems preferable for our app. Seems like we should fix (b) anyway because it might impact other apps.

Given the complexity of (a), I'd vote we go for (b) in M23.

WDYT?
Screenshot 2012-09-23 at 7.08.27 AM.png
20.5 KB   View   Download
Labels: -Pri-2 -Mstone-24 Pri-1 Mstone-23
Sep 25, 2012
#10 kaznacheev@chromium.org
There is no simple fix, moving to M24.
Labels: -Mstone-23 Mstone-24
Sep 25, 2012
#11 Kusc...@chromium.org
Steven/Jenny, do you have cycles to look into moving the title up a bit in 23 if that would be a simple change? Sounds like removing title is going to be a trickier issue.

This is a stop-gap, we still need to update apps that use this title.
Cc: stevenjb@chromium.org jen...@chromium.org
Sep 26, 2012
#12 kenmo...@chromium.org
For discussion, another example of title usage is the "Select a file to open" title in the Open File dialog.  There's no good place to put that text prompt in the dialog, and if we do away with it the Open File dialog looks almost identical to the standalone Files app.
Screenshot 2012-09-26 at 11.33.32 AM.png
60.7 KB   View   Download
Sep 26, 2012
#13 Kusc...@chromium.org
The dialogs are eventually going towards the Google-Dialog style (behind a flag right now) if I remember correctly so this is a different issue.
Oct 2, 2012
#14 Kusc...@chromium.org
(No comment was entered for this change.)
Labels: -Feature-Ash
Oct 25, 2012
#15 kaznacheev@chromium.org
I have a patch that removes the text and the icon from the Audio Player window:

https://codereview.chromium.org/11269043

Is this what we want?
Screenshot-1.png
25.1 KB   View   Download
Oct 25, 2012
#16 kaznacheev@chromium.org
(No comment was entered for this change.)
Status: Started
Oct 25, 2012
#17 Kusc...@chromium.org
this looks good - thanks. When it becomes apps v2 it will lose the titlebar all together so not showing the title now is reasonable. If we want a title then, the app needs to render it itself
Oct 29, 2012
#19 scherkus@chromium.org
Can we mark this as fixed?
Oct 29, 2012
#20 kaznacheev@chromium.org
(No comment was entered for this change.)
Status: Fixed
Mar 10, 2013
#21 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Feature-Media-Audio -Mstone-24 Cr-Internals-Media-Audio Cr-UI M-24
Sign in to add a comment

Powered by Google Project Hosting