This doesn't match Safari's behavior for Find or tab bar.
This doesn't match Windows Chrome behavior for Bookmark Bar.

Are you sure?

--> to Ben to answer.

(No comment was entered for this change.)

Safari 4 does change the height of the window for the bookmarks bar, and the status 
bar.

It doesn't for the find bar since that's more of a transient overlay. I wouldn't do 
this in Chrome for our Find bar either.

We discussed doing this for Windows, but changing window height is very unusual there.

(No comment was entered for this change.)

John is working on bookmark bars, so I'll give this to him, though Rohit is also a 
good candidate (infobars)

(No comment was entered for this change.)

(No comment was entered for this change.)

This is a release blocker for Mac Beta.

We are deprecating the MacBeta milestone in favor of ReleaseBlock-Beta and 
a milestone.

Considering moving this bug out of mstone:4.

(No comment was entered for this change.)

(No comment was entered for this change.)

(No comment was entered for this change.)

(No comment was entered for this change.)

-> avi to load balance

-> rohit; he's doing view animation

BTW, what I have is:

// Main method to resize browser window subviews.  This method should be called
// when resizing any child of the content view, rather than resizing the views
// directly.  If the view is already the correct height, does not force a
// relayout.
- (void)resizeView:(NSView*)view newHeight:(float)height {
  // We should only ever be called for one of the following four views.
  // |downloadShelfController_| may be nil. If we are asked to size the bookmark
  // bar directly, its superview must be this controller's content view.
  DCHECK(view);
  DCHECK(view == [toolbarController_ view] ||
         view == [infoBarContainerController_ view] ||
         view == [extensionShelfController_ view] ||
         view == [downloadShelfController_ view] ||
         view == [bookmarkBarController_ view]);

  // Change the height of the view and call layoutViews.  We set the height here
  // without regard to where the view is on the screen or whether it needs to
  // "grow up" or "grow down."  The below call to layoutSubviews will position
  // each view correctly.
  NSRect frame = [view frame];
  CGFloat heightDelta = height - frame.size.height;
  if (heightDelta == 0.0)
    return;

  NSRect windowFrame = [window_ frame];
  windowFrame.origin.y -= heightDelta;
  windowFrame.size.height += heightDelta;
  [window_ setFrame:windowFrame display:YES];

  frame.size.height = height;
  // TODO(rohitrao): Determine if calling setFrame: twice is bad.
  [view setFrame:frame];
  
  [self layoutSubviews];
}

which kinda works, kills the framerate, and does weird stuff over time to the window
size.

Notes for posterity:  Bookmark bar and download shelf are browser chrome, so changes to their height will 
grow/shrink the window.  The infobar is web content, so it will not affect the window height.

(No comment was entered for this change.)

I wonder if  Issue 27365  is an example of this issue.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32560 

------------------------------------------------------------------------
r32560 | rohitrao@chromium.org | 2009-11-19 14:42:01 -0800 (Thu, 19 Nov 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=32560&r2=32559

[Mac] Add support for growing or shrinking the window during animations.

BUG=http://crbug.com/14900
TEST=No visible impact, yet.
Review URL: http://codereview.chromium.org/391035
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32618 

------------------------------------------------------------------------
r32618 | viettrungluu@chromium.org | 2009-11-20 08:55:05 -0800 (Fri, 20 Nov 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/browser_window_controller.h?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/browser_window_controller.mm?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/toolbar_controller.h?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/toolbar_controller.mm?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=32618&r2=32617

Merge 32560 - [Mac] Add support for growing or shrinking the window during animations.

BUG=http://crbug.com/14900
TEST=No visible impact, yet.
Review URL: http://codereview.chromium.org/391035

TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/414037
------------------------------------------------------------------------

I merged it (at rohitrao's request), so I guess I'll also mark this as fixed.

4.0.249.11 r32790

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32560 

------------------------------------------------------------------------
r32560 | rohitrao@chromium.org | 2009-11-19 14:42:01 -0800 (Thu, 19 Nov 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=32560&r2=32559
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=32560&r2=32559

[Mac] Add support for growing or shrinking the window during animations.

BUG=http://crbug.com/14900
TEST=No visible impact, yet.
Review URL: http://codereview.chromium.org/391035
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32618 

------------------------------------------------------------------------
r32618 | viettrungluu@chromium.org | 2009-11-20 08:55:05 -0800 (Fri, 20 Nov 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/browser_window_controller.h?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/browser_window_controller.mm?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/toolbar_controller.h?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/toolbar_controller.mm?r1=32618&r2=32617
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=32618&r2=32617

Merge 32560 - [Mac] Add support for growing or shrinking the window during animations.

BUG=http://crbug.com/14900
TEST=No visible impact, yet.
Review URL: http://codereview.chromium.org/391035

TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/414037
------------------------------------------------------------------------

I really dislike this behavior. I request that it be removed, although if that doesn't 
happen, can you at least restore the window position to it's previous state after 
closing the download bar?

My problem:

I keep my window just under the height of my desktop. When I download a file, the 
entire window shifts up to the top of my screen, and then when I close the download 
bar, the window maintains its new position. I would like the window to shift back 
down to where it was.

Thoughts?

ogkent: Yes, I guess we'll probably do this -- please see  issue 29192 , which is exactly 
about this. Thanks.