My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 144248: pageAction.show() animation (and I presume script badges too) aren't completing
8 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by a...@chromium.org, Aug 22, 2012
GTK 22.0.1229.12 (Official Build 152477) dev

They seem to finish at a random percent complete. Sometimes complete, sometimes not started, sometimes in between.

See screen shot for an in-between one.

Aug 22, 2012
#1 a...@chromium.org
This would actually be a regression in M21/22 if it is present there. Please add the Mstone-2x labels as appropriate.
Sep 20, 2012
#2 jyasskin@chromium.org
 Issue 148523  has been merged into this issue.
Sep 20, 2012
#3 jyasskin@chromium.org
 Issue 150931  has been merged into this issue.
Cc: jyasskin@chromium.org tbarzic@chromium.org
Sep 20, 2012
#4 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=157903

------------------------------------------------------------------------
r157903 | jyasskin@chromium.org | 2012-09-21T02:33:26.654479Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action_unittest.cc?r1=157903&r2=157902&pathrev=157903
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.cc?r1=157903&r2=157902&pathrev=157903

Turn off animations for page actions and browser actions.

The icon observation code isn't set up to watch non-script-badges, so page
action animations wind up partially complete or cause a white background in
script badge mode.  A future refactoring to ExtensionAction should make
animations work for all types, but this fix is simple to fix the problem on the
Chrome 23 and maybe Chrome 22 branches.

BUG=141808,144247,144248


Review URL: https://chromiumcodereview.appspot.com/10967020
------------------------------------------------------------------------
Sep 21, 2012
#5 jyasskin@chromium.org
(No comment was entered for this change.)
Labels: Mstone-22 Merge-Requested
Sep 24, 2012
#6 kerz@google.com
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
Sep 24, 2012
#7 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=158393

------------------------------------------------------------------------
r158393 | jyasskin@chromium.org | 2012-09-24T21:32:11.520732Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/common/extensions/extension_action_unittest.cc?r1=158393&r2=158392&pathrev=158393
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/common/extensions/extension_action.cc?r1=158393&r2=158392&pathrev=158393

Merge 157903 - Turn off animations for page actions and browser actions.

The icon observation code isn't set up to watch non-script-badges, so page
action animations wind up partially complete or cause a white background in
script badge mode.  A future refactoring to ExtensionAction should make
animations work for all types, but this fix is simple to fix the problem on the
Chrome 23 and maybe Chrome 22 branches.

BUG=141808,144247,144248


Review URL: https://chromiumcodereview.appspot.com/10967020

TBR=jyasskin@chromium.org
Review URL: https://codereview.chromium.org/10990005
------------------------------------------------------------------------
Labels: -Merge-Approved merge-merged-1229
Sep 24, 2012
#8 jyasskin@chromium.org
(No comment was entered for this change.)
Status: Started
Sep 25, 2012
#9 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=158746

------------------------------------------------------------------------
r158746 | jyasskin@chromium.org | 2012-09-26T04:41:54.157666Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/common/extensions/extension_action_unittest.cc?r1=158746&r2=158745&pathrev=158746

Move a line within the M22 branch that had been deleted from trunk before I
wrote this change.

BUG=144248
Review URL: https://codereview.chromium.org/10993032
------------------------------------------------------------------------
Sep 26, 2012
#10 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=158762

------------------------------------------------------------------------
r158762 | jyasskin@chromium.org | 2012-09-26T07:11:22.257846Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/common/extensions/extension_action_unittest.cc?r1=158762&r2=158761&pathrev=158762

Update another local variable reference that wasn't present on trunk.

BUG=144248
Review URL: https://codereview.chromium.org/10986043
------------------------------------------------------------------------
Sep 30, 2012
#11 jyasskin@chromium.org
 Issue 153203  has been merged into this issue.
Oct 1, 2012
#12 jyasskin@chromium.org
This also needs to be merged to the M23 branch.
Labels: -Mstone-22 Merge-Requested Mstone-23 ReleaseBlock-Stable
Oct 2, 2012
#13 kar...@google.com
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
Oct 2, 2012
#14 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=159747

------------------------------------------------------------------------
r159747 | jyasskin@chromium.org | 2012-10-02T20:02:18.466479Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/common/extensions/extension_action_unittest.cc?r1=159747&r2=159746&pathrev=159747
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/common/extensions/extension_action.cc?r1=159747&r2=159746&pathrev=159747

Merge 157903 - Turn off animations for page actions and browser actions.

The icon observation code isn't set up to watch non-script-badges, so page
action animations wind up partially complete or cause a white background in
script badge mode.  A future refactoring to ExtensionAction should make
animations work for all types, but this fix is simple to fix the problem on the
Chrome 23 and maybe Chrome 22 branches.

BUG=141808,144247,144248


Review URL: https://chromiumcodereview.appspot.com/10967020

TBR=kareng
Review URL: https://codereview.chromium.org/11043004
------------------------------------------------------------------------
Labels: -Merge-Approved merge-merged-1271
Oct 3, 2012
#15 kar...@google.com
can i close this?
Oct 4, 2012
#16 jyasskin@chromium.org
I need to double-check that script badge animations are completing, but this is certainly not blocking M23 anymore.
Labels: -Mstone-23 -ReleaseBlock-Stable Mstone-24
Jan 31, 2013
#17 dhar...@chromium.org
Moving it to mstone 26. Please change it to appropriate milestone.
Labels: -Mstone-24 Mstone-26 MovedFrom-24
Mar 10, 2013
#18 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Feature-Extensions -Mstone-26 Cr-Platform-Extensions Cr-UI M-26
Apr 3, 2013
#19 dhar...@google.com
Bulk edit: Moving non-release blocking bugs to M28.
Labels: -M-26 M-28 MovedFrom-M26
Apr 4, 2013
#20 jyasskin@chromium.org
Script badges are basically cancelled, so the page action fix is sufficient.
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting