My favorites ▼ | Sign in
Logo
Project Home
  
Downloads
  
Wiki
  
Issues
    
New issue | Search
for
| Advanced search | Search tips
Issue 13967: theme base colors should be picked from system colors
8 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  erg@chromium.org
Closed:  Aug 2009
Cc:  erg@chromium.org
Type-Bug
Pri-3
OS-Linux
Area-BrowserUI
Size-Medium
Mstone-LinuxBeta
Themes


Sign in to add a comment
 
Reported by tony.chromium, Jun 12, 2009 
The default blue looks out of place on many linux system color themes 
including ubuntu orange/brown.  Once themes support is more complete, it 
would be nice if we could pull colors from the system and use those as the 
base theme color.

Assigning to evan for now since I know he's done some work in having theme 
use default widget background colors.
Comment 1 by evan@chromium.org, Jun 25, 2009 
(No comment was entered for this change.)
Labels: Mstone-LinuxBeta
Comment 2 by evan@chromium.org, Jun 26, 2009 
(No comment was entered for this change.)
Status: Available
Owner: ---
Cc: e...@chromium.org
Comment 3 by dhw@chromium.org, Jun 27, 2009 
(No comment was entered for this change.)
Labels: Themes
Comment 4 by erg@chromium.org, Jun 30, 2009 
(No comment was entered for this change.)
Status: Started
Owner: e...@chromium.org
Comment 5 by bugdroid1@chromium.org, Jul 02, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=19868 

------------------------------------------------------------------------
r19868 | erg@google.com | 2009-07-02 17:42:29 -0700 (Thu, 02 Jul 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.h?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/back_forward_button_gtk.h?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_titlebar.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/custom_button.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/custom_button.h?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/find_bar_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_chrome_button.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_chrome_button.h?r1=19868&r2=19867
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/content_page_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/content_page_gtk.h?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profile.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profile.h?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=19868&r2=19867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/testing_profile.h?r1=19868&r2=19867

GTK: Initial implementation of using GTK themes, partially based on evan's CL 118358.

A lot of stuff works:
- Colors are picked out of the GTK theme.
- Buttons use the current GTK button theme.
- We use the user's icon theme.

A lot of stuff doesn't:
- We could do a better job of picking colors for the skylines.
- The omnibox hasn't been touched.
- UI that's not part of the toolbar hasn't been touched.
- We currently fail on themes like HighContrastInverse.

TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff.
TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images.
http://crbug.com/13967

Review URL: http://codereview.chromium.org/150176
------------------------------------------------------------------------
Comment 6 by Jayschwa, Jul 06, 2009 
Are there any plans to do this on Windows? It would be nice if the chrome's hue stayed 
in-sync with the system theme's color.
Comment 7 by bpgarman, Jul 07, 2009 
Thanks for the effort on this one, it makes a big difference. Just some comments from testing 3.0.193.0 
(20026):

1. Skyline often turns out the wrong colour (esp. on dark themes)
2. Chrome's maximize, minimize and close buttons are still based on Window's.
3. Toolbar icons should not have visible boxes when not highlighted
Comment 8 by bugdroid1@chromium.org, Jul 07, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20000 

------------------------------------------------------------------------
r20000 | erg@google.com | 2009-07-06 17:37:08 -0700 (Mon, 06 Jul 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc?r1=20000&r2=19999
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h?r1=20000&r2=19999
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_menu_controller_gtk.cc?r1=20000&r2=19999
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_utils_gtk.cc?r1=20000&r2=19999
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_utils_gtk.h?r1=20000&r2=19999
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=20000&r2=19999
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.cc?r1=20000&r2=19999
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.h?r1=20000&r2=19999

GTK Themes: Set the text color of bookmark buttons to theme color.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/155108
------------------------------------------------------------------------
Comment 9 by bugdroid1@chromium.org, Jul 07, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20043 

------------------------------------------------------------------------
r20043 | erg@google.com | 2009-07-07 10:43:01 -0700 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=20043&r2=20042
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/status_bubble_gtk.cc?r1=20043&r2=20042
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/status_bubble_gtk.h?r1=20043&r2=20042

GTK Themes: Status bubble obeys GTK colors now.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/149259
------------------------------------------------------------------------
Comment 10 by bugdroid1@chromium.org, Jul 08, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20085 

------------------------------------------------------------------------
r20085 | erg@google.com | 2009-07-07 14:31:39 -0700 (Tue, 07 Jul 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/blocked_popup_container.cc?r1=20085&r2=20084
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/blocked_popup_container.h?r1=20085&r2=20084
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/blocked_popup_container_unittest.cc?r1=20085&r2=20084
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.cc?r1=20085&r2=20084
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/blocked_popup_container_view_gtk.h?r1=20085&r2=20084
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.cc?r1=20085&r2=20084
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_gtk.h?r1=20085&r2=20084

GTK Themes: Theme the popup notification.

TEST=Open popuptest.com in one tab and anything else in another. Switch between
GTK theme and normal. Theme of blocked popup container should change, even when
not the active tab.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/149277
------------------------------------------------------------------------
Comment 11 by bugdroid1@chromium.org, Jul 08, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20102 

------------------------------------------------------------------------
r20102 | erg@google.com | 2009-07-07 17:10:41 -0700 (Tue, 07 Jul 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=20102&r2=20101
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=20102&r2=20101
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc?r1=20102&r2=20101
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h?r1=20102&r2=20101
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc?r1=20102&r2=20101
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h?r1=20102&r2=20101

GTK Themes: Use the correct text color in the tab strip.

BUG=http://crbug.com/13967

Review URL: http://codereview.chromium.org/155183
------------------------------------------------------------------------
Comment 12 by bugdroid1@chromium.org, Jul 09, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20308 

------------------------------------------------------------------------
r20308 | erg@google.com | 2009-07-09 13:35:19 -0700 (Thu, 09 Jul 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=20308&r2=20307
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h?r1=20308&r2=20307

GTK Themes: Prevent colors from "leaking through" by using an event box.

Some engines (clearlooks) query the bg color of a widget directly, so wrap the toolbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/155310
------------------------------------------------------------------------
Comment 13 by bugdroid1@chromium.org, Jul 15, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20799 

------------------------------------------------------------------------
r20799 | erg@google.com | 2009-07-15 15:41:19 -0700 (Wed, 15 Jul 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=20799&r2=20798
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc?r1=20799&r2=20798
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc?r1=20799&r2=20798
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_gtk.h?r1=20799&r2=20798
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc?r1=20799&r2=20798
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h?r1=20799&r2=20798
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc?r1=20799&r2=20798
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h?r1=20799&r2=20798

GTK Themes: Tint throbbers like we tint all other buttons in the interface.

http://crbug.com/13967

Review URL: http://codereview.chromium.org/155588
------------------------------------------------------------------------
Comment 14 by bugdroid1@chromium.org, Jul 15, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20809 

------------------------------------------------------------------------
r20809 | erg@google.com | 2009-07-15 16:36:05 -0700 (Wed, 15 Jul 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=20809&r2=20808
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/dragged_tab_gtk.cc?r1=20809&r2=20808
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_gtk.cc?r1=20809&r2=20808
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_gtk.h?r1=20809&r2=20808
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc?r1=20809&r2=20808
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h?r1=20809&r2=20808
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk_unittest.cc?r1=20809&r2=20808
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc?r1=20809&r2=20808
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.h?r1=20809&r2=20808

GTK Themes: Tint throbbers like we tint all other buttons in the interface.

Relanding with fixes for unit tests. Run through trybot this time...

http://crbug.com/13967

Original Review URL: http://codereview.chromium.org/155588

TBR=estade

Review URL: http://codereview.chromium.org/155601
------------------------------------------------------------------------
Comment 15 by bugdroid1@chromium.org, Jul 16, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20914 

------------------------------------------------------------------------
r20914 | erg@google.com | 2009-07-16 16:09:39 -0700 (Thu, 16 Jul 2009) | 14 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/star_noborder.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/starred_noborder.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/go_button_gtk.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/go_button_gtk.h?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h?r1=20914&r2=20913

GTK Themes: Make the location bar area look native.

Replace the star and go buttons with a native looking thing, where
we manually draw the theme's button image for the full omnibox area
and then position the star/go buttons on top of that.

Also adds stand in versions of star_noborder and starred_noborder
until Glen can make real icons.

http://crbug.com/16227
http://crbug.com/13967
http://crbug.com/16915

Review URL: http://codereview.chromium.org/149681
------------------------------------------------------------------------
Comment 16 by evan@chromium.org, Jul 17, 2009 
(No comment was entered for this change.)
Labels: -Pri-2 Pri-3
Comment 17 by CalebEgg, Jul 22, 2009 
This looks really nice so far! A few things:

* The resize border is dark-ish orange/brown, whereas in other windows it is light 
grey.

* Inactive tabs are light orange, even on inactive windows, but on other tabbed 
windows (such as the options dialog box) they are a slightly darker grey. I think the 
light orange inactive tabs look okay on the active window, but look kinda funny on 
the inactive window.

* The wrench menu icon could be replaced with the same icon used for "preferences" 
elsewhere (in Human, it's a wrench and screwdriver crossed). There are page icons too 
used for unrecognized file types, but I don't know if that would be a good 
association to have. The icon Nautilus uses to switch between a button-ey location 
bar and a text-ey location bar looks nice.

* The base title bar color is sort of bright looking. It took me a while to figure 
out that this is possibly so that Incognito mode can look different enough from 
normal mode even if the base theme color is like black (although I'm not certain on 
this...). But I think it would look nicer if there was a special condition for very 
low luminosity base theme colors that makes incognito's color lighter rather than 
darker. The bright orange title bars are sort of jarring, esp since the title bar is 
bigger than expected in Chrome.

Thanks!
Comment 18 by erg@chromium.org, Jul 23, 2009 
@CalebEgg

[[I'm omitting your first three issues since these have either been fixed for a week, 
or a decision was made to do it the way we did it. i.e., we make no effort to match 
your Window manager's borders when we draw the frame, as anyone who doesn't like it 
can let their window manager draw the frame with the "Use System Title Bar..." 
option.]]

The base title bar color is just the GTK bg[SELECTED] color. We do this because 
there's no such thing as a window bar color in a GTK theme, and the majority of 
window manager themes sample this color (optionally shadding it a bit) to paint their 
borders. If it doesn't match your metacity theme (or whatever WM you have), it's 
because that theme isn't using the bg[selected] color-- i.e. it's hard coding color 
values or using images. For example, Human's metacity theme 
(/usr/share/themes/Human/metacity-1/metacity-theme-1.xml) takes the bg[SELECTED] 
color and tints it. I don't have that information and can't reasonably get it for 
metacity because the theme files are XML serialized cairo drawing primitives. This 
ignores the long tail of window managers.

The only way to get around this that I can think of is to allow GTK theme authors to 
somehow signal to us to use a specific color for the theme border. This is  issue 
16271 .

Very dark themes (that specify a dark color as their bg[selected]) already have 
lighter borders in Incognito mode.
Comment 19 by bugdroid1@chromium.org, Jul 27, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=21704 

------------------------------------------------------------------------
r21704 | erg@google.com | 2009-07-27 14:08:06 -0700 (Mon, 27 Jul 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/gfx/gtk_util.h?r1=21704&r2=21703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.cc?r1=21704&r2=21703

GTK Themes: A gtkrc file can now override our choice of frame color by
specifying "frame_color" and "inactive_frame_color" in the gtk_color_scheme.

Also attempts to do a better job matching the frame color. Most window
managers (defined as metacity default theme and xfwm's default theme)
take bg[SELECTED] tint it by 80%. We hand code that behaviour in, as it
will be wrong a smaller percentage of the time then our current
behaviour.

http://crbug.com/16271 (dark theme bug)
http://crbug.com/13967 (theme color metabug)

Review URL: http://codereview.chromium.org/160188
------------------------------------------------------------------------
Comment 20 by erg@chromium.org, Aug 18, 2009 
At this point, so much of the linux native theming is done that having a big ambiguous 
bug like this is not-helpful. Closing. Open specific issues.
Status: Fixed
► Sign in to add a comment

Powered by Google Project Hosting