My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 13554: Spell Checker does not correct word in gmail
6 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  est...@chromium.org
Closed:  Jun 2009
Cc:  evan@chromium.org, est...@chromium.org

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Reported by ron.scho...@gmail.com, Jun 6, 2009
Chrome Version       : <include svn revno; e.g. dpkg -s chromium-browser>
OS + version :
CPU architecture (32-bit / 64-bit):
window manager :
URLs (if applicable) :
Behavior in Firefox 3.x (if applicable):
Behavior in Chrome for Windows (optional):

What steps will reproduce the problem?
1. compose an email in gmail (secure connection was used)
2. spell a word wrong
3. right-click on misspelled word and select correct spelling
4. misspelled word is still shown

What is the expected result?
The correctly spelled word should replace the misspelled word

What happens instead?
The misspelled word remains

Please provide any additional information below. Attach a screenshot
and backtrace if possible.

Jun 8, 2009
#1 est...@chromium.org
I suspect this has the same root cause as  issue 13404 .
Status: Assigned
Owner: est...@chromium.org
Cc: e...@chromium.org
Jun 10, 2009
#2 est...@chromium.org
confirmed that my (as yet uncommitted) patch for 13404 fixes this.
Jun 11, 2009
#4 est...@chromium.org
(No comment was entered for this change.)
Status: Fixed
Jun 15, 2009
#5 est...@chromium.org
 Issue 13723  has been merged into this issue.
Cc: est...@chromium.org
Jun 16, 2009
#6 aoca...@chromium.org
 Issue 14143  has been merged into this issue.
Jun 17, 2009
#7 dmitrij....@gmail.com
This is still present in Version: 3.0.189.0~svn20090616r18459-0ubuntu1~ucd2~jaunty
Jun 17, 2009
#8 evan@chromium.org
Reopening due to comment #7.
Status: Assigned
Jun 17, 2009
#9 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=18667 

------------------------------------------------------------------------
r18667 | estade@chromium.org | 2009-06-17 16:31:48 -0700 (Wed, 17 Jun 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc?r1=18667&r2=18666

Linux: Don't try to special case webkit blur when we stop showing right click context menu.

After I spent more time investigating, it seems that when the popup menu closes, it always returns focus to the toplevel that previously had it. Thus we don't have to worry about some other toplevel getting focus without us getting another focus-out.

BUG=13554
TEST=right click spellcheck correction works in gmail

Review URL: http://codereview.chromium.org/126301
------------------------------------------------------------------------

Jun 17, 2009
#10 est...@chromium.org
Let's hope it's fixed for real this time. Someone to verify.
Status: Fixed
Jun 23, 2009
#11 est...@chromium.org
 Issue 15105  has been merged into this issue.
Oct 11, 2012
#12 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Sign in to add a comment

Powered by Google Project Hosting