My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 13290: User scripts not working
22 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  aa@chromium.org
Closed:  Aug 2009
Cc:  glen@chromium.org, prog...@chromium.org
Type-Bug
Pri-2
OS-All
Area-Extensions
Feature-Extensions
ext


Sign in to add a comment
 
Reported by cerados, Jun 03, 2009
Chrome Version       : 3.0.184.0 (Developer Build 17539)
URLs (if applicable) : n/a
Other browsers tested: n/a

What steps will reproduce the problem?
1. Download .user.js files into the "User Scripts" folder in the Chromium 
profile folder.
2. Run Chromium with the --enable-user-scripts command switch.

What is the expected result?
User scripts are activated.

What happens instead?
User scripts have no effect.

Please provide any additional information below. Attach a screenshot if
possible.
Tested with AdSweep and Flashblock from www.adsweep.org
Comment 1 by TheCybor...@gmail.com, Jun 04, 2009
Chrome version: 3.0.182.3 (17055)
Works fine for me. Using serveral userscripts from userscripts.org, such as Any 
Remover, Youtube Downloader, Greased Lightbox and more.
Comment 2 by cerados, Jun 04, 2009
Please verify that the issue does not exist in 3.0.184.0 (Developer Build 17539).
.
Comment 3 by michael.monreal, Jun 04, 2009
cerados, what platform are you on? I see the same problem on trunk (3.x) builds on
Linux. Maybe only broken on this platform?
Comment 4 by cerados, Jun 04, 2009
Platform is Windows Vista SP1.
Comment 5 by scotlunsford, Jun 04, 2009
Does not work for me on XP SP3
Google Chrome	3.0.183.1 (Official Build 17570)

Comment 6 by stardust1982, Jun 04, 2009
" --enable-user-scripts" doesn't work

System: xp sp2
Chromium: 3.0.184.0
Comment 7 by ismail.donmez, Jun 05, 2009
Same problem here, started with 3.0.183.1 update.
Comment 8 by freeman...@gmail.com, Jun 05, 2009
Win XP SP3
3.0.183.1

" --enable-user-scripts" doesn't work

At least Yahoo Mail now works... 2 steps forward / 1 step back
Comment 9 by aa@chromium.org, Jun 05, 2009
 Issue 13448  has been merged into this issue.
Cc: g...@chromium.org
Comment 10 by aa@chromium.org, Jun 05, 2009
(No comment was entered for this change.)
Status: Available
Owner: a...@chromium.org
Comment 11 by aa@chromium.org, Jun 05, 2009
(No comment was entered for this change.)
Labels: -Area-Misc Area-Extensions
Comment 12 by divilex@hotmail.com, Jun 05, 2009
Add label: Assigned.
Comment 13 by aa@chromium.org, Jun 05, 2009
(No comment was entered for this change.)
Status: Assigned
Comment 14 by matthew.chen, Jun 07, 2009
"content scripts" doesn't work either, for example, the sample code in your site 
"Subscribe in Google Reader" doesn't work.
Comment 15 by bugdroid1@chromium.org, Jun 08, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=17898 

------------------------------------------------------------------------
r17898 | aa@chromium.org | 2009-06-08 14:01:53 -0700 (Mon, 08 Jun 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.cc?r1=17898&r2=17897
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service_unittest.cc?r1=17898&r2=17897
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=17898&r2=17897
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/testing_profile.h?r1=17898&r2=17897

Fix user scripts not getting initialized.

BUG=13290,13128
TEST=Add --enable-user-scripts to command line without --enable-extensions or --load-extension. Start Chrome, user scripts should work. Also run ui tests with --enable-extensions.

Review URL: http://codereview.chromium.org/119256
------------------------------------------------------------------------

Comment 16 by aa@chromium.org, Jun 08, 2009
(No comment was entered for this change.)
Status: Fixed
Comment 17 by cmroddy, Jun 15, 2009
i am able to reproduce this problem on 3.0.189.0 (18456) on linux.
Comment 18 by aocampo@chromium.org, Jun 16, 2009
 Issue 13522  has been merged into this issue.
Comment 19 by cmroddy, Jun 17, 2009
my user scripts are executing as of 3.0.190.0 (18673) on linux.
Comment 20 by Sandshrew, Jun 18, 2009
Somebody managed to break userscripts once again (tested with r18695)...
Comment 21 by aa@chromium.org, Jun 18, 2009
@sandshrew: What platform are you testing on?
Comment 22 by freeman...@gmail.com, Jun 18, 2009
Userscripts are broken again in the latest release for Windows.

I just upgraded to 3.0.189.0
Win XP SP2

This is getting pathetic.
Comment 23 by Sandshrew, Jun 18, 2009
@aa
Linux. Next time please "don't fix what ain't broken" or at least CAREFULLY test the 
changes before submitting.
Comment 24 by aa@chromium.org, Jun 18, 2009
Blech. Reopening.

I don't repro this on Windows, but several people have reported it now.

@sandshrew, thanks for the information.
Status: Available
Comment 25 by normanr, Jun 18, 2009
FYI: I could repo it, and then I installed an extension, which magically made all my 
user-scripts work.  So I'd guess it's some sort of user-scripts don't work unless you 
have extensions installed bug.
Comment 26 by cerados, Jun 18, 2009
@sandshrew,

"Next time please "don't fix what ain't broken" or at least CAREFULLY test the 
changes before submitting."

How about next time, please don't use unstable nightly builds if you can't stand bugs?
Comment 27 by igitur, Jun 18, 2009
I think adding --enable-extensions (in addition to --enable-user-scripts) to Chrome's 
parameters is a work-around.

Hear hear @cerados!
Comment 28 by Sandshrew, Jun 18, 2009
@cerados
There are no stable builds for linux.

@igitur
This doesn't seem to help in linux.
Comment 29 by aa@chromium.org, Jun 18, 2009
Ok, thanks to the helpful information from cerados, I see the issue.

This was busted (again) @18397 and then fixed (again) @18661. The issue (again) was that 
UserScriptMaster is relying on ExtensionsService to tell it when to start, and we keep breaking the 
code that guarantees that will happen under all circumstances. In this case, it doesn't happen if 
the extensions node in the preferences file doesn't exist.

If you install at least one extension, the node will be created. Another way to create would be to 
add this entry under the root node of your Preferences file in <user data dir>/Preferences:

"extensions": {
  "settings": {
  }
},

This has already been fixed on trunk, but I'm leaving this bug open on myself to add more tests for 
this area.
Status: Assigned
Comment 30 by freeman...@gmail.com, Jun 18, 2009
Thank you AA.

Confirmed on my end that it works.  I had --enable-extensions already there when it 
was not working, but I did not have any extensions installed.

I added AniWeather extension just now and all of my user scripts have started working 
again.

@Sandshrew
I am with you.  Lately the builds seem more sloppy than before (eg, user scripts 2 
times, yahoo mail not working, etc...). This time however, I see why it would be 
unlikely to be discovered in a dev build before pushing out to users.  Yahoo Mail 
issue on the other hand should never have happened.  Too popular of a site to not 
check with a dev build.
Comment 31 by cerados, Jun 18, 2009
Off-topic, but I'm afraid I'll have to agree that the builds seem to be getting more 
and more unstable even though I understand they're supposed to be. Chromium was more or 
less usable as my main browser a few months ago, but lately I'm finding an average of 
1-2 bugs every week, and waiting for ages before my bug reports get noticed, and even 
longer for the fix to arrive.

Minefield and WebKit nightlies seem rock-stable compared to the current state Chromium 
is in.
Comment 32 by cmroddy, Jun 18, 2009
Thank you all for your attention to this issue.
Comment 33 by hotaru.firefly, Jun 21, 2009
extensions are still not working for me in 3.0.189.0 (Official Build 18569), with --
enable-user-scripts and --enable-extensions, even after adding the extensions node to 
my preferences file.
Comment 34 by aa@chromium.org, Jun 21, 2009
@hotaru.firefly: You need to add the settings child, too. If that doesn't work, please 
try installing one extension from the samples page and uninstalling it. This should 
kick things into the right state. Otherwise, just wait for the next build.
Comment 35 by hotaru.firefly, Jun 21, 2009
i had added the settings child when i added the extensions one, i copied and pasted it 
from your (aa@chromium's) comment.
installing an extension fixed it, thanks.
Comment 36 by dhw@chromium.org, Jun 22, 2009
 Issue 14650  has been merged into this issue.
Comment 37 by webiest, Jul 09, 2009
When I --enable-user-scripts and go to any page, the browser crashes.  I'm on windows 7 
with build 3.0.193.0 (20255)
Comment 38 by prog...@chromium.org, Jul 22, 2009
webiest, what do you mean by "browser crashes"? is this the aw snap page reported in  
 Issue 16421  ?
Cc: prog...@chromium.org
Comment 39 by webiest, Jul 22, 2009
Yes it is.  I get an aw snap page on every tab opened.
Comment 40 by aa@chromium.org, Aug 16, 2009
Since at least one version of 'user scripts not working' has been fixed, I'm going to 
close this. If it reoccurs, let's try and open new bugs to track particular causes.
Status: Fixed
Comment 41 by sergei.polishchuk, Jan 27, 2010
User scripts are not woking in 4.0.249.78 (36714) build.
I tried different combinations:
chrome.exe
chrome.exe --enable-user-scripts
chrome.exe --enable-user-scripts --enable-extensions
Nothing works.
Previous stable release did not have any problems with user scripts.
How to fix this issue?
Thanks.
Comment 42 by pcxunlimited, Jan 27, 2010
@sergei.polishchuk: User Scripts are now automatically converted into extensions. 
Simply drag the .user.js file into Chrome and it should install properly.

 Bug 22103  refers to this.
Comment 43 by erikkay@chromium.org, Mar 03, 2010
(No comment was entered for this change.)
Labels: Feature-Extensions
Sign in to add a comment

Powered by Google Project Hosting