| Issue 13216: | downloaded file info is a bit messy in RTL | |
| 4 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome Version : 3.0.183.0 (17405 What steps will reproduce the problem? 1. download a file (preferably a big one to see it in action) 2. look at the download tab (Ctrl+J) What is the expected result? the file name should appear on the right i think What happens instead? the file name is stuck in the middle of the line More info : this bug appears in hebrew enabled vista, but maybe using an English vista with chrome and a UI in hebrew will reproduce it too |
||||||||||||||||||||
,
Jun 02, 2009
(No comment was entered for this change.)
Cc: jer...@chromium.org x...@chromium.org xly...@chromium.org
Labels: RTL |
|||||||||||||||||||||
,
Jun 08, 2009
This can be fixed along with issue 13215 .
Status: Started
Owner: js...@chromium.org Labels: I18N |
|||||||||||||||||||||
,
Jun 09, 2009
When I wrote the previous comment, I misunderstood the requirement. It turned out to be a bit trickier. See http://i18nl10n.com/chrome/he_dl2.html. We have to use inline- block for either filename or 'status string' instead of inline to prevent the 'interaction' between them when BiDi algorithm is applied. Anyway, the CL is up at http://codereview.chromium.org/119318
Labels: -Area-Misc Area-BrowserUI
|
|||||||||||||||||||||
,
Jun 09, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=18022
------------------------------------------------------------------------
r18022 | jshin@chromium.org | 2009-06-09 20:24:38 -0700 (Tue, 09 Jun 2009) | 12 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/downloads.html?r1=18022&r2=18021
Fix the in-progress download status for the RTL UI.
1. Make the download progress pie chart fill up CW even in the RTL UI.
2. Make the filename be at the right end instead of being in the middle of the download status in the RTL UI.
BUG=13215,13216 (http://crbug.com/13215, http://crbug.com/13216)
TEST=1. Launch Chrome with --lang=he or --lang=ar.
2. Download a large file (like chrome mini-installer or Firefox) and go to the download tab (pressing Ctrl-J would work)
3. The progress pie-chart should be filled up clockwise.
4. The filename should be to the right of the download status ('5 kB of 7.2 MB - 4 mins left' in Hebrew or Arabic) instead of being put in the middle of the status string.
Review URL: http://codereview.chromium.org/119318
------------------------------------------------------------------------
|
|||||||||||||||||||||
,
Jun 09, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||
