| Issue 13215: | inconsistency with regards to download "progress pie" in RTL | |
| 5 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome Version : 3.0.183.0 (17405) What steps will reproduce the problem? 1. download any file (preferably big so you can see it happening) 2. look in the download shelf, and in the download page at the progress pie What is the expected result? they both should "fill" in the same direction What happens instead? the shelf one fills CW, the download page is CCW Summary: i personally prefer CW, but anyways it should be consistent |
||||||||||||||||||||
,
Jun 02, 2009
More info : this bug appears in hebrew enabled vista, but maybe using an English vista with chrome and a UI in hebrew will reproduce it too |
|||||||||||||||||||||
,
Jun 02, 2009
(No comment was entered for this change.)
Cc: jer...@chromium.org x...@chromium.org xly...@chromium.org
Labels: RTL |
|||||||||||||||||||||
,
Jun 08, 2009
I also think CW makes more sense regardless of the directionality of the UI language.
Cc: g...@chromium.org
Labels: -Area-Misc Area-BrowserUI I18N |
|||||||||||||||||||||
,
Jun 08, 2009
(No comment was entered for this change.)
Cc: a...@chromium.org
|
|||||||||||||||||||||
,
Jun 08, 2009
Jeremy, do you agree that it's better to use CW than CCW for RTL UI? If so, it's trivial to fix and I can make a CL. |
|||||||||||||||||||||
,
Jun 08, 2009
i support CW (or in other words, it doesn't matter), just because we write from the right side, doesn't mean we see everything upside down ;) |
|||||||||||||||||||||
,
Jun 08, 2009
personally, I have no preference. I'm concerned with bicycle shedding these kinds of bugs. |
|||||||||||||||||||||
,
Jun 09, 2009
Jshin, if this is ok to ask, i would like to fix it myself, as i wish to solve other RTL related bugs in the GUI and need the practice, if this is cool with you, let me know |
|||||||||||||||||||||
,
Jun 09, 2009
Thank you for the feedback. I thought what program wrote is the case (Hebrew clocks run CW :-)) and made a patch for this and issue 13216 ( http://codereview.chromium.org/119318 ). yoav, thank you for the offer. Without/before reading comment, I made a CL. However, I'm sure there are a lot of other issues you can help us with and everybody in the chrome team would love you to fix other RTL bugs !
Status: Started
Owner: js...@chromium.org |
|||||||||||||||||||||
,
Jun 09, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=18022
------------------------------------------------------------------------
r18022 | jshin@chromium.org | 2009-06-09 20:24:38 -0700 (Tue, 09 Jun 2009) | 12 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/downloads.html?r1=18022&r2=18021
Fix the in-progress download status for the RTL UI.
1. Make the download progress pie chart fill up CW even in the RTL UI.
2. Make the filename be at the right end instead of being in the middle of the download status in the RTL UI.
BUG=13215,13216 (http://crbug.com/13215, http://crbug.com/13216)
TEST=1. Launch Chrome with --lang=he or --lang=ar.
2. Download a large file (like chrome mini-installer or Firefox) and go to the download tab (pressing Ctrl-J would work)
3. The progress pie-chart should be filled up clockwise.
4. The filename should be to the right of the download status ('5 kB of 7.2 MB - 4 mins left' in Hebrew or Arabic) instead of being put in the middle of the status string.
Review URL: http://codereview.chromium.org/119318
------------------------------------------------------------------------
|
|||||||||||||||||||||
,
Jun 09, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=18023
------------------------------------------------------------------------
r18023 | jshin@chromium.org | 2009-06-09 20:28:46 -0700 (Tue, 09 Jun 2009) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/downloads.html?r1=18023&r2=18022
Add a comment per review comment I missed in the previous check-in.
BUG=13215
TBR=jeremy
TEST=none
------------------------------------------------------------------------
|
|||||||||||||||||||||
,
Jun 10, 2009
if you're updating the download page layout... have a look at issue 13386 please a pretty obvious bug and yet i couldn't find any official info about it |
|||||||||||||||||||||
,
Jun 11, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||||
,
Jul 27, 2009
Issue 17302 has been merged into this issue. |
|||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||