My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 131844: PolicyService needs to become a ProfileKeyedService
2 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by pkasting@chromium.org, Jun 8, 2012
Services should be moved out of the Profile class and made into Factory-controlled ProfileKeyedServices. This is part of the effort to refactor Profiles to be more lightweight and modular, and will allow for exact control of the order of shutdown and startup of services.

Here's a doc which may be helpful in getting started: https://sites.google.com/a/chromium.org/dev/developers/design-documents/profile-architecture

Please reassign to the appropriate person if it is not yourself.
Jun 8, 2012
#1 mnissler@chromium.org
(No comment was entered for this change.)
Cc: joaodasilva@chromium.org bauerb@chromium.org
Labels: Feature-Enterprise
Jun 8, 2012
#2 joaodasilva@chromium.org
This isn't a trivial change because the PrefService depends on the PolicyService, and it would have to become a ProfileKeyedService itself too.
Jun 8, 2012
#3 mnissler@chromium.org
Which is why we're blocked on issue 131843 :)
Jun 11, 2012
#4 bauerb@chromium.org
(No comment was entered for this change.)
Blockedon: -chromium:131843 131843
Mar 10, 2013
#5 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Feature-Profiles -Feature-Enterprise Cr-UI Cr-UI-Browser-Profiles Cr-Enterprise
Blockedon: -chromium:131843 chromium:131843
Oct 8, 2014
#6 sdefresne@chromium.org
I see that PrefService was moved to //base/prefs.

Is there still any reason for the factories to inherit from BrowserContextKeyedBaseFactory instead of BrowserContextKeyedServiceFactory? I don't think we can turn PrefService into a KeyedService, but since it is now in base, I don't know if the comment about a dependency on PolicyService is relevant or not.

Impacted files:
chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.h
chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h
chrome/browser/policy/profile_policy_connector_factory.h
chrome/browser/policy/schema_registry_service_factory.h

Oct 8, 2014
#7 mnissler@chromium.org
The PrefService instances in chrome/ still depend on PolicyService, deriving from BrowserContextKeyedBaseFactory allows them the implement non-standard lifetime management so they can outlive PrefService.
Sign in to add a comment

Powered by Google Project Hosting