My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 13158: Implement printing on Mac
33 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by rohitrao@chromium.org, Jun 1, 2009
Tracking bug for the Mac OS known issue:
Printing a webpage is not implemented.
Jun 15, 2009
#1 stuartmorgan@chromium.org
 Issue 14110  has been merged into this issue.
Jun 17, 2009
#2 stuartmorgan@chromium.org
(No comment was entered for this change.)
Status: Untriaged
Jul 28, 2009
#3 pinkerton@chromium.org
(No comment was entered for this change.)
Status: Available
Labels: Mstone-4
Sep 2, 2009
#4 j...@chromium.org
Not a blocker for mstone-4 moving to mstone-5
Labels: -mstone-4 mstone-5
Sep 4, 2009
#5 jeremy@chromium.org
(No comment was entered for this change.)
Owner: jer...@chromium.org
Cc: j...@chromium.org stuartmo...@chromium.org
Labels: -mstone-5 mstone-4 ReleaseBlock-Beta
Sep 10, 2009
#6 mark@chromium.org
 Issue 21361  has been merged into this issue.
Sep 10, 2009
#7 maruel@chromium.org
 Issue 16116  has been merged into this issue.
Cc: maruelatchromium ama...@chromium.org pinker...@chromium.org thoma...@chromium.org
Sep 10, 2009
#8 maruel@chromium.org
(No comment was entered for this change.)
Summary: Implement printing on Mac
Labels: Printing
Sep 10, 2009
#9 maruel@chromium.org
(No comment was entered for this change.)
Blockedon: 19223
Sep 14, 2009
#10 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=26104 

------------------------------------------------------------------------
r26104 | maruel@chromium.org | 2009-09-14 07:54:38 -0700 (Mon, 14 Sep 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/master.tryserver/master.cfg?r1=26104&r2=26103

Add printing test for mac try slaves, working since r26103

TEST=printing_unittests
BUG=13158

Review URL: http://codereview.chromium.org/200120

------------------------------------------------------------------------

Sep 14, 2009
#11 maruel@chromium.org
test
Blockedon: -19223
Sep 14, 2009
#12 maruel@chromium.org
(No comment was entered for this change.)
Blockedon: 19223
Sep 15, 2009
#13 pinkerton@chromium.org
(No comment was entered for this change.)
Labels: -Pri-2 Pri-1
Sep 15, 2009
#14 pinkerton@chromium.org
(No comment was entered for this change.)
Owner: stuartmo...@chromium.org
Sep 17, 2009
#15 stuartmorgan@chromium.org
 Issue 22008  has been merged into this issue.
Sep 28, 2009
#16 ben@chromium.org
(No comment was entered for this change.)
Status: Assigned
Oct 5, 2009
#17 rohitrao@chromium.org
 Issue 23691  has been merged into this issue.
Oct 13, 2009
#18 stuartmorgan@chromium.org
I'm not sure why the commit messages never showed up here, but this is fixed by
http://codereview.chromium.org/269041 (r26932)
http://codereview.chromium.org/268036 (r28722)
http://codereview.chromium.org/276004 (r28907)

Follow-up bugs for minor remaining issues will be filed shortly.
Blockedon: -19223
Oct 13, 2009
#19 stuartmorgan@chromium.org
(No comment was entered for this change.)
Status: Fixed
Oct 14, 2009
#20 maruel@chromium.org
(No comment was entered for this change.)
Labels: -Printing Feature-Printing
Oct 14, 2009
#21 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28722 

------------------------------------------------------------------------
r28722 | stuartmorgan@chromium.org | 2009-10-12 11:45:31 -0700 (Mon, 12 Oct 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/native_metafile.h?r1=28722&r2=28721
   A http://src.chromium.org/viewvc/chrome/trunk/src/printing/pdf_metafile_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/printing/pdf_metafile_mac.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/printing/pdf_metafile_mac_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing.gyp?r1=28722&r2=28721

Implement a version of NativeMetafile for the Mac

This is the first of series of patches to implement printing on the Mac.

This API is based heavily on the Linux version; although it doesn't end up abstracting very much on the Mac, having a NativeMetafile implementation makes it easy to pass data through the existing print architecture.

BUG=13158
TEST=Printing unit tests; no effect in the application yet.

Review URL: http://codereview.chromium.org/269041
------------------------------------------------------------------------

Oct 14, 2009
#22 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28857 

------------------------------------------------------------------------
r28857 | stuartmorgan@chromium.org | 2009-10-13 11:46:21 -0700 (Tue, 13 Oct 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/print_settings.cc?r1=28857&r2=28856
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/print_settings.h?r1=28857&r2=28856
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/printed_document.cc?r1=28857&r2=28856
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/printed_document.h?r1=28857&r2=28856
   A http://src.chromium.org/viewvc/chrome/trunk/src/printing/printed_document_linux.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/printing/printed_document_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/printing/printed_document_win.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing.gyp?r1=28857&r2=28856
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing_context.h?r1=28857&r2=28856
   D /trunk/src/printing/printing_context_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing_context_mac.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing_context_win.cc?r1=28857&r2=28856

Implement the basic OS-level printing mechanics on Mac

Part two of printing implementation on the Mac. This adds a Mac implementation of PrintSettings to get page setup and printer information, basic PDF->context rendering in PrintedDocument, and most of PrintingContext to allow getting print settings (both default and interactive).

Reworks the message flow a bit when asking for print settings on the Mac, since it can only be done from the UI thread. Uses a modal dialog for now, but will later be modified further to allow for a sheet.

BUG=13158
TEST=None; no user-visible effect yet.

Review URL: http://codereview.chromium.org/268036
------------------------------------------------------------------------

Oct 14, 2009
#23 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28907 

------------------------------------------------------------------------
r28907 | stuartmorgan@chromium.org | 2009-10-13 15:54:12 -0700 (Tue, 13 Oct 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_job.cc?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_job_worker.cc?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_job_worker.h?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_view_manager.cc?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/printer_query.cc?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/printer_query.h?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.h?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/temp_scaffolding_stubs.h?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.cc?r1=28907&r2=28906
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.h?r1=28907&r2=28906
   D /trunk/src/chrome/renderer/print_web_view_helper_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper_mac.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view_unittest.cc?r1=28907&r2=28906

Wire up printing on the Mac

Get the printing support class stack building and hooked up on the Mac.
Add support for creating NativeMetafile objects with PDF print data on the renderer side, and passing them to the browser via the existing printing IPC system.
Flip on the simpler printing unit tests (those that don't require PDF -> bitmap conversion).

BUG=13158
TEST=Print on the Mac--it should work!

Review URL: http://codereview.chromium.org/276004
------------------------------------------------------------------------

Oct 15, 2009
#24 deep...@chromium.org
4.0.223.0 (Official Build 29072)
Status: Verified
Oct 16, 2009
#25 maruel@chromium.org
 Issue 25007  has been merged into this issue.
Oct 12, 2012
#26 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#27 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -mstone-4 -Feature-Printing M-4 Cr-Internals-Printing
Mar 13, 2013
#28 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment

Powered by Google Project Hosting