My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 13007: Amazon UK Segmentation Fault in SkScalerContext_FreeType::generateFontMetrics
5 people starred this issue and may be notified of changes. Back to list
 
Reported by pdknsk, May 30, 2009
Chrome Version : 17294
OS + version : Fedora 8/9
CPU architecture (32-bit / 64-bit): 32
URLs (if applicable) : http://www.amazon.co.uk/gp/product/B001T8W2LW/

Chrome works fine, except for Amazon UK which causes an Aw Snap. The 
frontpage http://www.amazon.co.uk doesn't, but selecting any item does.  
The URL is just an example. It does briefly display the rendered page 
before the Aw Snap. It happens with and without msttcorefonts, but the 
backtrace is without them.

Please provide any additional information below. Attach a screenshot
and backtrace if possible.

http://pastebin.com/m436897d2

Comment 1 by pdknsk, May 30, 2009
Probably better to have everything in the same place.

GNU gdb Red Hat Linux (6.6-45.fc8rh)
Copyright (C) 2006 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i386-redhat-linux-gnu"...
Using host libthread_db library "/lib/libthread_db.so.1".
(gdb) run
Starting program: /opt/chrome-linux/chrome --lang=en-US --force-
fieldtest=DnsImpact/_disabled_prefetch --type=renderer --
channel=6145.9ae2798.32973000
Missing separate debuginfo for /usr/lib/libnss3.so.1d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/58/e14911c3c83cf9eb9c740797ac6b63c9f2738a.debug
Missing separate debuginfo for /usr/lib/libnssutil3.so.1d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/04/e0b5187337817e66e3af9cd4e0877b6d0b41b3.debug
Missing separate debuginfo for /usr/lib/libsmime3.so.1d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/f8/c2942104282d95032fd2ee1df5a0f7b18d033c.debug
Missing separate debuginfo for /usr/lib/libssl3.so.1d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/b0/6d004ca9225a82a0bf8bffb361e361d5fd50be.debug
Missing separate debuginfo for /usr/lib/libplds4.so.0d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/58/e14911c3c83cf9eb9c740797ac6b63c9f2738a.debug
Missing separate debuginfo for /usr/lib/libnssutil3.so.1d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/04/e0b5187337817e66e3af9cd4e0877b6d0b41b3.debug
Missing separate debuginfo for /usr/lib/libsmime3.so.1d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/f8/c2942104282d95032fd2ee1df5a0f7b18d033c.debug
Missing separate debuginfo for /usr/lib/libssl3.so.1d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/b0/6d004ca9225a82a0bf8bffb361e361d5fd50be.debug
Missing separate debuginfo for /usr/lib/libplds4.so.0d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/15/949d3bef991af8b770d753ea9ffcfca7079df7.debug
Missing separate debuginfo for /usr/lib/libplc4.so.0d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/83/a233221ad121a444137fc6f6b49c0684c99b51.debug
Missing separate debuginfo for /usr/lib/libnspr4.so.0d
Try: yum --enablerepo='*-debuginfo' install /usr/lib/debug/.build-
id/f0/26841d024bbdcfb877b250dd3e3a6237315d1b.debug
[Thread debugging using libthread_db enabled]
[New Thread -1218001200 (LWP 6358)]
[New Thread -1218700400 (LWP 6371)]
 
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1218700400 (LWP 6371)]
0x08528dee in SkScalerContext_FreeType::generateFontMetrics ()
Current language:  auto; currently asm
Missing separate debuginfos, use: debuginfo-install GConf2.i386 ORBit2.i386 alsa-
lib.i386 atk.i386 cairo.i386 expat.i386 fontconfig.i386 freetype.i386 gcc.i386 
glib2.i386 glibc.i386 libX11.i386 libXau.i386 libXcomposite.i386 libXcursor.i386 
libXdamage.i386 libXdmcp.i386 libXext.i386 libXfixes.i386 libXi.i386 libXinerama.i386 
libXrandr.i386 libXrender.i386 libpng.i386 libxcb.i386 pango.i386 pixman.i386 
zlib.i386
(gdb) backtrace
#0  0x08528dee in SkScalerContext_FreeType::generateFontMetrics ()
#1  0x08507153 in SkGlyphCache::SkGlyphCache ()
#2  0x08507317 in SkGlyphCache::VisitCache ()
#3  0x0850b77a in FontMetricsDescProc ()
#4  0x0850c53b in SkPaint::descriptorProc ()
#5  0x0850c85d in SkPaint::getFontMetrics ()
#6  0x08caf04c in WebCore::SimpleFontData::platformInit ()
#7  0x08cb938c in WebCore::SimpleFontData::SimpleFontData ()
#8  0x08cb558c in WebCore::FontCache::getCachedFontData ()
#9  0x08cb7337 in WebCore::FontCache::getFontData ()
#10 0x08a678f8 in WebCore::FontFallbackList::fontDataAt ()
#11 0x08a65e5b in WebCore::Font::cachePrimaryFont ()
#12 0x08bff446 in WebCore::CSSPrimitiveValue::computeLengthDouble ()
#13 0x08bff627 in WebCore::CSSPrimitiveValue::computeLengthIntForLength ()
#14 0x08c253b9 in WebCore::CSSStyleSelector::applyProperty ()
#15 0x08c2ba85 in WebCore::CSSStyleSelector::applyDeclarations ()
#16 0x08c2d796 in WebCore::CSSStyleSelector::styleForElement ()
#17 0x08904e83 in WebCore::Node::styleForRenderer ()
#18 0x089072ab in WebCore::Node::createRendererIfNeeded ()
#19 0x088fa175 in WebCore::Element::attach ()
#20 0x08c79283 in WebCore::HTMLFormControlElement::attach ()
#21 0x089a2f40 in WebCore::HTMLInputElement::attach ()
#22 0x08c88160 in WebCore::HTMLParser::insertNode ()
#23 0x08c89d1b in WebCore::HTMLParser::parseToken ()
#24 0x089b75b2 in WebCore::HTMLTokenizer::processToken ()
#25 0x089bcc07 in WebCore::HTMLTokenizer::parseTag ()
#26 0x089bfd60 in WebCore::HTMLTokenizer::write ()
#27 0x089bda11 in WebCore::HTMLTokenizer::notifyFinished ()
#28 0x089d9eff in WebCore::CachedScript::checkNotify ()
#29 0x08a13492 in WebCore::Loader::Host::didFinishLoading ()
#30 0x08c9adaa in WebCore::SubresourceLoader::didFinishLoading ()
#31 0x0889134e in WebCore::ResourceHandleInternal::OnCompletedRequest ()
#32 0x08f4a28d in ResourceDispatcher::OnRequestComplete ()
#33 0x08f4eadf in ResourceDispatcher::DispatchMessage ()
#34 0x08f4f631 in ResourceDispatcher::OnMessageReceived ()
#35 0x08f2af51 in ChildThread::OnMessageReceived ()
#36 0x08f34dc5 in RunnableMethod<IPC::ChannelProxy::Context, void 
(IPC::ChannelProxy::Context::*)(IPC::Message const&), Tuple1<IPC::Message> >::Run ()
#37 0x083b8c23 in MessageLoop::RunTask ()
#38 0x083b8cf4 in MessageLoop::DeferOrRunPendingTask ()
#39 0x083b8f02 in MessageLoop::DoWork ()
#40 0x083b9d86 in base::MessagePumpDefault::Run ()
#41 0x083b93ae in MessageLoop::RunInternal ()
#42 0x083b9478 in MessageLoop::Run ()
#43 0x083da316 in base::Thread::ThreadMain ()
#44 0x083c4241 in ThreadFunc ()
#45 0xb7b041e0 in start_thread () from /lib/libpthread.so.0
#46 0xb77eed6e in clone () from /lib/libc.so.6

Comment 2 by est...@chromium.org, Jun 01, 2009
thanks for the stack trace
Status: Duplicate
Labels: -Area-Misc Area-BrowserBackend Pri-1
Mergedinto: 12530
Comment 3 by est...@chromium.org, Jun 01, 2009
On second thought, it might not be a dupe, but it's probably related.
Cc: e...@chromium.org
Comment 4 by evan@chromium.org, Jun 01, 2009
Yeah, not a dupe of that one.  I think it might be the same problem as
  http://code.google.com/p/chromium/issues/detail?id=10665

But may as well leave it separate for now.
Status: Available
Labels: -Pri-1 Pri-0
Mergedinto: -12530
Comment 5 by elpraga, Jun 01, 2009
I do not know if this helps or not, but maybe.. The fonts are as far as I know
installed well, so why chromium cannot find them?

tomas@Ubuntu-ElPraga:~$ fc-list |grep Bitstream
Bitstream Vera Sans Mono:style=Bold
Bitstream Vera Sans:style=Oblique
Bitstream Vera Sans:style=Roman
Bitstream Charter:style=Bold Italic
Bitstream Charter:style=Regular
Bitstream Vera Sans Mono:style=Oblique
Bitstream Charter:style=Italic
Bitstream Vera Sans:style=Bold
Bitstream Vera Serif:style=Roman
Bitstream Vera Sans Mono:style=Bold Oblique
Bitstream Vera Sans:style=Bold Oblique
Bitstream Vera Sans Mono:style=Roman
Bitstream Vera Serif:style=Bold
Bitstream Charter:style=Bold
tomas@Ubuntu-ElPraga:~$ 

Comment 6 by dank@chromium.org, Jun 04, 2009
Our #1 crasher on Linux in the first couple hours of the dev channel release looks related:

0x08adfdb1 	[chrome 	- Font.cpp:143] 	WebCore::Font::cachePrimaryFont() const
0x08c898dd 	[chrome 	- Font.h:120] 
WebCore::CSSPrimitiveValue::computeLengthDouble(WebCore::RenderStyle*, double, bool)
0x08c89aa6 	[chrome 	- CSSPrimitiveValue.cpp:367] 
WebCore::CSSPrimitiveValue::computeLengthIntForLength(WebCore::RenderStyle*, double)
0x08cafb8f 	[chrome 	- CSSStyleSelector.cpp:3633] 
WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*)
0x08cb662d 	[chrome 	- CSSStyleSelector.cpp:2787] 
WebCore::CSSStyleSelector::applyDeclarations(bool, bool, int, int) 
...
Comment 7 by jon@chromium.org, Jun 08, 2009
(No comment was entered for this change.)
Labels: Mstone-3
Comment 8 by jon@chromium.org, Jun 09, 2009
(No comment was entered for this change.)
Cc: j...@chromium.org
Comment 9 by thestig@chromium.org, Jun 16, 2009
I couldn't reproduce this one last time I tried. I'll give it another shot.

pdknsk, remind me, are you on a fedora 8 machine with some packages upgraded to
fedora 9? It'll be helpful if I can see your Fontconfig config files. Can you attach
a tarball with your /etc/fonts/ directory?
Comment 10 by pdknsk, Jun 16, 2009
The distribution is a variant of Fedora 8 which is factory installed on the Acer Aspire 
One. I used the instructions posted at http://macles.blogspot.com/2009/05/google-
chrome-chromium-for-linux.html to install Chromium on it.

I do not currently have access to the machine where the bug occurred, but will again in 
2-3 days or so. I'll attach the files then.


Comment 11 by pdknsk, Jun 16, 2009
http://macles.blogspot.com/2009/05/google-chrome-chromium-for-linux.html
Comment 12 by thestig@chromium.org, Jun 16, 2009
Ok, also if you can reproduce it on a standard Fedora install, that would be helpful,
since I don't have an Acer Aspire One and I have no idea what modifications they made
to their version of Fedora 8.
Comment 13 by pdknsk, Jun 16, 2009
The modifications are only to the user interface. Basically it's a simplified and user 
friendly desktop with only a few big icons for the most common applications. And Xfce 
as the window manager. Everything else appears to be standard Fedora.
Comment 14 by evan@chromium.org, Jun 17, 2009
I tried pretty hard to reproduce this (uninstalling a bunch of fonts, turning off 
Gnome's font settings, setting a bad font name in GTK) and wasn't able to crash.

I think my next attempt will be to add more assertions that cause you to crash earlier 
when something goes wrong.
Comment 15 by evan@chromium.org, Jun 17, 2009
Can you do "backtrace full" and paste that?  (It will include more information that may 
be helpful.)
Comment 16 by evan@chromium.org, Jun 17, 2009
Looking through our crash dumps, 100% of the ones I've examined are from people in 
Chinese locales.  Maybe there's a Chinese distro that tickles this one especially bad.
Comment 17 by evan.martin, Jun 17, 2009
http://www.renn999.co.cc/wordpress/archives/291 is a discussion in Chinese of a font-
related workaraound.
Comment 18 by thestig@chromium.org, Jun 18, 2009
We reproduced it locally with Fedora 8. Skia is barfing on
/usr/share/fonts/bitmap-fonts/console9x15.pcf. Is FT_Open_Face in
SkFontHost_FreeType.cpp returning 0 but not setting rec->fFace ? Maybe we need to
tell Freetype to ignore non-TTF fonts?
Comment 19 by thestig@chromium.org, Jun 18, 2009
Err, that wasn't it. Rather, FT_Set_Char_Size() fails, setting fFace to NULL, then we
don't check to see if fFace is NULL in generateFontMetrics(). If we just check for it
and goto ERROR in generateFontMetrics(), it seems to work.

I believe we end up skipping the .pcf file and continue on our merry way, but maybe a
real (free)font expert knows what's going on.
Comment 20 by evan@chromium.org, Jun 18, 2009
(Context for agl: see comments 18/19.)

Maybe we need to tell fontconfig we only want truetype matches out of it?
I don't know what formats freetype accepts.  Another option would be to better handle 
the case where fontconfig's output is rejected by freetype.
Cc: a...@chromium.org
Comment 21 by evan@chromium.org, Jun 18, 2009
It looks like FreeType supports PCF:
http://freetype.sourceforge.net/freetype2/docs/reference/ft2-bdf_fonts.html

I can't say much intelligent about this bug without a backtrace in hand.  Perhaps PCF 
fonts aren't resizable so we shouldn't expect to be able to set their size?  Perhaps 
there's a FontConfig flag so we only use resizable fonts?  Maybe you can print the 
error code?

For what it's worth, you (Lei) know about as much about this as I do now, so if you 
trace the code and find that goto ERROR looks correct, then we should do it.
Status: Assigned
Owner: thes...@chromium.org
Comment 22 by evan@chromium.org, Jun 18, 2009
Removing Mstone-3 since I guess we're using Mstone-LinuxBeta
Labels: -Mstone-3 Mstone-LinuxBeta
Comment 23 by thestig@chromium.org, Jun 18, 2009
Here's a minimal test case: http://leiz.org/chromium/dsi.html

Got a couple patches, either will fix the bug, but we should commit both:
http://codereview.chromium.org/131096
http://codereview.appspot.com/79052
Comment 24 by deanm@chromium.org, Jun 19, 2009
I am doing a Skia roll today anyway, so I will commit your fix to Skia now and roll it 
up at the same time.
Comment 25 by deanm@chromium.org, Jun 19, 2009
Committed the Skia NULL check in Skia r224.  Working on rolling up Chromium to use 
that revision.
Comment 26 by bugdroid1@chromium.org, Jun 19, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=18803 

------------------------------------------------------------------------
r18803 | deanm@chromium.org | 2009-06-19 05:32:54 -0700 (Fri, 19 Jun 2009) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-background-2-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-background-2-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-background-5-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-background-5-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvas-text-alignment-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvas-text-alignment-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/gradient-add-second-start-end-stop-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/gradient-add-second-start-end-stop-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/reflections/reflection-masks-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/reflections/reflection-masks-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/color-prop-01-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/paints/gradientLimit-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/paints/gradientLimit-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/carto.net/colourpicker-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/carto.net/colourpicker-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/deep-dynamic-updates-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/deep-dynamic-updates-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/dominant-baseline-hanging-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/dominant-baseline-hanging-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Discrete-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Discrete-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Gamma-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Gamma-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Linear-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Linear-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Table-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Table-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-deep-referencing-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-deep-referencing-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-rotated-bbox-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-rotated-bbox-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-stop-corner-cases-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-stop-corner-cases-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-stroke-width-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-stroke-width-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/grayscale-gradient-mask-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/grayscale-gradient-mask-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/group-opacity-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/group-opacity-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/inline-svg-in-xhtml-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/inline-svg-in-xhtml-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-gradient-and-object-creation-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-gradient-and-object-creation-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-gradient-creation-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-gradient-creation-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-update-gradient-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-update-gradient-expected.png?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-update-stop-expected.checksum?r1=18803&r2=18802
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-update-stop-expected.png?r1=18803&r2=18802

Roll Skia up to r224, for a few bug fixes.

Most importantly this fixes a spline drawing error and a possible
Linux crash when failing to load a font.  The rebaselines are mostly due
to minor gradient changes (Skia changes r212 and r213).  There was
one layout test that was hitting the spline drawing bug, and the
results now look correct (svg-as-background-5.html).

BUG=13007,14536

Review URL: http://codereview.chromium.org/131105

------------------------------------------------------------------------

Comment 29 by pdknsk, Jun 19, 2009
Just want to confirm that the changes made in r18803 fix the bug.

Comment 30 by evan@chromium.org, Jun 19, 2009
Great work, Lei!
Status: Verified
Comment 31 by bugdroid1@chromium.org, Jun 19, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=18832 

------------------------------------------------------------------------
r18832 | thestig@chromium.org | 2009-06-19 11:16:04 -0700 (Fri, 19 Jun 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/skia/ext/SkFontHost_fontconfig_direct.cpp?r1=18832&r2=18831

Only select scalable fonts. Fixed-size fonts don't work with FT_Set_Char_Size in SkFontHost_FreeType.cpp.

BUG=13007
TEST=On Linux, visit url with { font-family: fixed; } on a computer with pcf fonts.
Review URL: http://codereview.chromium.org/131096
------------------------------------------------------------------------

Comment 32 by thestig@chromium.org, Jun 23, 2009
 Issue 14754  has been merged into this issue.
Comment 33 by dhw@chromium.org, Jul 07, 2009
 Issue 16079  has been merged into this issue.
Comment 34 by mal.chromium, Dec 18, 2009
(No comment was entered for this change.)
Labels: -Area-BrowserBackend Area-Internals
Sign in to add a comment

Powered by Google Project Hosting