My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 12305: 1.66:1 should be UNKNOWN, not URL
3 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Aug 2010
Cc:  pkasting@chromium.org

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by pkasting@chromium.org, May 19, 2009
...just like "1.66" is.
May 26, 2009
#1 lafo...@chromium.org
(No comment was entered for this change.)
Status: Available
Owner: ---
Cc: pkast...@chromium.org
Labels: Mstone-X
Dec 18, 2009
#2 or...@chromium.org
Area-UI-Features label replaces Area-BrowserUI label
Labels: -Area-BrowserUI Area-UI-Features
Jan 28, 2010
#3 jor...@chromium.org
(No comment was entered for this change.)
Labels: HelpWanted
Feb 17, 2010
#4 lafo...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI-Features Area-UI
Feb 24, 2010
#5 maruel@chromium.org
(No comment was entered for this change.)
Labels: GoodFirstBug
Aug 3, 2010
#6 atwilson@chromium.org
rickcam is going to take a shot at this. Assigning it to myself to mark it as in-progress.
Status: Started
Owner: atwil...@chromium.org
Cc: rick...@google.com
Aug 3, 2010
#7 isher...@google.com
I'm actually working on this already -- WIP patch at http://codereview.chromium.org/2868085/show

Apologies for not having commented here earlier to that effect.
Aug 3, 2010
#8 atwilson@chromium.org
OK, un-assigning this. Thanks for the heads up!
Owner: ---
Cc: -rick...@google.com
Aug 4, 2010
#9 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54977 

------------------------------------------------------------------------
r54977 | erg@google.com | 2010-08-04 15:12:50 -0700 (Wed, 04 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete.cc?r1=54977&r2=54976
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_unittest.cc?r1=54977&r2=54976

Fixes  bug 12305  -- 1.66:1 should be UNKNOWN, not URL.

Rearranges the autocomplete heuristics to reject malformed IP addresses before accepting them based on having a port or a username or a password.

BUG=12305
TEST=AutocompleteTest.InputType

Review URL: http://codereview.chromium.org/2868085
Patch from Ilya Sherman <isherman@google.com>.
------------------------------------------------------------------------

Aug 4, 2010
#10 pkasting@chromium.org
Fixed in r54977.
Status: Fixed
Mar 18, 2011
#11 lafo...@chromium.org
...just like &quot;1.66&quot; is.
Labels: -GoodFirstBug bulkmove Hotlist-GoodFirstBug
Oct 12, 2012
#12 bugdroid1@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#13 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI Cr-UI
Sign in to add a comment

Powered by Google Project Hosting