My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 122593: Expose battery status API
49 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by sadrul@chromium.org, Apr 8, 2012
This is to keep track of adding battery status API support in chrome for ChromeOS.
Apr 8, 2012
#1 bugdro...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=83284
Labels: -WebKit-ID-83284 WebKit-ID-83284-NEW
Apr 9, 2012
#2 bugdro...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=83284
http://trac.webkit.org/changeset/113613
Labels: -WebKit-ID-83284-NEW WebKit-ID-83284-RESOLVED WebKit-Rev-113613
Apr 9, 2012
#3 bugdro...@chromium.org
http://trac.webkit.org/changeset/113635
Labels: WebKit-Rev-113635
Apr 9, 2012
#4 bugdro...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=83284
Labels: -WebKit-ID-83284-RESOLVED WebKit-ID-83284-REOPENED
Apr 9, 2012
#5 kliegs@google.com
(No comment was entered for this change.)
Cc: arsc...@chromium.org sna...@chromium.org
Apr 10, 2012
#6 bugdro...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=83284
http://trac.webkit.org/changeset/113734
Labels: -WebKit-ID-83284-REOPENED WebKit-ID-83284-RESOLVED WebKit-Rev-113734
Apr 10, 2012
#7 bugdro...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=83284
http://trac.webkit.org/changeset/113755
Labels: -WebKit-ID-83284-RESOLVED WebKit-ID-83284-REOPENED WebKit-Rev-113755
Apr 11, 2012
#8 bugdro...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=83284
http://trac.webkit.org/changeset/113845
Labels: -WebKit-ID-83284-REOPENED WebKit-ID-83284-RESOLVED WebKit-Rev-113845
Apr 27, 2012
#9 rby...@chromium.org
Darin had some concerns with the current implementation, Sadrul is going to disable it and come back to it later (it's not urgent for M20).
Status: Assigned
Labels: -Mstone-20 Mstone-21
Jun 7, 2012
#10 sadrul@chromium.org
I am afraid this is going to move to M22.
Labels: -Pri-2 -Mstone-21 Pri-1 Mstone-22
Jun 7, 2012
#11 rby...@chromium.org
That's fine, I don't think anyone is arguing that it's Pri-1.  If there's a significant amount of work left we should probably re-open the cost/benefit debate.  

If I recall the benefit was debatable - I just said that if the cost was as low as it appeared we should probably just wire it up.
Labels: -Pri-1 Pri-2
Jul 4, 2012
#13 sadrul@chromium.org
(No comment was entered for this change.)
Labels: WebKit-ID-90538
Jul 4, 2012
#14 sadrul@chromium.org
(No comment was entered for this change.)
Blocking: chromium:135863
Jul 9, 2012
#15 bugdro...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=90538
Labels: -WebKit-ID-90538 WebKit-ID-90538-NEW
Aug 7, 2012
#16 sadrul@chromium.org
(No comment was entered for this change.)
Labels: -Mstone-22 Mstone-23
Aug 23, 2012
#17 sadrul@chromium.org
(No comment was entered for this change.)
Status: Assigned
Sep 11, 2012
#18 sadrul@chromium.org
(No comment was entered for this change.)
Labels: -Mstone-23 Mstone-24
Oct 24, 2012
#19 rby...@chromium.org
Sadrul, do you still want to do this at some point?  Or should we just call it WontFix / Available?
Labels: -Mstone-24 Mstone-25
Oct 24, 2012
#20 sadrul@chromium.org
I will try to get to it for M25 (the parent bug (135863) was P3, so I haven't been looking at this). If I don't get to it in the first M25 iteration, I will mark this Available.
Nov 2, 2012
#21 migu...@chromium.org
Sadrul, I am now looking to implement this feature in android as well (https://code.google.com/p/chromium/issues/detail?id=135863)

I was looking through the CLs on this and noticed http://codereview.chromium.org/10024013/ which implements pretty much everything for chromeos right? However it seems the cl never landed (at least I cannot find any trace of it in head). Do you plan to actually submit it? or is it blocked on something? Once that's in it should be much easier for me to hook it up on android too.
Nov 2, 2012
#22 migu...@chromium.org
(No comment was entered for this change.)
Cc: migu...@chromium.org
Nov 5, 2012
#24 rby...@chromium.org
(No comment was entered for this change.)
Labels: Iteration-68
Nov 12, 2012
#25 rby...@chromium.org
(No comment was entered for this change.)
Labels: Iteration-69
Nov 20, 2012
#26 kar...@google.com
Bugs that have been moved 5 or more times. Removing Mstone label.
Labels: -Mstone-25 MstoneRemoved
Nov 26, 2012
#27 rby...@chromium.org
There is active progress on the webkit side here.
Status: Started
Labels: -MstoneRemoved MStone-26 Iteration-70
Dec 10, 2012
#28 rby...@chromium.org
(No comment was entered for this change.)
Labels: Iteration-71
Jan 7, 2013
#29 rby...@chromium.org
Started -> Iteration-73
Labels: Iteration-73
Jan 17, 2013
#30 sadrul@chromium.org
(No comment was entered for this change.)
Status: Available
Feb 4, 2013
#31 sadrul@chromium.org
(No comment was entered for this change.)
Labels: -MStone-26 Mstone-27
Feb 15, 2013
#32 rby...@chromium.org
(No comment was entered for this change.)
Owner: ---
Feb 15, 2013
#33 rby...@chromium.org
beverloo@ - here's the nearly complete CL Sadrul had for battery status API.  Sadrul says he's going to try again to get this landed.
Status: Assigned
Owner: sadrul@chromium.org
Cc: peter@chromium.org
Mar 6, 2013
#34 rby...@chromium.org
Sadrul, any update?  Would you like me to find someone else for this?
Cc: rharrison@chromium.org
Mar 7, 2013
#35 peter@chromium.org
Has the API been reviewed and are we satisfied with it?  I'm a little bit wary about the {dis,}chargingtimechange events not being completely defined: do they fire with the granularity of the properties they represent (i.e. every second) or when there is an update from the platform about a change in the battery level?

On Android, this will require a new permission (+vinodkr) as well.
Cc: vino...@chromium.org
Mar 10, 2013
#36 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-WebKit -Mstone-27 Cr-Content M-27
Mar 25, 2013
#37 sadrul@chromium.org
(No comment was entered for this change.)
Labels: -M-27 M-28
Apr 5, 2013
#38 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content Cr-Blink
May 8, 2013
#39 sadrul@chromium.org
(No comment was entered for this change.)
Labels: -M-28 M-29
May 20, 2013
#40 bugdro...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=90538

Labels: -WebKit-ID-90538-NEW WebKit-ID-90538-RESOLVED
Jun 6, 2013
#41 adamk@chromium.org
What's the status of this work? The battery status is still #ifdef'd out in Blink, but we're trying to move away from #ifdefs for features, instead preferring runtime flags. 

If this feature will be worked on moving forward a first step would be to switch it to using a runtime flag so as to get the code compiled/exercised (though the layout tests don't pass at the moment).
Cc: adamk@chromium.org
Jun 6, 2013
#42 rby...@chromium.org
Peter says they have concerns about this API for Chrome Android.  We definitely shouldn't add it to some platforms and not others, and mobile is probably the most compelling use case.  Assigning to Peter to drive a decision on this API - if we're not going to implement it any time soon then we should probably remove the code (for now anyway, can always bring it back).
Owner: peter@chromium.org
Jun 6, 2013
#43 rby...@chromium.org
(No comment was entered for this change.)
Summary: Expose battery status API? (was: chromeos: Expose battery status API)
Labels: OS-Android
Jun 6, 2013
#44 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=151954

------------------------------------------------------------------------
r151954 | adamk@chromium.org | 2013-06-06T18:26:43.725358Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=151954&r2=151953&pathrev=151954

Skip batterystatus tests as Blink/Chromium does not yet support the API

BUG=122593
TBR=ojan
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16544003
------------------------------------------------------------------------
Jun 6, 2013
#45 peter@chromium.org
Let's remove the existing implementation.

We indeed have concerns about whether people will actually be using the API for anything other than demonstration pages.  Furthermore, the current implementation is rather small and self contained, we can always bring parts of it back when the time is there.  Based on my discussions with Rick I don't think it's a big priority for Chrome OS either -- I think we should revisit the API later.

Adam, do you want to remove it?  Otherwise I can ask Michael to take a look, who owns it per the spreadsheet.
Cc: mvanouwerkerk@chromium.org
Jun 6, 2013
#46 adamk@chromium.org
Thanks for the quick response! I'll remove the code, putting together a CL now.
Jun 7, 2013
#47 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152030

------------------------------------------------------------------------
r152030 | adamk@chromium.org | 2013-06-07T15:48:50.976273Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/src/WebViewImpl.cpp?r1=152030&r2=152029&pathrev=152030
   D http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/src/BatteryClientImpl.cpp?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/Internals.idl?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/features.gypi?r1=152030&r2=152029&pathrev=152030
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/batterystatus?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/src/WebViewImpl.h?r1=152030&r2=152029&pathrev=152030
   D http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/src/BatteryClientImpl.h?r1=152030&r2=152029&pathrev=152030
   D http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/DEPS?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/public/webpage/WebViewClient.h?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/Internals.cpp?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/public/webpage/WebView.h?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=152030&r2=152029&pathrev=152030
   D http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/public/WebBatteryStatusClient.h?r1=152030&r2=152029&pathrev=152030
   D http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/public/WebBatteryStatus.h?r1=152030&r2=152029&pathrev=152030
   D http://src.chromium.org/viewvc/blink/trunk/public/webpage/WebBatteryStatusClient.h?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/Internals.h?r1=152030&r2=152029&pathrev=152030
   D http://src.chromium.org/viewvc/blink/trunk/public/webpage/WebBatteryStatus.h?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/WebKit.gyp?r1=152030&r2=152029&pathrev=152030
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventTargetFactory.in?r1=152030&r2=152029&pathrev=152030

Remove Battery Status API support code from Blink

The code was already disabled by a compile-time flag. Given that there
are concerns about the API, and that there's no current plan to enable
the code, delete it for now.

See attached bug for more discussion.

R=abarth@chromium.org
BUG=122593

Review URL: https://codereview.chromium.org/16298005
------------------------------------------------------------------------
Jun 13, 2013
#48 srika...@chromium.org
From the looks of it, this is not landing in M29. Putting it back on the hopper pending a revised plan. 
Labels: -M-29 M-X
Jul 12, 2013
#49 raphael.kubo.da.costa@intel.com
Hi everyone,

I am interested in picking up the work, but it would be nice to get some clarifications about the plans for implementing this spec, if at all.

Looking at the previous comments, I see mixed signals from the ChromeOS and Android teams with the priority of this bug changing over time.

Anssi Kostiainen, one of the spec's editors, sits right next to me, so it is easy to address concerns about the API itself (such as the one in comment #35).

Jul 12, 2013
#50 peter@chromium.org
+Tony, who expressed interest as well.

My primary concern lies in the use-cases for the API.  Web Developers caring about how quickly the battery discharges sounds like an ideology to me, and I wonder how many developers will actually be doing so.  Michael can emphasize a little further on this point.

As for the specification itself, it's unfortunate that the {charging, chargingTime, dischargingTime, level} attributes require synchronous operation.  The interval at which some of the events should fire, i.e. on(dis)chargingtimechange, also goes undefined.  A little quirk is that the spec says dischargingTime should be Infinite when the device is charging, while I've definitely got devices which, while charging, discharge because of heavy operation :-).

All of that said, it's a nice to have and I'm not *against* this API, I just don't think it's a priority either.  If anyone is interested in finalizing the API and implementing it, then, by all means, please do so! :-)
Cc: tony@chromium.org
Jul 12, 2013
#51 rby...@chromium.org
I agree with Peter - nice to have, but the value of the legitimate use cases will probably be of some debate.  If you want to drive it through chromium, the place to start is probably an intent-to-implement thread on blink-dev (http://www.chromium.org/blink#launch-process).
Jul 12, 2013
#53 tony@chromium.org
I briefly looked into getting sadrul's changes landed, but decided not to do it because of the synchronous calls for getting the attribute values.  It would be much easier to implement by having it take a callback or only having an event listener (with some guidance on how frequently the event listener should fire).

Jul 16, 2013
#54 mvanouwerkerk@chromium.org
Maybe the synchronous attributes can be replaced with promises: http://dom.spec.whatwg.org/#futures

To provide some insight into prioritization: usage of the BATTERY_STATS permission in Android is very low, and actual usage of the BatteryManager class is much less than that.

The use cases described in the Battery Status API spec such as reducing polling frequency in a mail app seem fair, but uncommon. Even when applicable they don't seem critical for the functioning of the application. Still, it would be nice to be able to support these use cases somehow.
Jul 16, 2013
#55 kihong.k...@samsung.com
There are some use cases without email system.

For instance, Online shopping or survey site could use this API.
It's annoying to me, if a tablet is turned off during entering fields to the online research or making document to the google docs.
In this case, service provider can notify to user or store data automatically when battery level is critical.
This is not critical use cases, but it could be useful.
Aug 14, 2013
#56 anssi.ko...@intel.com
Hi Peter,

Thanks for reviewing the spec. I'll address your concerns raised in #35 and #50 below.

Re "{charging, chargingTime, dischargingTime, level} attributes require synchronous operation". The same design is used in other parts of the web platform e.g. readyState & onreadystatechange in XMLHttpRequest and document.readyState & document.onreadystatechange. This provides web developers means to use the API either asynchronously or synchronously. A typical asynchronous usage would be:

navigator.battery.onchargingchange = function () {
  console.log(navigator.battery.charging);
};

Cf.:

xhr.onreadystatechange = function () {
  console.log(xhr.readyState);
};

The group identified good use cases for both async and sync usage; I can dig the archives if deemed helpful.

Re "The interval at which some of the events should fire [...] goes undefined". The group landed on this approach after quite a bit of discussion. The reason for the design is that battery backends differ in terms of frequency they're able to provide the data. Also, it was noted implementations may have legitimate reasons to adjust the interval dynamically (e.g. when the battery is almost full, it may not be so critical to get the dischargingTime updated as often as in the case when you're low on battery and trying to finish a task at hand before the battery runs). So the following note is in the spec for a reason: "The definition of how often the chargingtimechange, dischargingtimechange, and levelchange events are fired is left to the implementation."

Re "the spec says dischargingTime should be Infinite when the device is charging". This is on purpose to make the case of no battery (or no battery attached) analogous to the case of the device having a battery which is charging. IOW, when the BatteryManager object is created, the attributes are initialized to defaults similar to the state when the battery is charging. This design makes is possible to ship this API also on desktop (or other devices with no battery) as the code web developers write against this API will continue to work on desktops with no modifications (e.g. Firefox has shipped this API on Windows and Linux desktop builds since Oct 2012, and on OS X since Jan 2013).

I'm happy to answer any further question you may have, and can provide further pointers to related standards discussions.
Nov 4, 2013
#57 smckay@chromium.org
FYI, I recently encountered an issue with a Chrome packaged app where access to system power information, like battery charge level, would have been helpful in avoiding data corruption.

Specifics:

My device powered off while the app was performing synchronized DB and file-IO operations (copying files to local storage from a media gallery AND performing a corresponding DB write). This resulted in data corruption.

Access to such an API would allow us to limit the behavior of the app to avoid data corruption in lower power situations. Similarly we would probably want to forgo CPU intensive operations at these times (e.g. NACL based image resizing).

Granted this case is specific to a Chrome packaged app, but I can imagine a similar scenario could be cooked up with using vanilla web-tech.

Cc: vandebo@chromium.org
Nov 4, 2013
#58 vandebo@chromium.org
(No comment was entered for this change.)
Cc: -vandebo@chromium.org
Nov 4, 2013
#59 mvanouwerkerk@chromium.org
I think the Battery Status API is both too much and too little for running cleanup tasks on imminent shutdown. A page can be killed for a number of reasons. Perhaps the concepts expressed in the Application Lifecycle and Events specification [1] can provide a more general and complete solution for this type of problem. Specifically the terminate event seems relevant.

[1] http://www.w3.org/2012/sysapps/app-lifecycle/
Nov 7, 2013
#60 smckay@chromium.org
(No comment was entered for this change.)
Cc: smckay@chromium.org
Dec 3, 2013
#61 peter@chromium.org
 Issue 135863  has been merged into this issue.
Cc: jknot...@chromium.org klundberg@chromium.org fra...@chromium.org
Dec 3, 2013
#62 starbeam...@gmail.com
The battery status API could also be used by an application to tell whether a user is currently on battery power and put some energy saving measures in place if so

Jan 10, 2014
#63 tonyg@chromium.org
(No comment was entered for this change.)
Labels: Performance-Battery Cr-Blink-Performance-APIs
Jan 10, 2014
#64 tonyg@chromium.org
 Issue 118481  has been merged into this issue.
Cc: wiltz...@chromium.org
Jan 27, 2014
#65 rsch...@chromium.org
(No comment was entered for this change.)
Labels: Performance-Power
Feb 25, 2014
#66 mlamo...@chromium.org
(No comment was entered for this change.)
Cc: mlamo...@chromium.org
Mar 6, 2014
#67 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168632

------------------------------------------------------------------------
r168632 | srinivasa.ragavan.venkateswaran@intel.com | 2014-03-06T12:58:16.230352Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/NavigatorBattery.idl?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryStatus.cpp?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/events/EventTargetFactory.in?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/resources/window-property-collector.js?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/test-battery-status-basic.html?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryStatus.h?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/NavigatorBattery.cpp?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/NavigatorBattery.h?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.idl?r1=168632&r2=168631&pathrev=168632
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/test-battery-status-basic-expected.txt?r1=168632&r2=168631&pathrev=168632
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=168632&r2=168631&pathrev=168632

Add support to Battery Status API in blink.

This patch adds basic Battery Manager to Navigator with default battery
status values and the test enables to test if those values are passed
correctly.

Intent-to-Implement link: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/fzoG6Phr09k/dnAEzkgMA1YJ

BUG=122593

Review URL: https://codereview.chromium.org/182613002
------------------------------------------------------------------------
Mar 6, 2014
#69 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168665

------------------------------------------------------------------------
r168665 | srinivasa.ragavan.venkateswaran@intel.com | 2014-03-06T19:32:50.625365Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=168665&r2=168664&pathrev=168665
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/NavigatorBattery.h?r1=168665&r2=168664&pathrev=168665

Simplify BatteryManager class and cleanups.

R=Chris Dumez, abarth
BUG=122593

Review URL: https://codereview.chromium.org/180243023
------------------------------------------------------------------------
Mar 8, 2014
#70 starbeam...@gmail.com
Will this now be available in canary?

I tried 35.0.1878.0 (Official Build 255693) canary with blink 537.36
(@168699), but navigator.battery was undefined.
Mar 18, 2014
#71 mlamo...@chromium.org
(No comment was entered for this change.)
Owner: ---
Blockedon: chromium:353337
Mar 28, 2014
#72 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=170338

------------------------------------------------------------------
r170338 | mlamouri@chromium.org | 2014-03-28T16:17:38.913106Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt?r1=170338&r2=170337&pathrev=170338
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt?r1=170338&r2=170337&pathrev=170338
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt?r1=170338&r2=170337&pathrev=170338
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=170338&r2=170337&pathrev=170338
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt?r1=170338&r2=170337&pathrev=170338
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/test-battery-status-basic-expected.txt?r1=170338&r2=170337&pathrev=170338

BatteryStatus: fix chargingTime() to follow the specification.

If the battery status is unknown, the charging time should be
0 instead of Infinity. The reason being that in that case, the
battery status is reflected as a plugged and fully charged battery.

BUG=122593

Review URL: https://codereview.chromium.org/203693003
-----------------------------------------------------------------
Apr 21, 2014
#73 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=172021

------------------------------------------------------------------
r172021 | srinivasa.ragavan.venkateswaran@intel.com | 2014-04-21T08:23:38.148146Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=172021&r2=172020&pathrev=172021
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.h?r1=172021&r2=172020&pathrev=172021
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=172021&r2=172020&pathrev=172021
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryStatus.cpp?r1=172021&r2=172020&pathrev=172021
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.cpp?r1=172021&r2=172020&pathrev=172021
   A http://src.chromium.org/viewvc/blink/trunk/public/platform/WebBatteryStatus.h?r1=172021&r2=172020&pathrev=172021
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryStatus.h?r1=172021&r2=172020&pathrev=172021
   A http://src.chromium.org/viewvc/blink/trunk/public/platform/WebBatteryListener.h?r1=172021&r2=172020&pathrev=172021
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=172021&r2=172020&pathrev=172021

Add Dispatcher class to the Battery Status API module.

BUG=122593

Review URL: https://codereview.chromium.org/212643010
-----------------------------------------------------------------
Apr 24, 2014
#75 arsc...@chromium.org
(No comment was entered for this change.)
Cc: -arsc...@chromium.org
Apr 29, 2014
#76 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=172927

------------------------------------------------------------------
r172927 | timvolodine@chromium.org | 2014-04-30T04:40:53.511484Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/WATCHLISTS?r1=172927&r2=172926&pathrev=172927

Add battery_status to WATCHLISTS.

Add a watchlist for the Battery Status API blink module,
aka modules/battery.

BUG=122593

Review URL: https://codereview.chromium.org/253733007
-----------------------------------------------------------------
Apr 30, 2014
#77 timvolod...@chromium.org
(No comment was entered for this change.)
Status: Started
Owner: timvolod...@chromium.org
Apr 30, 2014
#78 timvolod...@chromium.org
(No comment was entered for this change.)
Blockedon: chromium:360068
May 1, 2014
#79 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=173079

------------------------------------------------------------------
r173079 | mlamouri@chromium.org | 2014-05-01T11:18:57.961260Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.idl?r1=173079&r2=173078&pathrev=173079

BatteryStatus: use 'unrestricted double' instead of 'double'

Even though it seems to be the same as far as our WebIDL
parser is concerned, it might be better to keep the IDL as
close to the specification as we can.

BUG=122593
TBR=haraken

Review URL: https://codereview.chromium.org/203683002
-----------------------------------------------------------------
May 7, 2014
#80 d...@burnside.school.nz
I'm keen on this being implemented in Chrome for the following reason; I've set up a Windows 8.1 build for our campus netbooks that uses Assigned User to autologin & launch Chrome whenever the netbook turns on. The only thing we've noticed missing from the ChromeOS-like interface is a battery level gauge, and when this API is implemented I can just set Chrome to open a tab to an html/java battery monitor page similar to www.smartjava.org/examples/webapi-battery/ .
May 13, 2014
#81 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eead0e3c4b0ad698062f878076233c06fc73aed

commit 6eead0e3c4b0ad698062f878076233c06fc73aed
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 13 16:41:49 2014

Battery Status API: add plumbing for multi-platform support.

Make the battery_status_manager generic for all platforms.
Currently there is an implementation only for the android
platform.

BUG=122593,360068

Review URL: https://codereview.chromium.org/267893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270124 0039d316-1c4b-4281-b951-d872f2087c98


May 13, 2014
#82 bugdro...@chromium.org
------------------------------------------------------------------
r270124 | timvolodine@chromium.org | 2014-05-13T16:41:49.176587Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_default.cc?r1=270124&r2=270123&pathrev=270124
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_update_callback.h?r1=270124&r2=270123&pathrev=270124
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=270124&r2=270123&pathrev=270124
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java?r1=270124&r2=270123&pathrev=270124
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_android.cc?r1=270124&r2=270123&pathrev=270124
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/android/browser_jni_registrar.cc?r1=270124&r2=270123&pathrev=270124
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager.h?r1=270124&r2=270123&pathrev=270124
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_android.h?r1=270124&r2=270123&pathrev=270124
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/DEPS?r1=270124&r2=270123&pathrev=270124

Battery Status API: add plumbing for multi-platform support.

Make the battery_status_manager generic for all platforms.
Currently there is an implementation only for the android
platform.

BUG=122593,360068

Review URL: https://codereview.chromium.org/267893003
-----------------------------------------------------------------
May 14, 2014
#83 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5981d401eebc28c84a14fa94c66120559949c9eb

commit 5981d401eebc28c84a14fa94c66120559949c9eb
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed May 14 23:40:59 2014

Add Battery Status API support in content/renderer and IPC messages.

This patch defines the async IPCs needed for the Battery Status API.
It also implements the platform-side part with a
setBatteryStatusListener() method and a dispatcher class for
propagating messages to blink. Unit tests for the dispatcher
class are also included.

BUG=122593,360068

Review URL: https://codereview.chromium.org/252113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270504 0039d316-1c4b-4281-b951-d872f2087c98


May 14, 2014
#84 bugdro...@chromium.org
------------------------------------------------------------------
r270504 | timvolodine@chromium.org | 2014-05-14T23:40:59.203556Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/battery_status/battery_status_dispatcher.cc?r1=270504&r2=270503&pathrev=270504
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.h?r1=270504&r2=270503&pathrev=270504
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/battery_status/battery_status_dispatcher.h?r1=270504&r2=270503&pathrev=270504
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/battery_status/OWNERS?r1=270504&r2=270503&pathrev=270504
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/common/battery_status_messages.h?r1=270504&r2=270503&pathrev=270504
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/content_message_generator.h?r1=270504&r2=270503&pathrev=270504
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/DEPS?r1=270504&r2=270503&pathrev=270504
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=270504&r2=270503&pathrev=270504
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/battery_status?r1=270504&r2=270503&pathrev=270504
   M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_message_start.h?r1=270504&r2=270503&pathrev=270504
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=270504&r2=270503&pathrev=270504
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc?r1=270504&r2=270503&pathrev=270504
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=270504&r2=270503&pathrev=270504
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/battery_status/battery_status_dispatcher_unittest.cc?r1=270504&r2=270503&pathrev=270504

Add Battery Status API support in content/renderer and IPC messages.

This patch defines the async IPCs needed for the Battery Status API.
It also implements the platform-side part with a
setBatteryStatusListener() method and a dispatcher class for
propagating messages to blink. Unit tests for the dispatcher
class are also included.

BUG=122593,360068

Review URL: https://codereview.chromium.org/252113006
-----------------------------------------------------------------
May 26, 2014
#85 Nevra...@gmail.com
1) navigator.battery.charging returns true even though I am not charging it. 
2) navigator.battery.level returns 1 even though the power is at 95%
3) navigator.battery.dischargingTime return Infinity (this may be correct as I am unplugged but thought I would mention it)
 
Version :  37.0.2014.2 canary
OS: OS X 10.9.2 (13C1021)
Macbook Pro Retina Display 2.4 GHz Intel Core i7 (Early 2013)


Screen Shot 2014-05-26 at 7.50.30 PM.png
316 KB   View   Download
May 27, 2014
#86 timvolod...@chromium.org
@Nevraeka: that is as expected. We are currently in the process of implementing this feature, so at the moment you only get default values for those attributes.
May 27, 2014
#87 Nevra...@gmail.com
Very good then. My apologizes. Thank you for the update.
May 28, 2014
#88 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51e2e88be0d17283a6c6b4ebba6c12843201b69d

commit 51e2e88be0d17283a6c6b4ebba6c12843201b69d
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed May 28 20:07:47 2014

Battery Status API: browser-side implementation.

This patch implements the browser side bits needed for the
Battery Status API. It includes a message filter, a singleton
service which owns and controls the platform-specific battery
status manager. Updates are implemented using callbacks and
async IPCs between the browser and the renderer.

A unit test for the service using a fake battery status manager
and callbacks is also provided.

Corresponding renderer-side patch:
https://codereview.chromium.org/252113006/

BUG=122593, 360068

Review URL: https://codereview.chromium.org/278043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273336 0039d316-1c4b-4281-b951-d872f2087c98


May 28, 2014
#89 bugdro...@chromium.org
------------------------------------------------------------------
r273336 | timvolodine@chromium.org | 2014-05-28T20:07:47.838830Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_message_filter.cc?r1=273336&r2=273335&pathrev=273336
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_android.cc?r1=273336&r2=273335&pathrev=273336
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_message_filter.h?r1=273336&r2=273335&pathrev=273336
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager.h?r1=273336&r2=273335&pathrev=273336
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_default.cc?r1=273336&r2=273335&pathrev=273336
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_service_unittest.cc?r1=273336&r2=273335&pathrev=273336
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_service.cc?r1=273336&r2=273335&pathrev=273336
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_update_callback.h?r1=273336&r2=273335&pathrev=273336
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_service.h?r1=273336&r2=273335&pathrev=273336
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=273336&r2=273335&pathrev=273336
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=273336&r2=273335&pathrev=273336
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=273336&r2=273335&pathrev=273336
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_main_loop.cc?r1=273336&r2=273335&pathrev=273336

Battery Status API: browser-side implementation.

This patch implements the browser side bits needed for the
Battery Status API. It includes a message filter, a singleton
service which owns and controls the platform-specific battery
status manager. Updates are implemented using callbacks and
async IPCs between the browser and the renderer.

A unit test for the service using a fake battery status manager
and callbacks is also provided.

Corresponding renderer-side patch:
https://codereview.chromium.org/252113006/

BUG=122593, 360068

Review URL: https://codereview.chromium.org/278043002
-----------------------------------------------------------------
Jun 3, 2014
#90 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de7c9e700105e4a395897643a5c836c3b451c295

commit de7c9e700105e4a395897643a5c836c3b451c295
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 22:30:26 2014

Battery Status API: add testing support for LayoutTests.

Adds plumbing to make it possible to test the blink
implementation of the Battery Status API using LayoutTests and
TestRunner. In test mode a fake battery status dispatcher is
used to allow manual triggering of battery status changes using
TestRunner.didChangeBatteryStatus method.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/298263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274652 0039d316-1c4b-4281-b951-d872f2087c98


Jun 3, 2014
#91 bugdro...@chromium.org
------------------------------------------------------------------
r274652 | timvolodine@chromium.org | 2014-06-03T22:30:26.803679Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/renderer_webkitplatformsupport_impl.h?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/layouttest_support.h?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/layouttest_support.cc?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/renderer/webkit_test_runner.cc?r1=274652&r2=274651&pathrev=274652
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/battery_status/fake_battery_status_dispatcher.cc?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/renderer/webkit_test_runner.h?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/renderer/test_runner/test_runner.cc?r1=274652&r2=274651&pathrev=274652
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/battery_status/fake_battery_status_dispatcher.h?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/renderer/test_runner/WebTestDelegate.h?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/renderer/test_runner/test_runner.h?r1=274652&r2=274651&pathrev=274652
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=274652&r2=274651&pathrev=274652

Battery Status API: add testing support for LayoutTests.

Adds plumbing to make it possible to test the blink
implementation of the Battery Status API using LayoutTests and
TestRunner. In test mode a fake battery status dispatcher is
used to allow manual triggering of battery status changes using
TestRunner.didChangeBatteryStatus method.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/298263002
-----------------------------------------------------------------
Jun 5, 2014
#92 bugdro...@chromium.org
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/de7c9e700105e4a395897643a5c836c3b451c295

commit de7c9e700105e4a395897643a5c836c3b451c295
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 22:30:26 2014

Jun 5, 2014
#93 migu...@chromium.org
(No comment was entered for this change.)
Summary: Expose battery status API (was: Expose battery status API?)
Jun 6, 2014
#94 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=175661

------------------------------------------------------------------
r175661 | timvolodine@chromium.org | 2014-06-06T12:32:48.054513Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.cpp?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.cpp?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.cpp?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.cpp?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.h?r1=175661&r2=175660&pathrev=175661
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.cpp?r1=175661&r2=175660&pathrev=175661
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.cpp?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.h?r1=175661&r2=175660&pathrev=175661
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.cpp?r1=175661&r2=175660&pathrev=175661
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=175661&r2=175660&pathrev=175661
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.cpp?r1=175661&r2=175660&pathrev=175661
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=175661&r2=175660&pathrev=175661
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.cpp?r1=175661&r2=175660&pathrev=175661

Generalize and refactor DeviceSensorEvent* architecture to support
multi-event type targets.

This patch performs a significant refactoring of the
DeviceSensorEvent{Controller,Dispatcher} and related classes.
It provides new Base classes to allow simple implementation of
APIs involving multi-event type non-window targets (e.g. Battery
Status API). Additionally it makes the implementation of existing
event-based APIs (device_orientation, device_light) simpler and
more compact.

In particular the following new classes have been added:
* DeviceEventControllerBase and DeviceEventDispatcherBase
(derived from by the Battery Status API).
* DeviceSingleWindowEventController is more specific and
contains functionality necessary for single-event type window
target APIs (used by Device Motion/Orientation and Device Light
APIs).

BUG=122593, 360068
NOTRY=true

Review URL: https://codereview.chromium.org/315573002
-----------------------------------------------------------------
Jun 6, 2014
#95 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=175673

------------------------------------------------------------------
r175673 | dcheng@chromium.org | 2014-06-06T16:27:20.899697Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.h?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.h?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.h?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.cpp?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.cpp?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.h?r1=175673&r2=175672&pathrev=175673
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.cpp?r1=175673&r2=175672&pathrev=175673
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.cpp?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.h?r1=175673&r2=175672&pathrev=175673
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.cpp?r1=175673&r2=175672&pathrev=175673
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.h?r1=175673&r2=175672&pathrev=175673
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.h?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.cpp?r1=175673&r2=175672&pathrev=175673
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.h?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.cpp?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.h?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.cpp?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.h?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.cpp?r1=175673&r2=175672&pathrev=175673
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp?r1=175673&r2=175672&pathrev=175673

Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (https://codereview.chromium.org/315573002/)

Reason for revert:
Triggers assert in 
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html

Original issue's description:
> Generalize and refactor DeviceSensorEvent* architecture to support
> multi-event type targets.
> 
> This patch performs a significant refactoring of the
> DeviceSensorEvent{Controller,Dispatcher} and related classes.
> It provides new Base classes to allow simple implementation of
> APIs involving multi-event type non-window targets (e.g. Battery
> Status API). Additionally it makes the implementation of existing
> event-based APIs (device_orientation, device_light) simpler and
> more compact.
> 
> In particular the following new classes have been added:
> * DeviceEventControllerBase and DeviceEventDispatcherBase
> (derived from by the Battery Status API).
> * DeviceSingleWindowEventController is more specific and
> contains functionality necessary for single-event type window
> target APIs (used by Device Motion/Orientation and Device Light
> APIs).
> 
> BUG=122593, 360068
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661

TBR=ch.dumez@samsung.com,abarth@chromium.org,jochen@chromium.org,tkent@chromium.org,timvolodine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=122593, 360068

Review URL: https://codereview.chromium.org/315023006
-----------------------------------------------------------------
Jun 6, 2014
#96 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=175686

------------------------------------------------------------------
r175686 | timvolodine@chromium.org | 2014-06-06T18:31:15.898771Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.cpp?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.h?r1=175686&r2=175685&pathrev=175686
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.cpp?r1=175686&r2=175685&pathrev=175686
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=175686&r2=175685&pathrev=175686
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.cpp?r1=175686&r2=175685&pathrev=175686
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.cpp?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.cpp?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.cpp?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.h?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.cpp?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.cpp?r1=175686&r2=175685&pathrev=175686
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.h?r1=175686&r2=175685&pathrev=175686
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.cpp?r1=175686&r2=175685&pathrev=175686

Generalize and refactor DeviceSensorEvent* architecture to support
multi-event type targets.

This patch performs a significant refactoring of the
DeviceSensorEvent{Controller,Dispatcher} and related classes.
It provides new Base classes to allow simple implementation of
APIs involving multi-event type non-window targets (e.g. Battery
Status API). Additionally it makes the implementation of existing
event-based APIs (device_orientation, device_light) simpler and
more compact.

In particular the following new classes have been added:
* DeviceEventControllerBase and DeviceEventDispatcherBase
(derived from by the Battery Status API).
* DeviceSingleWindowEventController is more specific and
contains functionality necessary for single-event type window
target APIs (used by Device Motion/Orientation and Device Light
APIs).

BUG=122593, 360068

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661

Review URL: https://codereview.chromium.org/315573002
-----------------------------------------------------------------
Jun 7, 2014
#97 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=175740

------------------------------------------------------------------
r175740 | dcheng@chromium.org | 2014-06-07T08:00:25.292888Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.cpp?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.h?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.cpp?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.h?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.h?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.h?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.cpp?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.cpp?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.h?r1=175740&r2=175739&pathrev=175740
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.cpp?r1=175740&r2=175739&pathrev=175740
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.cpp?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.h?r1=175740&r2=175739&pathrev=175740
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.cpp?r1=175740&r2=175739&pathrev=175740
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.h?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=175740&r2=175739&pathrev=175740
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.h?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.cpp?r1=175740&r2=175739&pathrev=175740
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.h?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.cpp?r1=175740&r2=175739&pathrev=175740
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.h?r1=175740&r2=175739&pathrev=175740

Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (https://codereview.chromium.org/315573002/)

Reason for revert:
ASAN bots are broken with this patch.

Original issue's description:
> Generalize and refactor DeviceSensorEvent* architecture to support
> multi-event type targets.
> 
> This patch performs a significant refactoring of the
> DeviceSensorEvent{Controller,Dispatcher} and related classes.
> It provides new Base classes to allow simple implementation of
> APIs involving multi-event type non-window targets (e.g. Battery
> Status API). Additionally it makes the implementation of existing
> event-based APIs (device_orientation, device_light) simpler and
> more compact.
> 
> In particular the following new classes have been added:
> * DeviceEventControllerBase and DeviceEventDispatcherBase
> (derived from by the Battery Status API).
> * DeviceSingleWindowEventController is more specific and
> contains functionality necessary for single-event type window
> target APIs (used by Device Motion/Orientation and Device Light
> APIs).
> 
> BUG=122593, 360068
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175686

TBR=ch.dumez@samsung.com,abarth@chromium.org,jochen@chromium.org,tkent@chromium.org,timvolodine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=122593, 360068

Review URL: https://codereview.chromium.org/321653003
-----------------------------------------------------------------
Jun 9, 2014
#98 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=175792

------------------------------------------------------------------
r175792 | timvolodine@chromium.org | 2014-06-09T13:18:23.589806Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.h?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.h?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.cpp?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.cpp?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionController.h?r1=175792&r2=175791&pathrev=175792
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.cpp?r1=175792&r2=175791&pathrev=175792
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.cpp?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceMotionDispatcher.h?r1=175792&r2=175791&pathrev=175792
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.cpp?r1=175792&r2=175791&pathrev=175792
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceSingleWindowEventController.h?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=175792&r2=175791&pathrev=175792
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventControllerBase.h?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.cpp?r1=175792&r2=175791&pathrev=175792
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DeviceEventDispatcherBase.h?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.cpp?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightController.h?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_light/DeviceLightDispatcher.h?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.cpp?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryDispatcher.cpp?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=175792&r2=175791&pathrev=175792
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/device_orientation/DeviceOrientationController.h?r1=175792&r2=175791&pathrev=175792

Generalize and refactor DeviceSensorEvent* architecture to support
multi-event type targets.

This patch performs a significant refactoring of the
DeviceSensorEvent{Controller,Dispatcher} and related classes.
It provides new Base classes to allow simple implementation of
APIs involving multi-event type non-window targets (e.g. Battery
Status API). Additionally it makes the implementation of existing
event-based APIs (device_orientation, device_light) simpler and
more compact.

In particular the following new classes have been added:
* DeviceEventControllerBase and DeviceEventDispatcherBase
(derived from by the Battery Status API).
* DeviceSingleWindowEventController is more specific and
contains functionality necessary for single-event type window
target APIs (used by Device Motion/Orientation and Device Light
APIs).

BUG=122593, 360068

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175686

Review URL: https://codereview.chromium.org/315573002
-----------------------------------------------------------------
Jun 13, 2014
#99 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be81654038824ed1bcdddc6679e8ca0bfde3cb0

commit 6be81654038824ed1bcdddc6679e8ca0bfde3cb0
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 13 17:13:03 2014

Battery Status API: add UMA logging for Android.

Count the usage of the Battery Status API on Android.
Upon each start of Battery Status API we log if the request
to register for battery change updates was successfull or not.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/316863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277041 0039d316-1c4b-4281-b951-d872f2087c98


Jun 13, 2014
#100 bugdro...@chromium.org
------------------------------------------------------------------
r277041 | timvolodine@chromium.org | 2014-06-13T17:13:03.066624Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_android.cc?r1=277041&r2=277040&pathrev=277041
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=277041&r2=277040&pathrev=277041

Battery Status API: add UMA logging for Android.

Count the usage of the Battery Status API on Android.
Upon each start of Battery Status API we log if the request
to register for battery change updates was successfull or not.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/316863004
-----------------------------------------------------------------
Jun 16, 2014
#101 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=176222

------------------------------------------------------------------
r176222 | timvolodine@chromium.org | 2014-06-16T17:00:15.897151Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/promise-with-eventlisteners-expected.txt?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.cpp?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/page-visibility-expected.txt?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/BatteryManager.h?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/api-defined-expected.txt?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/NavigatorBattery.idl?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/multiple-promises-after-resolve-expected.txt?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/multiple-windows-page-visibility.html?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/multiple-windows.html?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt?r1=176222&r2=176221&pathrev=176222
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/test-battery-status-basic.html?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/NavigatorBattery.cpp?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/multiple-promises.html?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/multiple-windows-page-visibility-expected.txt?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/multiple-windows-expected.txt?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/promise-with-eventlisteners.html?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/NavigatorBattery.h?r1=176222&r2=176221&pathrev=176222
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt?r1=176222&r2=176221&pathrev=176222
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/test-battery-status-basic-expected.txt?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/page-visibility.html?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/Source/modules/battery/OWNERS?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/multiple-promises-expected.txt?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/api-defined.html?r1=176222&r2=176221&pathrev=176222
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/battery-status/multiple-promises-after-resolve.html?r1=176222&r2=176221&pathrev=176222

Battery Status API: blink promise implementation and layout tests.

Implement Battery Status API using promises in blink as
according to the (modified) spec:
https://dvcs.w3.org/hg/dap/raw-file/tip/battery/Overview.html.
Using this patch the Battery Status API is accessible using:
navigator.getBattery().then(...) syntax.

Also added layout tests for the various use-cases.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/329723005
-----------------------------------------------------------------
Jun 18, 2014
#102 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc155f23aa932ed7867b7c60867ee2e4989378d

commit 2fc155f23aa932ed7867b7c60867ee2e4989378d
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 18 16:24:27 2014

Battery Status API: end-to-end browsertests and default values.

This patch adds end-to-end testing for the Battery Status API.
Also a small fix in battery_status_service to return default
values if battery_status_manager fails to start (e.g. no battery
or no implementation). That way the promise on the blink side
will resolve with default values as according to the specification.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/334223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278097 0039d316-1c4b-4281-b951-d872f2087c98


Jun 18, 2014
#103 bugdro...@chromium.org
------------------------------------------------------------------
r278097 | timvolodine@chromium.org | 2014-06-18T16:24:27.383311Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=278097&r2=278096&pathrev=278097
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_browsertest.cc?r1=278097&r2=278096&pathrev=278097
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/battery_status?r1=278097&r2=278096&pathrev=278097
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/battery_status/battery_status_promise_resolution_test.html?r1=278097&r2=278096&pathrev=278097
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/battery_status/battery_status_default_test.html?r1=278097&r2=278096&pathrev=278097
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/battery_status/battery_status_event_listener_test.html?r1=278097&r2=278096&pathrev=278097
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_service.cc?r1=278097&r2=278096&pathrev=278097

Battery Status API: end-to-end browsertests and default values.

This patch adds end-to-end testing for the Battery Status API.
Also a small fix in battery_status_service to return default
values if battery_status_manager fails to start (e.g. no battery
or no implementation). That way the promise on the blink side
will resolve with default values as according to the specification.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/334223003
-----------------------------------------------------------------
Jun 20, 2014
#104 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72bd4622bdaa98cacbcc93b91ad532a5b7fc72ce

commit 72bd4622bdaa98cacbcc93b91ad532a5b7fc72ce
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 20 21:40:10 2014

[Android] Battery Status API: some tweaks to the BatteryStatusManager.java.

Make sure battery status works with proper default values
on Android. Add an exception for battery present check for
Galaxy Nexus because it wrongly reports that the battery
is not present (see http://crbug.com/384348).

BUG=122593, 384348, 360068
TEST=http://jsbin.com/battery-status-diagnostics (manual)

Review URL: https://codereview.chromium.org/330333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278829 0039d316-1c4b-4281-b951-d872f2087c98


Jun 20, 2014
#105 bugdro...@chromium.org
------------------------------------------------------------------
r278829 | timvolodine@chromium.org | 2014-06-20T21:40:10.221402Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java?r1=278829&r2=278828&pathrev=278829
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/android/javatests/src/org/chromium/content/browser/BatteryStatusManagerTest.java?r1=278829&r2=278828&pathrev=278829

[Android] Battery Status API: some tweaks to the BatteryStatusManager.java.

Make sure battery status works with proper default values
on Android. Add an exception for battery present check for
Galaxy Nexus because it wrongly reports that the battery
is not present (see http://crbug.com/384348).

BUG=122593, 384348, 360068
TEST=http://jsbin.com/battery-status-diagnostics (manual)

Review URL: https://codereview.chromium.org/330333003
-----------------------------------------------------------------
Jun 23, 2014
#106 tony@chromium.org
(No comment was entered for this change.)
Cc: -tony@chromium.org
Jun 26, 2014
#107 bugdro...@chromium.org
------------------------------------------------------------------
r280071 | timvolodine@chromium.org | 2014-06-26T19:19:55.454273Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/WATCHLISTS?r1=280071&r2=280070&pathrev=280071

Add battery_status watchlist in chromium.

Add a watchlist for the chromium parts of the Battery Status API.

BUG=360068,122593

Review URL: https://codereview.chromium.org/351563002
-----------------------------------------------------------------
Jun 26, 2014
#108 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e093d402cb4cd068d7ab33a1734e4eebe767048

commit 7e093d402cb4cd068d7ab33a1734e4eebe767048
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 26 19:19:55 2014

Add battery_status watchlist in chromium.

Add a watchlist for the chromium parts of the Battery Status API.

BUG=360068,122593

Review URL: https://codereview.chromium.org/351563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280071 0039d316-1c4b-4281-b951-d872f2087c98


Jul 14, 2014
#109 bugdro...@chromium.org
------------------------------------------------------------------
r283015 | sadrul@chromium.org | 2014-07-14T20:54:42.937656Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_chromeos.cc?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_android.cc?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/android/browser_jni_registrar.cc?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager.h?r1=283015&r2=283014&pathrev=283015
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_android.h?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_default.cc?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_service_unittest.cc?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_service.cc?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_browsertest.cc?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/BUILD.gn?r1=283015&r2=283014&pathrev=283015
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java?r1=283015&r2=283014&pathrev=283015

battery-status: Implement the battery-status API for chromeos.

This patch changes BatteryStatusManager to be a pure interface, and moves
platform-specific sub-classes to provide the necessary implementations.

BUG=122593
TEST=manual, using http://jsbin.com/battery-status-diagnostics
R=brettw@chromium.org, jdduke@chromium.org, timvolodine@chromium.org

Review URL: https://codereview.chromium.org/356873002
-----------------------------------------------------------------
Jul 14, 2014
#110 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d561fb859a9adb8c38f8e48fceb09beb42f077c

commit 9d561fb859a9adb8c38f8e48fceb09beb42f077c
Author: sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jul 14 20:54:42 2014

battery-status: Implement the battery-status API for chromeos.

This patch changes BatteryStatusManager to be a pure interface, and moves
platform-specific sub-classes to provide the necessary implementations.

BUG=122593
TEST=manual, using http://jsbin.com/battery-status-diagnostics
R=brettw@chromium.org, jdduke@chromium.org, timvolodine@chromium.org

Review URL: https://codereview.chromium.org/356873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283015 0039d316-1c4b-4281-b951-d872f2087c98


Jul 25, 2014
#111 migu...@chromium.org
(No comment was entered for this change.)
Labels: -M-X M-38
Jul 30, 2014
#112 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/056fb8baa877888f0996eb5283721f1dbf2b5fb4

commit 056fb8baa877888f0996eb5283721f1dbf2b5fb4
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jul 30 18:12:28 2014

Battery Status API: implementation for Mac OS.

Implementation of Battery Status API for the Mac platform.

BUG=122593
TEST=http://jsbin.com/battery-status-diagnostics (manual)

Review URL: https://codereview.chromium.org/398683006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286562 0039d316-1c4b-4281-b951-d872f2087c98


Jul 30, 2014
#113 bugdro...@chromium.org
------------------------------------------------------------------
r286562 | timvolodine@chromium.org | 2014-07-30T18:12:28.864712Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_mac.cc?r1=286562&r2=286561&pathrev=286562
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=286562&r2=286561&pathrev=286562

Battery Status API: implementation for Mac OS.

Implementation of Battery Status API for the Mac platform.

BUG=122593
TEST=http://jsbin.com/battery-status-diagnostics (manual)

Review URL: https://codereview.chromium.org/398683006
-----------------------------------------------------------------
Aug 13, 2014
#115 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886cade0a8e42bede72eef5eb939e5ab01d2d67e

commit 886cade0a8e42bede72eef5eb939e5ab01d2d67e
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Aug 13 20:54:02 2014

Battery Status API: implementation for Linux.

Implementation of the Battery Status API for the Linux platform.
Implementation uses DBus to talk to org.freedesktop.UPower service
to obtain battery information.

BUG=122593
TEST=http://jsbin.com/battery-status-test (manual)
TBR=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/436683002

Cr-Commit-Position: refs/heads/master@{#289372}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289372 0039d316-1c4b-4281-b951-d872f2087c98


Aug 13, 2014
#116 bugdro...@chromium.org
------------------------------------------------------------------
r289379 | dtrainor@chromium.org | 2014-08-13T21:13:55.117962Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_linux_unittest.cc?r1=289379&r2=289378&pathrev=289379
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_linux.cc?r1=289379&r2=289378&pathrev=289379
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_linux.h?r1=289379&r2=289378&pathrev=289379
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=289379&r2=289378&pathrev=289379
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=289379&r2=289378&pathrev=289379
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/BUILD.gn?r1=289379&r2=289378&pathrev=289379

Revert 289372 "Battery Status API: implementation for Linux."

Broke Android Tests (dbg)

> Battery Status API: implementation for Linux.
> 
> Implementation of the Battery Status API for the Linux platform.
> Implementation uses DBus to talk to org.freedesktop.UPower service
> to obtain battery information.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> TBR=brettw@chromium.org
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/436683002

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/472643002
-----------------------------------------------------------------
Aug 13, 2014
#117 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/523f6b744b17ce3da5d6fa1c3af4df4faaec20d8

commit 523f6b744b17ce3da5d6fa1c3af4df4faaec20d8
Author: dtrainor@chromium.org <dtrainor@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Aug 13 21:13:55 2014

Revert 289372 "Battery Status API: implementation for Linux."

Broke Android Tests (dbg)

> Battery Status API: implementation for Linux.
> 
> Implementation of the Battery Status API for the Linux platform.
> Implementation uses DBus to talk to org.freedesktop.UPower service
> to obtain battery information.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> TBR=brettw@chromium.org
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/436683002

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/472643002

Cr-Commit-Position: refs/heads/master@{#289379}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289379 0039d316-1c4b-4281-b951-d872f2087c98


Aug 13, 2014
#118 adamk@chromium.org
(No comment was entered for this change.)
Cc: -adamk@chromium.org
Aug 13, 2014
#120 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d248dd1dbf4c855faa56b8c019f7c6de5600faf

commit 2d248dd1dbf4c855faa56b8c019f7c6de5600faf
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Aug 14 00:54:32 2014

Battery Status API: implementation for Linux.

Implementation of the Battery Status API for the Linux platform.
Implementation uses DBus to talk to org.freedesktop.UPower service
to obtain battery information.

BUG=122593
TEST=http://jsbin.com/battery-status-test (manual)
TBR=brettw@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289372

Review URL: https://codereview.chromium.org/436683002

Cr-Commit-Position: refs/heads/master@{#289431}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289431 0039d316-1c4b-4281-b951-d872f2087c98


Aug 14, 2014
#121 bugdro...@chromium.org
------------------------------------------------------------------
r289634 | timvolodine@chromium.org | 2014-08-14T17:30:11.413004Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=289634&r2=289633&pathrev=289634
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=289634&r2=289633&pathrev=289634
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win_unittest.cc?r1=289634&r2=289633&pathrev=289634
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win.cc?r1=289634&r2=289633&pathrev=289634
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win.h?r1=289634&r2=289633&pathrev=289634

Battery Status API: implementation for Windows.

Implementation of the Battery Status API for the Windows platform.
Implementation uses a message window to receive battery notifications.
On versions prior to Vista there is limited support as the
RegisterPowerSettingNotification function is not available.

BUG=122593
TEST=http://jsbin.com/battery-status-test (manual)

Review URL: https://codereview.chromium.org/447853002
-----------------------------------------------------------------
Aug 14, 2014
#122 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db87f5e40d5d2d9fa00b109756e3381f3a284261

commit db87f5e40d5d2d9fa00b109756e3381f3a284261
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Aug 14 17:30:11 2014

Battery Status API: implementation for Windows.

Implementation of the Battery Status API for the Windows platform.
Implementation uses a message window to receive battery notifications.
On versions prior to Vista there is limited support as the
RegisterPowerSettingNotification function is not available.

BUG=122593
TEST=http://jsbin.com/battery-status-test (manual)

Review URL: https://codereview.chromium.org/447853002

Cr-Commit-Position: refs/heads/master@{#289634}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289634 0039d316-1c4b-4281-b951-d872f2087c98


Aug 14, 2014
#123 bugdro...@chromium.org
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=180296

------------------------------------------------------------------
r180296 | timvolodine@chromium.org | 2014-08-14T19:59:58.663529Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt?r1=180296&r2=180295&pathrev=180296
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=180296&r2=180295&pathrev=180296

Enable Battery Status API by default in Blink.

Set Battery Status API status to stable in blink. We have
implementations for all platforms supported by blink now,
i.e. on Android, Windows, Linux, ChromeOS and Mac.

BUG=122593
TEST=http://jsbin.com/battery-status-test

Review URL: https://codereview.chromium.org/451583003
-----------------------------------------------------------------
Aug 15, 2014
#124 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f8178b7d94b4ac2abe6126c38cb0503089f47da

commit 1f8178b7d94b4ac2abe6126c38cb0503089f47da
Author: jschuh@chromium.org <jschuh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Aug 15 16:23:43 2014

Revert 289634 "Battery Status API: implementation for Windows."

Broke Win XP

> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Review URL: https://codereview.chromium.org/447853002

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/476203002

git-svn-id: svn://svn.chromium.org/chrome/branches/2124/src@289901 0039d316-1c4b-4281-b951-d872f2087c98


Labels: merge-merged-2124
Aug 15, 2014
#125 bugdro...@chromium.org
------------------------------------------------------------------
r289901 | jschuh@chromium.org | 2014-08-15T16:23:43.157789Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/2124/src/content/content_tests.gypi?r1=289901&r2=289900&pathrev=289901
   M http://src.chromium.org/viewvc/chrome/branches/2124/src/content/content_browser.gypi?r1=289901&r2=289900&pathrev=289901
   D http://src.chromium.org/viewvc/chrome/branches/2124/src/content/browser/battery_status/battery_status_manager_win_unittest.cc?r1=289901&r2=289900&pathrev=289901
   D http://src.chromium.org/viewvc/chrome/branches/2124/src/content/browser/battery_status/battery_status_manager_win.cc?r1=289901&r2=289900&pathrev=289901
   D http://src.chromium.org/viewvc/chrome/branches/2124/src/content/browser/battery_status/battery_status_manager_win.h?r1=289901&r2=289900&pathrev=289901

Revert 289634 "Battery Status API: implementation for Windows."

Broke Win XP

> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Review URL: https://codereview.chromium.org/447853002

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/476203002
-----------------------------------------------------------------
Aug 15, 2014
#126 bugdro...@chromium.org
------------------------------------------------------------------
r290050 | timvolodine@chromium.org | 2014-08-15T23:33:10.128681Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=290050&r2=290049&pathrev=290050
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=290050&r2=290049&pathrev=290050
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win_unittest.cc?r1=290050&r2=290049&pathrev=290050
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win.cc?r1=290050&r2=290049&pathrev=290050
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win.h?r1=290050&r2=290049&pathrev=290050

Revert of Battery Status API: implementation for Windows. (patchset #5 of https://codereview.chromium.org/447853002/)

Reason for revert:
breaking XP

Original issue's description:
> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634

TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=122593

Review URL: https://codereview.chromium.org/481493002
-----------------------------------------------------------------
Aug 15, 2014
#127 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f00e68edad4bd1f246c2938b0dc377fd7438ea1

commit 6f00e68edad4bd1f246c2938b0dc377fd7438ea1
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Aug 15 23:33:10 2014

Revert of Battery Status API: implementation for Windows. (patchset #5 of https://codereview.chromium.org/447853002/)

Reason for revert:
breaking XP

Original issue's description:
> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634

TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=122593

Review URL: https://codereview.chromium.org/481493002

Cr-Commit-Position: refs/heads/master@{#290050}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290050 0039d316-1c4b-4281-b951-d872f2087c98


Aug 16, 2014
#128 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2138577840c136e92878a2f1b8b3a8c24bef9eb

commit b2138577840c136e92878a2f1b8b3a8c24bef9eb
Author: timvolodine@chromium.org <timvolodine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat Aug 16 14:40:55 2014

Battery Status API: implementation for Windows.

Implementation of the Battery Status API for the Windows platform.
Implementation uses a message window to receive battery notifications.
On versions prior to Vista there is limited support as the
RegisterPowerSettingNotification function is not available.

BUG=122593, 404139
TEST=http://jsbin.com/battery-status-test (manual)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634

Review URL: https://codereview.chromium.org/447853002

Cr-Commit-Position: refs/heads/master@{#290147}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290147 0039d316-1c4b-4281-b951-d872f2087c98


Aug 16, 2014
#129 bugdro...@chromium.org
------------------------------------------------------------------
r290147 | timvolodine@chromium.org | 2014-08-16T14:40:55.094814Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win.cc?r1=290147&r2=290146&pathrev=290147
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win.h?r1=290147&r2=290146&pathrev=290147
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=290147&r2=290146&pathrev=290147
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=290147&r2=290146&pathrev=290147
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/battery_status/battery_status_manager_win_unittest.cc?r1=290147&r2=290146&pathrev=290147

Battery Status API: implementation for Windows.

Implementation of the Battery Status API for the Windows platform.
Implementation uses a message window to receive battery notifications.
On versions prior to Vista there is limited support as the
RegisterPowerSettingNotification function is not available.

BUG=122593, 404139
TEST=http://jsbin.com/battery-status-test (manual)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634

Review URL: https://codereview.chromium.org/447853002
-----------------------------------------------------------------
Aug 18, 2014
#130 mlamo...@chromium.org
(No comment was entered for this change.)
Blockedon: chromium:385025
Aug 18, 2014
#131 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d57b2e757e55ae7d1046ecaa4db8d79634f8a485

commit d57b2e757e55ae7d1046ecaa4db8d79634f8a485
Author: amineer@chromium.org <amineer@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Aug 18 20:30:08 2014

Revert 290147 "Battery Status API: implementation for Windows."

Speculative revert on branch only; suspect this may cause top crasher.
BUG=404735

> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593, 404139
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634
> 
> Review URL: https://codereview.chromium.org/447853002

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/485823002

git-svn-id: svn://svn.chromium.org/chrome/branches/2127/src@290352 0039d316-1c4b-4281-b951-d872f2087c98


Labels: merge-merged-2127
Aug 18, 2014
#132 bugdro...@chromium.org
------------------------------------------------------------------
r290352 | amineer@chromium.org | 2014-08-18T20:30:08.016476Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/2127/src/content/content_tests.gypi?r1=290352&r2=290351&pathrev=290352
   M http://src.chromium.org/viewvc/chrome/branches/2127/src/content/content_browser.gypi?r1=290352&r2=290351&pathrev=290352
   D http://src.chromium.org/viewvc/chrome/branches/2127/src/content/browser/battery_status/battery_status_manager_win_unittest.cc?r1=290352&r2=290351&pathrev=290352
   D http://src.chromium.org/viewvc/chrome/branches/2127/src/content/browser/battery_status/battery_status_manager_win.cc?r1=290352&r2=290351&pathrev=290352
   D http://src.chromium.org/viewvc/chrome/branches/2127/src/content/browser/battery_status/battery_status_manager_win.h?r1=290352&r2=290351&pathrev=290352

Revert 290147 "Battery Status API: implementation for Windows."

Speculative revert on branch only; suspect this may cause top crasher.
BUG=404735

> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593, 404139
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634
> 
> Review URL: https://codereview.chromium.org/447853002

TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/485823002
-----------------------------------------------------------------
Sep 29 (2 days ago)
#133 rsch...@chromium.org
I'm confused by the dates here. It seems like some but not all of the implementations made it into 38. Did we ship it where available in M38? Or is this an M39 feature?
Sep 29 (2 days ago)
#134 timvolod...@chromium.org
the battery status api has shipped in m38 for all platforms.

the dates are confusing but those speculative reverts had no effect on the branch point. e.g. see https://chromium.googlesource.com/chromium/src/+/38.0.2125.92/content/browser/battery_status/


Sign in to add a comment

Powered by Google Project Hosting