(No comment was entered for this change.)

I have a work-in-progress design doc at:
http://docs.google.com/Doc?id=dfhbsm63_0cx9h7fsz
outlining my overall plan for this. Once details are more settled it can move to 
dev.chromium.org

First chunk: http://codereview.chromium.org/115658

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=16897 

------------------------------------------------------------------------
r16897 | stuartmorgan@chromium.org | 2009-05-26 13:17:50 -0700 (Tue, 26 May 2009) | 9 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/keychain_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/keychain_mac.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac_internal.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=16897&r2=16896

First phase of Mac Keychain integration. For the overall plan, see the design doc linked from the bug. This implements the ability to read existing Keychain passwords, but no storage/updating yet, and no adding of our own metadata as passwords are used; all that will be done in follow-up patches.

This also includes a Keychain wrapper for the functionality necessary so far, and a mock Keychain sufficient to unit-test essentially all of the code.

This patch deliberately excludes the step of instantiating a PasswordStoreMac and hooking it up to the profile, because a bug in autocomplete itself prevents passwords we load from actually being used, and we don't want to trigger Keychain UI for passwords that will be ignored. So this won't be used in builds yet, but it will be unit tested.

BUG=11745
TEST=none (no user-visible effect yet)
Review URL: http://codereview.chromium.org/115658
------------------------------------------------------------------------

Adding the releasenotes label, in hopes of making this a tracking bug for the Mac OS
known issue:
Passwords will not be saved or pre-filled on webpages.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=17557 

------------------------------------------------------------------------
r17557 | stuartmorgan@chromium.org | 2009-06-03 15:50:56 -0700 (Wed, 03 Jun 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profile.cc?r1=17557&r2=17556

Turn on the PasswordStoreMac implementation.

BUG=11745
TEST=Passwords from Keychain should be filled once the username field is filled and blurred.
Review URL: http://codereview.chromium.org/119118
------------------------------------------------------------------------

Confirmed this works as described above with build 3.0.187.0

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=19685 

------------------------------------------------------------------------
r19685 | stuartmorgan@chromium.org | 2009-06-30 16:59:17 -0700 (Tue, 30 Jun 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac.cc?r1=19685&r2=19684
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac.h?r1=19685&r2=19684
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profile.cc?r1=19685&r2=19684
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_constants.cc?r1=19685&r2=19684
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_constants.h?r1=19685&r2=19684

Wire up a LoginDatabase for PasswordStoreMac, and start using it for lookup.
(Although it will always be empty at this point, since storage isn't implemented yet.)

BUG=11745
TEST=none (no user-visible effect yet)
Review URL: http://codereview.chromium.org/147044
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=19822 

------------------------------------------------------------------------
r19822 | stuartmorgan@chromium.org | 2009-07-02 09:58:03 -0700 (Thu, 02 Jul 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/keychain_mock_mac.cc?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/keychain_mock_mac.h?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/login_database.cc?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/login_database.h?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/login_database_unittest.cc?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac.cc?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac_internal.h?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_store_mac_unittest.cc?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sqlite_utils.cc?r1=19822&r2=19821
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sqlite_utils.h?r1=19822&r2=19821

Implement Add and Update for PasswordStoreMac.
Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing.
Add creator code for keychain items we create, and unit tests to make sure.

BUG=11745
TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction.
Review URL: http://codereview.chromium.org/151176
------------------------------------------------------------------------

With the landing of 20441 (which I forgot to associate with this bug), I think things are 
far enough along that a central tracking bug is no longer necessary. I'll file bugs for 
individual pieces that need to be implemented.

3.0.194.0 rev:20610