| Issue 114598: | Custom cursor decoding with wrong color | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
When Skia was switched on for the Mac, the internals started sending cursor data in a different bitmap format. http://www.w3schools.com/cssref/playit.asp?filename=playcss_cursor&preval=url(smiley.gif),url(myBall.cur),auto The cursor should be yellow, not blue.
Comment
1
by
carycl...@chromium.org,
Feb 16, 2012
Cc: r...@google.com
,
Feb 16, 2012
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=122386
------------------------------------------------------------------------
r122386 | avi@chromium.org | Thu Feb 16 15:22:06 PST 2012
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_view_mac.mm?r1=122386&r2=122385&pathrev=122386
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webcursor.h?r1=122386&r2=122385&pathrev=122386
M http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/native_widget_types.h?r1=122386&r2=122385&pathrev=122386
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webcursor_mac.mm?r1=122386&r2=122385&pathrev=122386
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm?r1=122386&r2=122385&pathrev=122386
Fix Mac custom cursor color.
BUG=114598
TEST=as in bug
Review URL: http://codereview.chromium.org/9419010
------------------------------------------------------------------------
,
Feb 16, 2012
This is a skia fix. What branches does this need merging to?
Labels: Merge-Requested
,
Feb 16, 2012
I'm OK with waiting for 18 for this.
Labels: Mstone-18
,
Feb 16, 2012
I'm not clear what you mean by that. Are you OK with merging this to 18? Not?
,
Feb 17, 2012
Canary looks good so far. The change moved the image work from CreateCGImageFromCustomData to CreateCustomCursor. No crashes in CreateCustomCursor so far, and there were extremely sporadic crashes in CreateCGImageFromCustomData historically.
,
Feb 17, 2012
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
,
Feb 17, 2012
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=122559
------------------------------------------------------------------------
r122559 | avi@chromium.org | Fri Feb 17 12:03:05 PST 2012
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/browser/renderer_host/render_widget_host_view_mac.mm?r1=122559&r2=122558&pathrev=122559
M http://src.chromium.org/viewvc/chrome/branches/1025/src/ui/gfx/native_widget_types.h?r1=122559&r2=122558&pathrev=122559
M http://src.chromium.org/viewvc/chrome/branches/1025/src/webkit/glue/webcursor_mac.mm?r1=122559&r2=122558&pathrev=122559
M http://src.chromium.org/viewvc/chrome/branches/1025/src/webkit/tools/test_shell/mac/test_webview_delegate.mm?r1=122559&r2=122558&pathrev=122559
M http://src.chromium.org/viewvc/chrome/branches/1025/src/webkit/glue/webcursor.h?r1=122559&r2=122558&pathrev=122559
Merge 122386 - Fix Mac custom cursor color.
BUG=114598
TEST=as in bug
Review URL: http://codereview.chromium.org/9419010
TBR=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9355017
------------------------------------------------------------------------
Labels: -merge-approved merge-merged-1025
,
Feb 17, 2012
(No comment was entered for this change.)
Status: Fixed
|
||||||||||
| ► Sign in to add a comment | |||||||||||
,url(myBall.cur),auto){kind=link}