| Issue 112614: | Print Dialog Partly Off Screen w/ Windows 7 Vertical Taskbar | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome Version : 17.0.963.46 beta-m O/S: Windows 7, Service Pack 1 URLs (if applicable) : All What steps will reproduce the problem? 1. Set the Windows 7 taskbar to a vertical position on the left side 3. Attempt to print a website from Google Chrome What is the expected result? The print dialog should appear in full. What happens instead? The print dialog is partly off screen to the right. I must drag the print dialog window to the left in order to display the upper right 'X' to close the window and see the rest of the preview. Please provide any additional information below. Attach a screenshot if possible. As seen from the screenshots, this problem is fixed (print dialog is centered) when I move the taskbar to the normal, horizontal position. Chrome can be either maximized or windowed.
,
Feb 6, 2012
brettw: Are you the right person to look at this? It looks like AdjustWindowToFit() is taking the available desktop/monitor space into consideration, even though the rect we are adjusting is using coordinates relative to some part of a window. (I'm guessing the ConstrainedWindow is a child window here, but I'm not sure if my terminology is correct.) The call stack here looks like: AdjustWindowToFit() ui::CenterAndSizeWindow() views::NativeWidgetWin::CenterWindow() views::Widget::SetInitialBounds() views::Widget::Init() ConstrainedWindowViews::ConstrainedWindowViews() BTW, NativeWidgetWin::CenterWindow() is the only caller ui::CenterAndSizeWindow(), and it always passes |pref_is_client| as false. So there's probably some dead code in here as of right now.
Cc: brettw@chromium.org
,
Feb 6, 2012
I'm going to ask Ben instead, since he is in ui/base/OWNERS, and brettw mostly just did refactoring work there.
Cc: -brettw@chromium.org ben@chromium.org
,
Feb 7, 2012
Here's a possible fix: http://codereview.chromium.org/9346026/
,
Feb 8, 2012
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=121180
------------------------------------------------------------------------
r121180 | thestig@chromium.org | Wed Feb 08 19:56:31 PST 2012
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.cc?r1=121180&r2=121179&pathrev=121180
M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/hwnd_util.h?r1=121180&r2=121179&pathrev=121180
M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/hwnd_util.cc?r1=121180&r2=121179&pathrev=121180
views / Windows: A child window should be centered with respect to its parent, not the monitor.
BUG=112614
TEST=none
Review URL: http://codereview.chromium.org/9351010
------------------------------------------------------------------------
,
Feb 8, 2012
We'll let people test this on Google Chrome Canary, and then see if we want to merge it to the beta/stable channels.
Status: Started
Owner: thestig@chromium.org
,
Feb 16, 2012
So as far as I know, nothing has explored on canary. Let's try merging this to beta channel.
Cc: ka...@chromium.org
Labels: Merge-Requested Mstone-18
,
Feb 17, 2012
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
,
Feb 17, 2012
(No comment was entered for this change.)
Status: Fixed
,
Feb 17, 2012
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=122555
------------------------------------------------------------------------
r122555 | thestig@chromium.org | Fri Feb 17 11:56:42 PST 2012
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/1025/src/ui/base/win/hwnd_util.cc?r1=122555&r2=122554&pathrev=122555
M http://src.chromium.org/viewvc/chrome/branches/1025/src/ui/base/win/hwnd_util.h?r1=122555&r2=122554&pathrev=122555
M http://src.chromium.org/viewvc/chrome/branches/1025/src/ui/views/widget/native_widget_win.cc?r1=122555&r2=122554&pathrev=122555
Merge 121180 - views / Windows: A child window should be centered with respect to its parent, not the monitor.
BUG=112614
TEST=none
Review URL: http://codereview.chromium.org/9351010
TBR=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9426006
------------------------------------------------------------------------
Labels: -merge-approved merge-merged-1025
|
||||||||||
| ► Sign in to add a comment | |||||||||||
Labels: -Area-Undefined -OS-Chrome Area-UI OS-Windows Feature-PrintPreview