(No comment was entered for this change.)

(No comment was entered for this change.)

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=24238 

------------------------------------------------------------------------
r24238 | dglazkov@chromium.org | 2009-08-25 09:51:38 -0700 (Tue, 25 Aug 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=24238&r2=24237

Create master bug and group failures for HTML5 Geolocation API.

TBR=agl
TEST=none
BUG=11246

Review URL: http://codereview.chromium.org/174400
------------------------------------------------------------------------

It would be good to get the GEO API into place, especially on Mac given that we won't 
be supporting Gears on Chromium for Mac.  However, when is a reasonable timeline for 
this?  

The guys in London are working on this, might need to add people into the issue tracker 
before I can assign it. Will circle back. Either way I'm hoping this lands by end of 
October.

This is not going to land in October/November. Moving to mstone-5.

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32296 

------------------------------------------------------------------------
r32296 | dpranke@google.com | 2009-11-17 22:30:07 -0800 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=32296&r2=32295

Mark fast/dom/Geolocation as DEFER SKIP since we don't implement it yet.

  R=dglazkov@chromium.org
  BUG=11246
  TEST=LayoutTests/fast/dom/Geolocation

Review URL: http://codereview.chromium.org/405012
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32296 

------------------------------------------------------------------------
r32296 | dpranke@google.com | 2009-11-17 22:30:07 -0800 (Tue, 17 Nov 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=32296&r2=32295

Mark fast/dom/Geolocation as DEFER SKIP since we don't implement it yet.

  R=dglazkov@chromium.org
  BUG=11246
  TEST=LayoutTests/fast/dom/Geolocation

Review URL: http://codereview.chromium.org/405012
------------------------------------------------------------------------

(No comment was entered for this change.)

This is targeted for mstone-5. mseaborn + joth are working on this.

apologies, i moved it cause it says Layout Test and we generally categorize all layout 
tests for X.

Can I get this bug be assigned over to me please.

Here's the design doc: http://docs.google.com/View?id=dfbnm49n_0dpc7pxpx

all yours :)

Just read the design doc. It's a bit weird that there's a link in the UI that only opens a 
bubble instead of a page when clicked. 

Chromium users on Identi.ca have been complaining that their location data is shared
without their knowledge or consent. Since Firefox and Chrome seems to ask users
before sharing location, we haven't built anything into our UI to re-confirm ("Are
you really, really, really sure you want to share your location? Really? How about
now? And now?"). Is this on the timeline for Chromium? Is there a workaround now, to
avoid sharing location with unauthorized Web sites?

Re: 17, Given that we don't yet support the html5 geolocation api, I don't think you 
have to worry about sharing location with unauthorized websites as the code to actually 
give the location is not yet implemented. (There's the gears API, but that also prompts 
for location).

With the current Chromium build in Fedora 12 (4.0.277.0) I am NOT being prompted and 
my location is automatically shared on identi.ca - I have no way to access the Gears 
settings to change this behaviour as far as I know. This is not acceptable IMO as my 
location is shared very granularly without my express permission or even a 
notification.

fscherel: chromium doesn't support gears on linux, and the html5 location api isn't 
implemented either. identi.ca can't get your location from chromium.

maybe they do an IP-to-location lookup on your IP address. That's possible server-side 
and gives somewhat good results (within several kilometers).

According to identi.ca, it is only using Gears. If it was IP address lookup, it 
wouldn't be so blatantly broken as well. It currently puts me in Israel while I have a 
very well known German IP prefix.

fscherel: Sounds like an identi.ca bug then. Gears for chrome/linux doesn't exist.

OK, seems I was mistaken. Excuse my uninformed postings. Carry on. And thanks for the 
swift responses! :)

(No comment was entered for this change.)

 Issue 19308  has been merged into this issue.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37009 

------------------------------------------------------------------------
r37009 | joth@chromium.org | 2010-01-25 08:47:24 -0800 (Mon, 25 Jan 2010) | 9 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/device_data_provider.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.h

Adding geolocation data provider infrastructure to Chrome.
These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/

NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.

BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)

Review URL: http://codereview.chromium.org/546116
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37015 

------------------------------------------------------------------------
r37015 | joth@chromium.org | 2010-01-25 09:26:58 -0800 (Mon, 25 Jan 2010) | 14 lines
Changed paths:
   D /trunk/src/chrome/browser/geolocation

Revert 37009 - Adding geolocation data provider infrastructure to Chrome.
Rolling back as it seems to have broken the Mac build

These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/

NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.

BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)

Review URL: http://codereview.chromium.org/546116

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/553069
------------------------------------------------------------------------

 Issue 32950  has been merged into this issue.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37117 

------------------------------------------------------------------------
r37117 | joth@chromium.org | 2010-01-26 09:59:34 -0800 (Tue, 26 Jan 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=37117&r2=37116
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/device_data_provider.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.h

(Second attempt at http://codereview.chromium.org/553069/show -- this time including DEPS exclusion)

These files are lifted from gears: http://code.google.com/p/gears/source/browse/trunk/gears/geolocation/

NOTE this is a direct copy of gears files; subsequent edits will be made to bring them into chrome style and add to gypi files and so on.

BUG=11246
TEST=None (just adding placeholder files; tests will follow in next change)

Review URL: http://codereview.chromium.org/556003
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37396 

------------------------------------------------------------------------
r37396 | joth@chromium.org | 2010-01-28 04:24:24 -0800 (Thu, 28 Jan 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=37396&r2=37395
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/device_data_provider.h?r1=37396&r2=37395
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc?r1=37396&r2=37395
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.h?r1=37396&r2=37395
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc?r1=37396&r2=37395
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h?r1=37396&r2=37395
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc?r1=37396&r2=37395
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.h?r1=37396&r2=37395
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.h
   D /trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.cc
   D /trunk/src/chrome/browser/geolocation/wifi_data_provider_osx.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc?r1=37396&r2=37395
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h?r1=37396&r2=37395
   D /trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.cc
   D /trunk/src/chrome/browser/geolocation/wifi_data_provider_windows_common.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=37396&r2=37395
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=37396&r2=37395

Update Gears wifi data providers to Chrome style & APIs.
Add wifi data provider to project.
Add tests for windows provider. (More to follow)

BUG=11246
TEST=unit_tests - wifi_data_provider_win_unittest.cc

Review URL: http://codereview.chromium.org/543174
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37400 

------------------------------------------------------------------------
r37400 | joth@chromium.org | 2010-01-28 05:50:04 -0800 (Thu, 28 Jan 2010) | 10 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/backoff_manager.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/backoff_manager.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider_pool.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider_pool.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.h

Add more gears geolocaiton files into chromium: locaiton provider, network location provider, and backoff maanger.

All files are from svn checkout http://gears.googlecode.com/svn/trunk/ gears-read-only r3414

Only modification is #if 0 around each file, to avoid build / checkdeps breakage.

BUG=11246
TEST=None (just importing code, tests to follow)

Review URL: http://codereview.chromium.org/555148
------------------------------------------------------------------------

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37850 

------------------------------------------------------------------------
r37850 | joth@chromium.org | 2010-02-02 10:28:08 -0800 (Tue, 02 Feb 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/geolocation/backoff_manager.cc
   D /trunk/src/chrome/browser/geolocation/backoff_manager.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/device_data_provider.h?r1=37850&r2=37849
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geoposition.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geoposition.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.cc?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider_pool.cc?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider_pool.h?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.cc?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.h?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.cc?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.h?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc?r1=37850&r2=37849
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=37850&r2=37849

Port the gears geolocation network provider to Chromium

BUG=http://crbug.com/11246
TEST=See http://codereview.chromium.org/556106

Review URL: http://codereview.chromium.org/552250
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 

------------------------------------------------------------------------
r37989 | joth@chromium.org | 2010-02-03 10:35:09 -0800 (Wed, 03 Feb 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc?r1=37989&r2=37988
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.h?r1=37989&r2=37988
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h?r1=37989&r2=37988
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.cc?r1=37989&r2=37988
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h?r1=37989&r2=37988
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.cc?r1=37989&r2=37988
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc?r1=37989&r2=37988
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc?r1=37989&r2=37988
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=37989&r2=37988

Add tests for the geolocation network provider.
Also some small tidy up a few other files.

BUG=http://crbug.com/11246 
TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure

Review URL: http://codereview.chromium.org/556106
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37992 

------------------------------------------------------------------------
r37992 | joth@chromium.org | 2010-02-03 11:05:29 -0800 (Wed, 03 Feb 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.cc?r1=37992&r2=37991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/empty_device_data_provider.h?r1=37992&r2=37991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h?r1=37992&r2=37991
   D /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.cc?r1=37992&r2=37991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h?r1=37992&r2=37991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common_win.cc?r1=37992&r2=37991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_linux.cc?r1=37992&r2=37991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_mac.cc?r1=37992&r2=37991
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=37992&r2=37991

Revert 37989 - unit test failed on Mac builder despite passing on try server
Original change:
Add tests for the geolocation network provider.
Also some small tidy up a few other files.

BUG=http://crbug.com/11246 
TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure

Review URL: http://codereview.chromium.org/556106

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/570006
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38207 

------------------------------------------------------------------------
r38207 | joth@chromium.org | 2010-02-05 04:37:57 -0800 (Fri, 05 Feb 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h?r1=38207&r2=38206
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.cc?r1=38207&r2=38206
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.cc?r1=38207&r2=38206
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=38207&r2=38206

Re-attempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 
(asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show)

Add tests for the geolocation network provider. 
Also some small tidy up a few other files. 

BUG=http://crbug.com/11246 
TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure 


Review URL: http://codereview.chromium.org/578006
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38208 

------------------------------------------------------------------------
r38208 | joth@chromium.org | 2010-02-05 05:01:55 -0800 (Fri, 05 Feb 2010) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h?r1=38208&r2=38207
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.cc?r1=38208&r2=38207
   D /trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.cc?r1=38208&r2=38207
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=38208&r2=38207

Revert 38207 - bah. still can't work out why this passes fine on local machine & try bots.

Reattempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 
(asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show)

Add tests for the geolocation network provider. 
Also some small tidy up a few other files. 

BUG=http://crbug.com/11246 
TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure 


Review URL: http://codereview.chromium.org/578006

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/575021
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38213 

------------------------------------------------------------------------
r38213 | joth@chromium.org | 2010-02-05 08:46:23 -0800 (Fri, 05 Feb 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h?r1=38213&r2=38212
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.cc?r1=38213&r2=38212
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.cc?r1=38213&r2=38212

Split out of reverted change http://src.chromium.org/viewvc/chrome?view=rev&revision=38207
Commit fixes to code under test, whilst tests themselves are still pending.

BUG=http://crbug.com/11246
TEST=see http://codereview.chromium.org/578006

Review URL: http://codereview.chromium.org/571014
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38354 

------------------------------------------------------------------------
r38354 | joth@chromium.org | 2010-02-08 05:17:26 -0800 (Mon, 08 Feb 2010) | 10 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=38354&r2=38353

Hopefully final attempt at landing http://src.chromium.org/viewvc/chrome?view=rev&revision=38207
Adds tests for network geolocation provider.

In the end, it seems templated static methods cannot be called from gtest's SetUp method on a Mac Release build. Beats me. I'm doing my stuff in the c'tor for now, and made a note to come back to it.

BUG=http://crbug.com/11246 
TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure 


Review URL: http://codereview.chromium.org/578017
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38890 

------------------------------------------------------------------------
r38890 | joth@chromium.org | 2010-02-12 04:52:04 -0800 (Fri, 12 Feb 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.cc?r1=38890&r2=38889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common.h?r1=38890&r2=38889
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_common_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_unittest_win.cc?r1=38890&r2=38889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.cc?r1=38890&r2=38889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/wifi_data_provider_win.h?r1=38890&r2=38889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=38890&r2=38889

Refactor the state-machine & threading out of the windows wifi provider into a cross platform base class
This will make the linux & mac impementations much simpler

BUG=11246
TEST=Aded wifi_data_provider_common_unittest.cc. Run: unit_tests.exe --gtest_filer=Geoloc*


Review URL: http://codereview.chromium.org/604019
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=39067 

------------------------------------------------------------------------
r39067 | joth@chromium.org | 2010-02-15 07:15:22 -0800 (Mon, 15 Feb 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_prefs.cc?r1=39067&r2=39066
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/access_token_store.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/access_token_store.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geoposition.h?r1=39067&r2=39066
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_arbitrator.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_arbitrator.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_provider.h?r1=39067&r2=39066
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.cc?r1=39067&r2=39066
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider.h?r1=39067&r2=39066
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_provider_unittest.cc?r1=39067&r2=39066
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.h?r1=39067&r2=39066
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=39067&r2=39066
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=39067&r2=39066
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=39067&r2=39066

Add support for top level geolocation arbitrator, and access token persistence (via local state prefs)


BUG=11246
TEST=unit_tests.exe --gtest_filer=Geoloc* 

Review URL: http://codereview.chromium.org/603040
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=39629 

------------------------------------------------------------------------
r39629 | joth@chromium.org | 2010-02-22 12:58:12 -0800 (Mon, 22 Feb 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/network_location_request.cc?r1=39629&r2=39628

Fix geolocation network request to not send/save cookies or send authentication data when accessing the network location server. This is to conserve user privacy.
Remove obsolete todos whilst in there.

BUG=http://crbug.com/11246
TEST=use wireshark to inspect request headers sent.


Review URL: http://codereview.chromium.org/650144
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=40118 

------------------------------------------------------------------------
r40118 | joth@chromium.org | 2010-02-26 06:29:12 -0800 (Fri, 26 Feb 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc?r1=40118&r2=40117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.cc?r1=40118&r2=40117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_dispatcher_host.h?r1=40118&r2=40117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_arbitrator.cc?r1=40118&r2=40117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_arbitrator.h?r1=40118&r2=40117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/location_arbitrator_unittest.cc?r1=40118&r2=40117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/geolocation_dispatcher.cc?r1=40118&r2=40117

Bring Geolocation to life!
Bolt the geolocation dispatcher host up to the location arbitrator
Introduces a new method for fetching a singleton default location arbitrator with minimal fuss.
Fix bug in the geolocation dispatcher where bridge id & route id were swapped on send.

BUG=http://crbug.com/11246
TEST=run browser with --enable-geolocaiton & Open http://maps.google.co.uk/maps/m

Review URL: http://codereview.chromium.org/658005
------------------------------------------------------------------------

(No comment was entered for this change.)

I just want to correct the spelling of the option which enables location: its --enable-
geolocation (for those of us who just copy & paste). 
Anyways good job.

Having problems with watchPosition on 5.0.342.3 dev on 10.5.8. I seem to only receive one callback per page 
load. Not sure if watchPosition support has been implemented yet. I can work up something more reproducible if 
it should be working.

Interesting. Moving around with watchPosition enabled didn't trigger any callbacks, but after ~10 minutes of 
being stationary I ended up receiving a few callbacks. I'll look into this further.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=41951 

------------------------------------------------------------------------
r41951 | joth@chromium.org | 2010-03-18 06:48:02 -0700 (Thu, 18 Mar 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings.grd?r1=41951&r2=41950
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc?r1=41951&r2=41950
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/infobar_delegate.h?r1=41951&r2=41950
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/infobars/infobars.cc?r1=41951&r2=41950
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/infobars/infobars.h?r1=41951&r2=41950

Finish implementing the geolocation infobar; adds a Learn more link pointing to the (placeholder) help center page.
This extends ConfirmInfoBar to support to have optional link support (simple support, i.e. not the inserted mid-label link that LinkInfoBar sports)

Note 1: this does not exactly match the mock; the allow/deny buttons and link are swapped. I think this looks nicer, is more consistent with other confirm infobars, and happens to be easier to code
Note 2: linux & mac will need follow-up CLs, but will simply ignore the link in the meantime

BUG=11246
TEST=browser_tests.exe --gtest_filter=Geol*


Review URL: http://codereview.chromium.org/1037006
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42337 

------------------------------------------------------------------------
r42337 | joth@chromium.org | 2010-03-23 04:45:19 -0700 (Tue, 23 Mar 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/infobar_gtk.cc?r1=42337&r2=42336
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/infobar_gtk.h?r1=42337&r2=42336

Implement ConfirmInfoBar link support on GTK
this is the follow up to http://codereview.chromium.org/1037006 which added it on windows, and http://codereview.chromium.org/1127001 which added it to Mac.

BUG=11246
TEST=run browser with --enable-geolocation, open maps.google.com and click my location.

Review URL: http://codereview.chromium.org/1081007
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42338 

------------------------------------------------------------------------
r42338 | joth@chromium.org | 2010-03-23 05:03:13 -0700 (Tue, 23 Mar 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_controller.h?r1=42338&r2=42337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_controller.mm?r1=42338&r2=42337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_controller_unittest.mm?r1=42338&r2=42337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_test_helper.h?r1=42338&r2=42337

Implement the confirm infobar with link for mac.

BUG=11246
TEST=browser_tests.exe --gtest_filter=Geol*

Review URL: http://codereview.chromium.org/1127001
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42594 

------------------------------------------------------------------------
r42594 | joth@chromium.org | 2010-03-25 03:12:56 -0700 (Thu, 25 Mar 2010) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc?r1=42594&r2=42593
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_permission_context.cc?r1=42594&r2=42593
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/geolocation_permission_context.h?r1=42594&r2=42593
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=42594&r2=42593
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=42594&r2=42593
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=42594&r2=42593
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/geolocation/iframes_different_origin.html?r1=42594&r2=42593

Adds GeolocationContentSettings on TabContents. 

This data structure and the notification flow will be used to populate the location bar icon and its bubble. 

 - this was originally part of http://codereview.chromium.org/650180
 - Fully reviewed as http://codereview.chromium.org/1143002 I'm just landing on Marcus's behalf

TBR=bulach
BUG=11246
TEST=geolocation_browsertest.cc


Review URL: http://codereview.chromium.org/1320005
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42599 

------------------------------------------------------------------------
r42599 | joth@chromium.org | 2010-03-25 05:02:44 -0700 (Thu, 25 Mar 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=42599&r2=42598

Add all the strings required for the geolocation bubble, location bar icon, and inforbar

BUG=11246
TEST=none

Review URL: http://codereview.chromium.org/1301001
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42633 

------------------------------------------------------------------------
r42633 | joth@chromium.org | 2010-03-25 10:31:27 -0700 (Thu, 25 Mar 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm?r1=42633&r2=42632
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/content_exceptions_window_gtk.cc?r1=42633&r2=42632
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/content_settings_window_gtk.cc?r1=42633&r2=42632
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=42633&r2=42632
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/content_settings_window_view.cc?r1=42633&r2=42632
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/content_settings_types.h?r1=42633&r2=42632

Add Geolocation to the content types. This adds several special case guards so we can still build & run whilst the full implementation is being worked on (in parallel)

(Some code taken from http://codereview.chromium.org/650180)

BUG=11246
TEST=Built & ran on all three platforms. Used geolocation & open content setting dialog.

Review URL: http://codereview.chromium.org/1241006
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42665 

------------------------------------------------------------------------
r42665 | joth@chromium.org | 2010-03-25 13:46:02 -0700 (Thu, 25 Mar 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=42665&r2=42664
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_bubble_model.cc?r1=42665&r2=42664
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_bubble_model.h?r1=42665&r2=42664
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_image_model.cc?r1=42665&r2=42664

Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180

TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)


BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.


Review URL: http://codereview.chromium.org/1344002
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42668 

------------------------------------------------------------------------
r42668 | joth@chromium.org | 2010-03-25 13:59:27 -0700 (Thu, 25 Mar 2010) | 17 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=42668&r2=42667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_bubble_model.cc?r1=42668&r2=42667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_bubble_model.h?r1=42668&r2=42667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_image_model.cc?r1=42668&r2=42667

Revert 42665 - broke build as I missed a unit test when building locally.

Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180

TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)


BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.


Review URL: http://codereview.chromium.org/1344002

TBR=joth@chromium.org
Review URL: http://codereview.chromium.org/1367002
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42739 

------------------------------------------------------------------------
r42739 | joth@chromium.org | 2010-03-26 02:32:20 -0700 (Fri, 26 Mar 2010) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=42739&r2=42738
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=42739&r2=42738
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_bubble_model.cc?r1=42739&r2=42738
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_bubble_model.h?r1=42739&r2=42738
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/content_setting_image_model.cc?r1=42739&r2=42738

Re-attempt at http://codereview.chromium.org/1344002

Adds geolocaiton support to the location bar content image model and content bubble model.
Most of these edits were lifted out of http://codereview.chromium.org/650180

TODO: add geolocation support to the views in the three UI platforms for the bubble model.
(NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs)


BUG=11246
TEST=open a site that uses geolocaiton, select allow/deny & click the icon.

Review URL: http://codereview.chromium.org/1369002
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42749 

------------------------------------------------------------------------
r42749 | joth@chromium.org | 2010-03-26 05:27:22 -0700 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc?r1=42749&r2=42748
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/content_blocked_bubble_contents.h?r1=42749&r2=42748

First cut at implementing the windows geolocaiton bubble view.
Depends on http://codereview.chromium.org/1369002

BUG=11246
TEST=--enable-geolocation and open http://bulach-pc.lon/chromium/wk/LayoutTests/fast/dom/Window/mbi.html


Review URL: http://codereview.chromium.org/1348002
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42756 

------------------------------------------------------------------------
r42756 | thakis@chromium.org | 2010-03-26 07:14:25 -0700 (Fri, 26 Mar 2010) | 12 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/ContentBubbleGeolocation.xib
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm?r1=42756&r2=42755
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=42756&r2=42755
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=42756&r2=42755

Mac: Initial Geolocation UI.

For now, an in-progress version of the bubble/omnibox icon. The bubble shows up, but doesn't do much yet. The two buttons are disabled because they both don't do anything yet. Since this is behind a flag, I think checking in work-in-progress UI is fine.

Parts of this CL were merged in from http://codereview.chromium.org/1369002 . Ignore the files from that CL.

http://imgur.com/tWJhg

BUG=11246
TEST=Start chrome with --enable-geolocation, go to http://maxheapsize.com/static/html5geolocationdemo.html , click allow or deny, observe that an icon appears. Click icon, a bubble appears.

Review URL: http://codereview.chromium.org/1345005
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42790 

------------------------------------------------------------------------
r42790 | joth@chromium.org | 2010-03-26 11:47:04 -0700 (Fri, 26 Mar 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc?r1=42790&r2=42789
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.h?r1=42790&r2=42789

Implement the geolocation bubble for GTK
This is a port of http://src.chromium.org/viewvc/chrome?view=rev&revision=42749

BUG=11246
TEST=run with --enable-geolocation and open http://bulach-pc.lon/chromium/wk/LayoutTests/fast/dom/Window/mbi.html then click the location bar icon


Review URL: http://codereview.chromium.org/1360007
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42827 

------------------------------------------------------------------------
r42827 | thakis@chromium.org | 2010-03-26 14:44:17 -0700 (Fri, 26 Mar 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/ContentBubbleGeolocation.xib?r1=42827&r2=42826
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/ContentSettings.xib?r1=42827&r2=42826
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm?r1=42827&r2=42826
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.h?r1=42827&r2=42826
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_settings_dialog_controller.mm?r1=42827&r2=42826

Mac: Add geolocation content setting.

The radio button seems to be non-functional; probably the backend probably isn't there yet.

xib changes: Added a location tab to contentsettings.xib, bind its radio buttons and normal button to the new methods in the controller. In the bubble, enable the "settings" button.

BUG=11246
TEST=content settings now has a "location" tab.

Review URL: http://codereview.chromium.org/1428002
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42923 

------------------------------------------------------------------------
r42923 | thakis@chromium.org | 2010-03-28 18:53:43 -0700 (Sun, 28 Mar 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/ContentBubbleGeolocation.xib?r1=42923&r2=42922
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.h?r1=42923&r2=42922
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/content_blocked_bubble_controller.mm?r1=42923&r2=42922

Mac: Fill in geolocation bubble from model.

xib changes: Removed everything above the horizontal line and put an empty NSView there, as container for the geo stuff (maybe later, there should be only one xib file for all bubble types and the container should be filled from the bubble model in all cases. Not in this CL.)

http://imgur.com/AtXiq

BUG=11246
TEST=Start chromium with --enable-geolocation. Go to http://maxheapsize.com/static/html5geolocationdemo.html , click "Allow" or "Deny". Bubble should appear. It should behave like on windows or linux (except that it has buttons instead of links. We only use links for stuff that opens web pages on clicking on OS X.)

Review URL: http://codereview.chromium.org/1542001
------------------------------------------------------------------------

(No comment was entered for this change.)

(No comment was entered for this change.)

Marking as fixed (huzzah!) as all identified feature work has been committed.

This is bad news for users of chase.com.

Previously, when --enable-geolocation was set, chase.com would crash upon successful 
login. Now that geolocation is on by default, it always crashes upon successful login 
to chase.com.

--disable-geolocation does not seem to be a valid switch. Any chance of adding this 
switch in so that users of chase.com don't have to resort to IETab every time, until 
this bug is fixed?

The chase.com / geolocation bug is  Issue 38588  .

I apologize. It appears that --disable-geolocation does, in fact, exist. It also fixes 
the problem with logging into chase.com.

In any case, I would still love to be able to keep geolocation turned on and still be 
able to login to chase.com.

The chase.com issue is already reported in http://code.google.com/p/chromium/issues/detail?id=38588 so no 
need to track that here too.

As per comment 4 in that bug, I'm still trying to find someone with a chase.com account who can help me 
investigate this.

I know that maybe this is not a Chrome issue, but a w3 issue.
How can i change the location provider url ?
I want to use a custom location server for use inside a company.
With gears API this was possible as a options property, but is missing in the w3 API.

The Geolocation feature is now available in chrome 5.0.375.25 (Official Build 45690).