My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 11191: Import bookmarks and settings... dialog
2 people starred this issue and may be notified of changes. Back to list
Status:  Verified
Owner:  kuchhal@chromium.org
Closed:  May 2009
Type-Bug
Pri-2
OS-Linux
Area-BrowserUI
Size-Medium
GtkHacker


Sign in to add a comment
 
Reported by evan@chromium.org, Apr 29, 2009
Need a dialog.  Functionality should more or less match Windows.
Comment 1 by kuchhal@chromium.org, May 01, 2009
Not sure if this can be done by someone just starting on Linux but I am going to start 
looking into this.
Status: Assigned
Owner: kuch...@chromium.org
Comment 2 by evan@chromium.org, May 01, 2009
Cool!  Let me know if you have any questions about GTK.
If you have questions about window layout, this is a good page:
http://library.gnome.org/devel/hig-book/stable/design-window.html.en
Comment 3 by bugdroid1@chromium.org, May 11, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=15815 

------------------------------------------------------------------------
r15815 | kuchhal@chromium.org | 2009-05-11 16:45:25 -0700 (Mon, 11 May 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=15815&r2=15814
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.h?r1=15815&r2=15814
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=15815&r2=15814
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/import_dialog_gtk.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/import_dialog_gtk.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_importer_utils.cc?r1=15815&r2=15814
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_importer_utils.h?r1=15815&r2=15814
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_profile_lock.cc?r1=15815&r2=15814
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/importer.cc?r1=15815&r2=15814
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=15815&r2=15814

Add import settings dialog on linux.

BUG=11191
TEST=Open Import Settings dialog from Chrome wrench menu on Linux and make sure it imports Firefox data as selected.

Review URL: http://codereview.chromium.org/115133

------------------------------------------------------------------------

Comment 4 by evan@chromium.org, May 15, 2009
(No comment was entered for this change.)
Status: Started
Comment 5 by evan@chromium.org, May 15, 2009
(No comment was entered for this change.)
Labels: Mstone-LinuxDev
Comment 6 by evan@chromium.org, May 15, 2009
(No comment was entered for this change.)
Labels: -Mstone-LinuxDev
Comment 7 by daniel.h...@gmail.com, May 27, 2009
Just want to let you know that, while the selection popup does appear for me, it 
doesn't seem to do anything.

Ubuntu 9.04, using the latest release via aptitude - 3.0.182.1 (0)
Comment 8 by kuchhal@chromium.org, May 27, 2009
The feature was not yet complete. Today morning I landed another change (r16986) that 
should show you a warning dialog if the import fails for some reason.

I am going to mark this as fixed. Please file new bugs if you encounter any errors in 
import.
Status: Fixed
Comment 9 by bugdroid1@chromium.org, May 27, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=16986 

------------------------------------------------------------------------
r16986 | kuchhal@chromium.org | 2009-05-27 09:36:10 -0700 (Wed, 27 May 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/import_dialog_gtk.cc?r1=16986&r2=16985
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/import_dialog_gtk.h?r1=16986&r2=16985
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/import_lock_dialog_gtk.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/import_progress_dialog_gtk.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_importer_utils.cc?r1=16986&r2=16985
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_importer_utils.h?r1=16986&r2=16985
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_profile_lock_posix.cc?r1=16986&r2=16985
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/importer.cc?r1=16986&r2=16985
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/importer.h?r1=16986&r2=16985
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=16986&r2=16985

Make the import feature a little more complete:
- Now we show import progress of individual items
- In case Firefox is running we display a warning and allow user to close it before proceeding
- Delete the Firefox lock when import finishes

BUG=11191

Review URL: http://codereview.chromium.org/114047

------------------------------------------------------------------------

Comment 10 by evan@chromium.org, Jun 03, 2009
Marking all old Fixed Linux bugs Verified so we can start doing real  
verification in the future.
Status: Verified
Comment 11 by bugdroid1@chromium.org, Jun 09, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=17943 

------------------------------------------------------------------------
r17943 | kuchhal@chromium.org | 2009-06-09 08:59:18 -0700 (Tue, 09 Jun 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_importer_utils.cc?r1=17943&r2=17942
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_importer_utils.h?r1=17943&r2=17942

Linux: Import passwords from Firefox.

BUG=11191
TEST=Try importing password from Firefox on Linux and it should work (though they are not accessible in UI yet).

Review URL: http://codereview.chromium.org/119267
------------------------------------------------------------------------

Comment 12 by bugdroid1@chromium.org, Jun 09, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=17955 

------------------------------------------------------------------------
r17955 | kuchhal@chromium.org | 2009-06-09 10:38:40 -0700 (Tue, 09 Jun 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_importer_utils.cc?r1=17955&r2=17954
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/importer/firefox_importer_utils.h?r1=17955&r2=17954

Linux: Import passwords from Firefox.

BUG=11191
TEST=Try importing password from Firefox on Linux and it should work (though
they are not accessible in UI yet).

Review URL: http://codereview.chromium.org/118443
------------------------------------------------------------------------

Sign in to add a comment

Powered by Google Project Hosting