My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 109173: Speed up try jobs by only testing what's necessary
12 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by jam@chromium.org, Jan 4, 2012
It struck me recently that one of the ways that we can speed up the bot cycle times is by only running tests whose binaries changed. This can help us in two big ways.

First, by figuring out which targets are affected by the patch, and which targets depend on them, we can know which tests to run. i.e. if someone is changing code in chrome, there's no reason to run base_unittests.

Second, we only need to build the targets that we identified from above. On buildbots, we don't have to do anything special since in the above example the base_unittests wouldn't be built. However on try runs in which a developer specified a revision to use, we can also avoid building unnecessary binaries. So in the above example, we might still need to build the base target even though the user might not have touched in their patch, because base changed in the sync from whatever revision the trybot was in before to the revision that was specified. But we don't need to build base_unittests since we're not going to run it.

This should make trybot/buildbot cycle times much faster. The effect will of course be greater on the slowest configs (win/mac) which will benefit _all_ developers (faster try runs and less queuing delays). We can also use some of that freed up capacity to run more configs by default (aura for ex) which will decrease magic tree breakages that occur today after a commit with green try runs. Having faster buildbot cycle times will allow us to keep the tree open for longer.


Jan 4, 2012
#1 jam@chromium.org
(No comment was entered for this change.)
Cc: rogerta@chromium.org
Jan 6, 2012
#2 maruel@chromium.org
Inverse corollary of  bug 98632 .


Labels: -Type-Bug Type-Feature InstantCQ
Blockedon: 98634 98643
Jan 6, 2012
#3 jam@chromium.org
I wasn't aware of 98632. Note that I think it's crucial that we first figure out which test binaries are needed, and only build those and their dependencies.

btw it was pointed out on the cr-dev thread that google3 deals with the test files problem by listing them in the build files. that way if someone changes a test file needed by browser_tests, the latter would be rebuilt/run.
Jan 6, 2012
#4 maruel@chromium.org
You are describing  bug 98636 .
Blockedon: 98636
Jan 6, 2012
#5 jam@chromium.org
ah, didn't know about that one either :)

one idea is to start off by being conservative: instead of listing all the files, just list directories (i.e. chrome/test/data) in the gyp target of unittests/browsertests/content_unittests etc. so we might have to build/run a test when we don't have to, but this is rare since test files don't change that often on their own.
Jan 6, 2012
#6 jam@chromium.org
and to be clear, this would still be much better where we are today, which is building and running every test each time.
Jan 7, 2012
#7 maruel@chromium.org
The problem is that this idea won't work well until  issue 98636  is implemented. And once it's implemented,  issue 98632  is a much better implementation that this feature.

Overall, I don't think the infrastructure should duplicate make/msbuild's work.

The fact that a try job is affected by the previous try job is a separate issue that is tracked independently.  Issue 98643  and  issue 98634  are a potential implementation to fix this problem. We're far better off work actively on these instead. So marking as WontFix.
Status: WontFix
Jan 8, 2012
#8 jam@chromium.org
I disagree that we shouldn't do this.

re  issue 98636 , comment 5 lists a very simple way to get the same effect initially. it might mean running tests unnecessarily sometimes, in the case that a file for unittests is changed and we run browsertests. however it's still much better than what we have now, and test files change infrequently.

I disagree that  issue 98632  will be a much better implementation. Given how fast chrome code changes, it's hard to expect all try jobs to patch at the same revision number. People will often have to pass in -r to specify which revision (I have never done a try job without -r). This means that the try slaves will have to sync to different revision and would have to build too many targets.

Additionally, even if you want to monitor which targets changed, you will still need to have a dependency graph built since for example if chrome.dll changes but not ui_tests/interactive_tests etc, you will still need to know to run these binaries. If we have that dependency graph anyways, we might as well use it to figure out which targets changed and which tests depend on them.
Status: Assigned
Jan 8, 2012
#9 maruel@chromium.org
Ok, what about having a flag to specify what the user want to build, e.g. like "make unit_tests" and the equivalent on other platforms. The CQ wouldn't use that but for user initiated builds, it could be interesting.
Status: Available
Labels: -InstantCQ TaskForce-DevLatency
Jan 8, 2012
#10 jam@chromium.org
I don't think we want to depend on the user for two reasons:
-the user wouldn't always get it right, and might run too few tests resulting in the tree breaking
-this adds more work for developers, and so most wouldn't use it. Given that from my observation, many more devs work on chrome/cros than core modules lower in the stack like base/net/content etc. So we really want for these majority of tryjobs to not have to build base_unittests/content_unittests/printing_unittests/net_unittests/content_browsertests etc...

BTW this is how things are done in google3. Given that we (chrome) are much more resource constrained and have MUCH slower builds, especially on Mac and Windows, avoiding building and running tests which are unnecessary seems really beneficial to me.
Jan 8, 2012
#11 jam@chromium.org
(No comment was entered for this change.)
Owner: ---
Cc: maruel@chromium.org
Jan 8, 2012
#12 shess@chromium.org
Getting the trybots to only build the things needed to run the tests indicated would be a good first step.  We may not want to depend on the user to specify the correct targets, but we could depend on a flag to try to make the determination of what needs to be built and run, rather than having the trybots manage it.  This assumes that the revision specified is the one the developer is using locally.

Part of where google3 wins at build time is they basically cache all the build targets, so the only time you rebuild stuff you don't need is if nobody else ever built from that base/ version - in which case you MAY want to run base_unittests, because you depend on base/, and just because you didn't make changes to base/ does not imply that the base/ you are using doesn't have errors which will impact your code.

If we did go that way, it might make sense to cache the test results alongside the build products, so that you can see the status of the tests associated with the things you depend on, even if you aren't running them as part of your build.
Jan 8, 2012
#13 jam@chromium.org
> Getting the trybots to only build the things needed to run the tests indicated would be a good first step. 

If we can know which tests need to run (the hard part), then it's trivial to just build these targets.

I really don't think that we want to depend on the user making the decision of which tests to run, because it's guaranteed that they will sometimes not run enough tests and that'll lead to build breakages.

I also don't see the benefit of seeing test results from targets which don't change based on your change. This is just extra noise, and better to only show test results from things that you may have affected. Otherwise flaky tests could confuse the developer/sheriff/reviewer/reverter.
Jan 9, 2012
#14 maruel@chromium.org
FTR, it should use build.ninja file for the dependency analysis.
Mar 23, 2012
#15 cbent...@google.com
(No comment was entered for this change.)
Cc: cbentzel@chromium.org
Mar 9, 2013
#16 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-Build Build
Blockedon: -chromium:98634 -chromium:98636 -chromium:98643 chromium:98634 chromium:98636 chromium:98643
Sep 19, 2013
#18 maruel@chromium.org
(Changed my mind and scoping this bug to *building*)  Issue 108484  is about selecting tests.
Summary: Speed up try jobs by only building what's necessary (was: Speed up try jobs by only testing what's necessary)
Blockedon: -chromium:112853 chromium:108484
Sep 19, 2013
#19 jam@chromium.org
 Bug 108484  is not the same, that one is about using the same configuration for CQ that try jobs use. That doesn't say anything about which tests to run, and which ones to skip.
Summary: Speed up try jobs by only testing what's necessary (was: Speed up try jobs by only building what's necessary)
Mar 28, 2014
#20 phajdan.jr@chromium.org
 Issue 98632  has been merged into this issue.
Cc: cmp@chromium.org scottmg@chromium.org
Apr 2, 2014
#21 phajdan.jr@chromium.org
(No comment was entered for this change.)
Labels: Infra
Jun 11, 2014
#22 jam@chromium.org
Assigning to Scott since he's looking into this.
Status: Started
Owner: sky@chromium.org
Jun 19, 2014
#23 jam@chromium.org
(No comment was entered for this change.)
Labels: Infra-CodeYellow
Jun 19, 2014
#24 jam@chromium.org
(No comment was entered for this change.)
Blocking: chromium:384941
Jul 24, 2014
#25 jam@chromium.org
 Issue 383609  has been merged into this issue.
Jul 24, 2014
#26 jam@chromium.org
 Issue 383609  has been merged into this issue.
Cc: iannucci@chromium.org sky@chromium.org brettw@chromium.org phajdan.jr@chromium.org sergeybe...@chromium.org
Jul 31, 2014
#27 jeffgri...@chromium.org
(No comment was entered for this change.)
Labels: CY-FastBotCycles
Aug 6, 2014
#28 bugdro...@chromium.org
------------------------------------------------------------------
r287778 | sky@chromium.org | 2014-08-06T16:20:45.743588Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_returns_true.json?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/api.py?r1=287778&r2=287777&pathrev=287778
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_exes.json?r1=287778&r2=287777&pathrev=287778
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.py?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.py?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/basic.json?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/doesnt_match_exclusion.json?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/json/api.py?r1=287778&r2=287777&pathrev=287778
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/__init__.py?r1=287778&r2=287777&pathrev=287778
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json?r1=287778&r2=287777&pathrev=287778

Its not enabled for any bots yet. Enabling is done by way of
chromium_trybot.json.

BUG=109173
TEST=covered by tests

Review URL: https://codereview.chromium.org/427073003
-----------------------------------------------------------------
Aug 6, 2014
#29 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83fcce1fb4dfa2812bb73e4175829211d824bb6b

commit 83fcce1fb4dfa2812bb73e4175829211d824bb6b
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Aug 06 21:51:37 2014

Enable skipping tests that aren't impacted by change on linux

Specifically linux_chromium_rel_swarming.

BUG=109173
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/451473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287866 0039d316-1c4b-4281-b951-d872f2087c98


Aug 6, 2014
#30 bugdro...@chromium.org
------------------------------------------------------------------
r287866 | sky@chromium.org | 2014-08-06T21:51:37.784498Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_trybot.json?r1=287866&r2=287865&pathrev=287866

Enable skipping tests that aren't impacted by change on linux

Specifically linux_chromium_rel_swarming.

BUG=109173
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/451473002
-----------------------------------------------------------------
Aug 7, 2014
#31 mtkl...@google.com
Is this the right bug for questions about the buildbot analyze step?

I'm trying to submit a header-only CL here: https://codereview.chromium.org/445373003/.  Some of the runs at PS1 have me concerned; I'd think changes to SkUserConfig.h would ripple out and cause rebuilds, but the analyze steps on many bots (e.g. win_chromium_rel) seem to be deciding nothing's necessary.
Aug 7, 2014
#32 dpranke@chromium.org
@mtklein: that looks like a bug to me, but we can see what sky says ... I'd probably file a separate bug for your problem, rather than trying to track every analyze-related issue as part of this (easier to follow).
Aug 7, 2014
#33 sky@chromium.org
I've filed 401542 for SkUserConfig.h. In the mean time if you include a change to tools/whitespace.txt in your patch it'll force a compile/test.
Aug 8, 2014
#34 bugdro...@chromium.org
------------------------------------------------------------------
r288360 | sky@chromium.org | 2014-08-08T14:43:40.610387Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/gyp_chromium?r1=288360&r2=288359&pathrev=288360

Makes --analyzer behave same as --analyzer2

Then I can convert recipes back to --analyzer and finally remove
--analyzer2. Oy!

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/447183006
-----------------------------------------------------------------
Aug 8, 2014
#35 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcd74902cfe8cfa6490f27859ea66cefdd762596

commit dcd74902cfe8cfa6490f27859ea66cefdd762596
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Aug 08 14:43:40 2014

Makes --analyzer behave same as --analyzer2

Then I can convert recipes back to --analyzer and finally remove
--analyzer2. Oy!

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/447183006

Cr-Commit-Position: refs/heads/master@{#288360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288360 0039d316-1c4b-4281-b951-d872f2087c98


Aug 8, 2014
#36 bugdro...@chromium.org
------------------------------------------------------------------
r288364 | sky@chromium.org | 2014-08-08T15:39:48.937610Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/api.py?r1=288364&r2=288363&pathrev=288364
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_exes.json?r1=288364&r2=288363&pathrev=288364
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json?r1=288364&r2=288363&pathrev=288364
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.py?r1=288364&r2=288363&pathrev=288364
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/basic.json?r1=288364&r2=288363&pathrev=288364
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/doesnt_match_exclusion.json?r1=288364&r2=288363&pathrev=288364
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json?r1=288364&r2=288363&pathrev=288364
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/match_exclusion.json?r1=288364&r2=288363&pathrev=288364
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_returns_true.json?r1=288364&r2=288363&pathrev=288364

Makes filter step continue on if error

Errors shouldn't block, we can continue on and compile. Most likely an
error in the filter step indicates a problem with gyp that'll fail
later on. Better to continue though so that folks don't blame the
analyze step.

BUG=109173
TEST=none

Review URL: https://codereview.chromium.org/448343002
-----------------------------------------------------------------
Aug 8, 2014
#37 bugdro...@chromium.org
------------------------------------------------------------------
r288388 | sky@chromium.org | 2014-08-08T17:43:19.002989Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/trybot_analyze_config.json?r1=288388&r2=288387&pathrev=288388

Moves analyze config into its own file

This way I don't have to duplicate it across bots. I'll remove from
the other files once the recipe side has been updated.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/450403002
-----------------------------------------------------------------
Aug 8, 2014
#38 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92f7800ec938ceecc8b9d842b905c0387b110110

commit 92f7800ec938ceecc8b9d842b905c0387b110110
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Aug 08 17:43:19 2014

Moves analyze config into its own file

This way I don't have to duplicate it across bots. I'll remove from
the other files once the recipe side has been updated.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/450403002

Cr-Commit-Position: refs/heads/master@{#288388}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288388 0039d316-1c4b-4281-b951-d872f2087c98


Aug 8, 2014
#39 bugdro...@chromium.org
------------------------------------------------------------------
r288410 | sky@chromium.org | 2014-08-08T19:07:43.817183Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/api.py?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_exes.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/basic.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/doesnt_match_exclusion.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_returns_true.json?r1=288410&r2=288409&pathrev=288410
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json?r1=288410&r2=288409&pathrev=288410

Renames --analyzer2 to --analyzer

Finally!

TBR as this is a trivial change.

BUG=109173
TEST=none
R=iannucci@chromium.org
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/450393002
-----------------------------------------------------------------
Aug 8, 2014
#40 bugdro...@chromium.org
------------------------------------------------------------------
r288425 | sky@chromium.org | 2014-08-08T20:53:55.458118Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_trybot.json?r1=288425&r2=288424&pathrev=288425

Enable skipping tests that aren't impacted by change on windows

linux_chromium_rel_swarming seems find, so I'm trying on windows
next.

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/454083003
-----------------------------------------------------------------
Aug 8, 2014
#41 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a55d97598f9936a6420e8b77dcb83c7d7277e3

commit 24a55d97598f9936a6420e8b77dcb83c7d7277e3
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Aug 08 20:53:55 2014

Enable skipping tests that aren't impacted by change on windows

linux_chromium_rel_swarming seems find, so I'm trying on windows
next.

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/454083003

Cr-Commit-Position: refs/heads/master@{#288425}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288425 0039d316-1c4b-4281-b951-d872f2087c98


Aug 8, 2014
#42 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad2dec4bb7d3b0124358403530487eecd6a5866b

commit ad2dec4bb7d3b0124358403530487eecd6a5866b
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Aug 08 22:46:46 2014

Enable skipping tests that aren't impacted by change on win swarming

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/457823002

Cr-Commit-Position: refs/heads/master@{#288454}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288454 0039d316-1c4b-4281-b951-d872f2087c98


Aug 8, 2014
#43 bugdro...@chromium.org
------------------------------------------------------------------
r288454 | sky@chromium.org | 2014-08-08T22:46:46.127461Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_trybot.json?r1=288454&r2=288453&pathrev=288454

Enable skipping tests that aren't impacted by change on win swarming

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/457823002
-----------------------------------------------------------------
Aug 11, 2014
#44 phajdan.jr@chromium.org
(No comment was entered for this change.)
Blockedon: chromium:398615
Aug 11, 2014
#45 bugdro...@chromium.org
------------------------------------------------------------------
r288809 | sky@chromium.org | 2014-08-11T22:23:10.635375Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json?r1=288809&r2=288808&pathrev=288809
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json?r1=288809&r2=288808&pathrev=288809
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.py?r1=288809&r2=288808&pathrev=288809
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json?r1=288809&r2=288808&pathrev=288809
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json?r1=288809&r2=288808&pathrev=288809
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json?r1=288809&r2=288808&pathrev=288809

Moves analyze config into its own file

This way I don't have to duplicate it across bots.

BUG=109173
TEST=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/458523002
-----------------------------------------------------------------
Aug 12, 2014
#46 bugdro...@chromium.org
------------------------------------------------------------------
r289094 | sky@chromium.org | 2014-08-12T22:43:45.225584Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_arm.json?r1=289094&r2=289093&pathrev=289094
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_trybot.json?r1=289094&r2=289093&pathrev=289094
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/gyp_chromium?r1=289094&r2=289093&pathrev=289094
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_win8_trybot.json?r1=289094&r2=289093&pathrev=289094

Random analyzer cleanup

Analyze exceptions have been centralized, so I can remove the
exceptions from each of the trybot files.
--analyzer2 is no longer used by the recipes.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/463193002
-----------------------------------------------------------------
Aug 12, 2014
#47 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e84223764658781fc704ebf6f4ba8dcaca989f2

commit 2e84223764658781fc704ebf6f4ba8dcaca989f2
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Aug 12 22:43:45 2014

Random analyzer cleanup

Analyze exceptions have been centralized, so I can remove the
exceptions from each of the trybot files.
--analyzer2 is no longer used by the recipes.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/463193002

Cr-Commit-Position: refs/heads/master@{#289094}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289094 0039d316-1c4b-4281-b951-d872f2087c98


Aug 15, 2014
#48 bugdro...@chromium.org
------------------------------------------------------------------
r289995 | sky@chromium.org | 2014-08-15T20:16:27.226014Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/api.py?r1=289995&r2=289994&pathrev=289995
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.py?r1=289995&r2=289994&pathrev=289995
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_all_exes.json?r1=289995&r2=289994&pathrev=289995

Adds handling of 'Found dependency (all)' to filter

Eventually I'll need to handle this differently, but for now it can be
treated as 'Found dependency'

BUG=109173
TEST=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/473313002
-----------------------------------------------------------------
Aug 19, 2014
#50 jam@chromium.org
btw turns out that android bots aren't making use of all this goodness. i.e. see http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe (which will replace the current android_dbg and android_dbg_triggered_tests this week)
Aug 19, 2014
#51 jam@chromium.org
Scott mentioned all this changes are in scripts/slave/recipes/chromium_trybot.py; the recipe for Android is apparently different and in scripts/slave/recipes/android/tester.py
Aug 20, 2014
#52 bugdro...@chromium.org
------------------------------------------------------------------
r290920 | sky@chromium.org | 2014-08-20T21:38:04.225604Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.py?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_rel.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_no_bot_update.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel.json?r1=290920&r2=290919&pathrev=290920
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_compile_targets.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_dbg.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_error.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/bad_retcode_doesnt_fail.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_swarming.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_dbg.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_dbg.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_all_exes.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_dbg.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_exes.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.py?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/arm.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/basic.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/api.py?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_failure.json?r1=290920&r2=290919&pathrev=290920
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/doesnt_match_exclusion.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_swarming.json?r1=290920&r2=290919&pathrev=290920
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_browser_asan_rel.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/filter/example.expected/analyzes_returns_true.json?r1=290920&r2=290919&pathrev=290920
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_cross_compile.json?r1=290920&r2=290919&pathrev=290920

Adds ability for builders to only compile targets affected by change

Currently opt-in.

BUG=109173
TEST=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/485873004
-----------------------------------------------------------------
Aug 21, 2014
#53 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d47bb191ef0070f16069d98f7137bb8e122fe717

commit d47bb191ef0070f16069d98f7137bb8e122fe717
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Aug 21 16:56:34 2014

Enables only building targets effected by changed on a couple of bots

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/492293002

Cr-Commit-Position: refs/heads/master@{#291103}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291103 0039d316-1c4b-4281-b951-d872f2087c98


Aug 21, 2014
#54 bugdro...@chromium.org
------------------------------------------------------------------
r291103 | sky@chromium.org | 2014-08-21T16:56:34.234761Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/testing/buildbot/chromium_trybot.json?r1=291103&r2=291102&pathrev=291103

Enables only building targets effected by changed on a couple of bots

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/492293002
-----------------------------------------------------------------
Aug 25, 2014
#55 bugdro...@chromium.org
------------------------------------------------------------------
r291608 | sky@chromium.org | 2014-08-25T19:14:16.247574Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/buildspec_compile_targets.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clang_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_openssl_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/chromium/steps.py?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_ozone_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg_32.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg__32_.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/mojo_python_tests_failure.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_clang_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_rel_swarming.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/dont_analyze_for_non_src_project.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_swarming.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_swarming.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_clang_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/checklicenses_failure.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg_.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/swarming_deapply_patch.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_first_failure_linux.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Builder.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_no_bot_update.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/checkperms_failure.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty32_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/deapply_compile_failure_linux.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clang_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_openssl_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty32_dbg.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_ozone_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel.json?r1=291608&r2=291607&pathrev=291608
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_dbg.json?r1=291608&r2=291607&pathrev=291608

Updates compile targets for telemetry/nacl to include chrome_run

This is needed for the filter step which returns chrome_run and not
chrome. There is similar logic in SwarmingGTestTest.

BUG=109173
TEST=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/498903002
-----------------------------------------------------------------
Aug 26, 2014
#56 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83a042eb432e9a994c6202440b0a1630b4ebecbe

commit 83a042eb432e9a994c6202440b0a1630b4ebecbe
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Aug 26 22:56:53 2014

Add the other Windows builders to filter_compile_builders.

We're seeing the dbg builder have pending jobs so this should help reduce that.

BUG=109173
R=sky@chromium.org

Review URL: https://codereview.chromium.org/506273005

Cr-Commit-Position: refs/heads/master@{#292016}

[modify] https://chromium.googlesource.com/chromium/src.git/+/83a042eb432e9a994c6202440b0a1630b4ebecbe/testing/buildbot/chromium_trybot.json

Aug 27, 2014
#57 bugdro...@chromium.org
------------------------------------------------------------------
r291688 | sky@chromium.org | 2014-08-27T15:12:58.706312Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json?r1=291688&r2=291687&pathrev=291688
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json?r1=291688&r2=291687&pathrev=291688
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json?r1=291688&r2=291687&pathrev=291688
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json?r1=291688&r2=291687&pathrev=291688
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.py?r1=291688&r2=291687&pathrev=291688
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json?r1=291688&r2=291687&pathrev=291688

Turns on filtering compile everywhere

Only problem we've encountered once the one I just fixed. So, ready to
turn on everywhere.

BUG=109173
TEST=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/507193002
-----------------------------------------------------------------
Aug 28, 2014
#58 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/623d2d8aae03f12cc9854b9f9c26afeb82da2ea4

commit 623d2d8aae03f12cc9854b9f9c26afeb82da2ea4
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 28 15:57:06 2014

Changes exception for gyp files to only gyp files in build/

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#292392}

[modify] https://chromium.googlesource.com/chromium/src.git/+/623d2d8aae03f12cc9854b9f9c26afeb82da2ea4/testing/buildbot/trybot_analyze_config.json

Aug 28, 2014
#59 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54b2e975d605ab6b6a6235ae8130e3bf0746a731

commit 54b2e975d605ab6b6a6235ae8130e3bf0746a731
Author: sky <sky@chromium.org>
Date: Thu Aug 28 17:23:01 2014

Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 of https://codereview.chromium.org/512693004/)

Reason for revert:
I'm reverting this.
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...
should have triggered a compile.

Original issue's description:
> Changes exception for gyp files to only gyp files in build/
>
> I changed analyzer such that if a gyp file (or an included gypi file)
> changes all targets in the gyp file are marked as changed. This means
> I should no longer have to special case gyp files. I'm leaving the
> exception in place for any gyp files in build as any change to those
> really needs to recompile the world.
>
> BUG=109173
> TEST=none
> R=thakis@chromium.org
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

TBR=thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=109173

Review URL: https://codereview.chromium.org/512303002

Cr-Commit-Position: refs/heads/master@{#292410}

[modify] https://chromium.googlesource.com/chromium/src.git/+/54b2e975d605ab6b6a6235ae8130e3bf0746a731/testing/buildbot/trybot_analyze_config.json

Sep 2, 2014
#60 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e1f2a87f0d559847e1dd192f0ff318950f2eb94

commit 6e1f2a87f0d559847e1dd192f0ff318950f2eb94
Author: sky <sky@chromium.org>
Date: Wed Sep 03 01:30:23 2014

Roll gyp r1970:1972

r1972: Makes matching of build files work when absolute Matching wasn't
     working if paths supplied were absolute.
r1971: Support for custom NM/readelf binaries in your toolchain.

BUG=109173
TEST=none
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/533993002

Cr-Commit-Position: refs/heads/master@{#293041}

[modify] https://chromium.googlesource.com/chromium/src.git/+/6e1f2a87f0d559847e1dd192f0ff318950f2eb94/DEPS

Sep 3, 2014
#61 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e53e29fc161f96871160f6db39919752a0376333

commit e53e29fc161f96871160f6db39919752a0376333
Author: Scott Violet <sky@chromium.org>
Date: Wed Sep 03 15:36:30 2014

Changes exception for gyp files to only gyp files in build/

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#293139}

[modify] https://chromium.googlesource.com/chromium/src.git/+/e53e29fc161f96871160f6db39919752a0376333/testing/buildbot/trybot_analyze_config.json

Sep 3, 2014
#62 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e453d5619cc36d21d305b0ea7d708897bf341d7

commit 7e453d5619cc36d21d305b0ea7d708897bf341d7
Author: sky <sky@chromium.org>
Date: Wed Sep 03 20:01:34 2014

Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 id:1 of https://codereview.chromium.org/512693004/)

Reason for revert:
*SIGH* Encountered another problem. See
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
. Reverting again.

Original issue's description:
> Changes exception for gyp files to only gyp files in build/
>
> I changed analyzer such that if a gyp file (or an included gypi file)
> changes all targets in the gyp file are marked as changed. This means
> I should no longer have to special case gyp files. I'm leaving the
> exception in place for any gyp files in build as any change to those
> really needs to recompile the world.
>
> BUG=109173
> TEST=none
> R=thakis@chromium.org
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b
>
> Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333

TBR=thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=109173

Review URL: https://codereview.chromium.org/537683002

Cr-Commit-Position: refs/heads/master@{#293187}

[modify] https://chromium.googlesource.com/chromium/src.git/+/7e453d5619cc36d21d305b0ea7d708897bf341d7/testing/buildbot/trybot_analyze_config.json

Sep 5, 2014
#63 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c361bce306a985bcb65cd9db6060ccbe139f66d

commit 5c361bce306a985bcb65cd9db6060ccbe139f66d
Author: Scott Violet <sky@chromium.org>
Date: Fri Sep 05 19:04:42 2014

Changes exception for gyp files to only gyp files in build/

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#293565}

[modify] https://chromium.googlesource.com/chromium/src.git/+/5c361bce306a985bcb65cd9db6060ccbe139f66d/testing/buildbot/trybot_analyze_config.json

Sep 8, 2014
#64 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e1fe2737bab8048e5508538ebccdeec67dcaff3

commit 7e1fe2737bab8048e5508538ebccdeec67dcaff3
Author: jochen <jochen@chromium.org>
Date: Mon Sep 08 13:16:09 2014

Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 id:1 of https://codereview.chromium.org/512693004/)

Reason for revert:
gyp change this depended on was reverted

Original issue's description:
> Changes exception for gyp files to only gyp files in build/
>
> I changed analyzer such that if a gyp file (or an included gypi file)
> changes all targets in the gyp file are marked as changed. This means
> I should no longer have to special case gyp files. I'm leaving the
> exception in place for any gyp files in build as any change to those
> really needs to recompile the world.
>
> BUG=109173
> TEST=none
> R=thakis@chromium.org
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b
>
> Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5c361bce306a985bcb65cd9db6060ccbe139f66d

TBR=thakis@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=109173

Review URL: https://codereview.chromium.org/553933002

Cr-Commit-Position: refs/heads/master@{#293713}

[modify] https://chromium.googlesource.com/chromium/src.git/+/7e1fe2737bab8048e5508538ebccdeec67dcaff3/testing/buildbot/trybot_analyze_config.json

Sep 9, 2014
#65 bugdro...@chromium.org
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f631981fd3ecd25ecda9497c19e63f25a557313

commit 3f631981fd3ecd25ecda9497c19e63f25a557313
Author: Scott Violet <sky@chromium.org>
Date: Tue Sep 09 19:15:13 2014

Changes exception for gyp files to only gyp files in build/

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333

Committed: https://chromium.googlesource.com/chromium/src/+/5c361bce306a985bcb65cd9db6060ccbe139f66d

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#293983}

[modify] https://chromium.googlesource.com/chromium/src.git/+/3f631981fd3ecd25ecda9497c19e63f25a557313/testing/buildbot/trybot_analyze_config.json

Sep 19, 2014
#67 bugdro...@chromium.org
------------------------------------------------------------------
r292044 | jabdelmalek@google.com | 2014-09-19T17:53:59.090069Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe.json?r1=292044&r2=292043&pathrev=292044
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe__content_browsertests_failure.json?r1=292044&r2=292043&pathrev=292044
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/android/tester.expected/android_rel_tests_recipe.json?r1=292044&r2=292043&pathrev=292044
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/android/tester.py?r1=292044&r2=292043&pathrev=292044

Fix compile optimization in analyze.py in Android trybots.

It looks like when the initial set of compile targets is an empty list, which is what happens for android_dbg_tests_recipe, then the intersection of it and the supplied list from analyze.py is empty. So we end up building everything. Fix this by detecting when there's no list initially, and just building whatever analyze.py says.

BUG=405584, 109173

Review URL: https://codereview.chromium.org/586803002
-----------------------------------------------------------------
Sep 22, 2014
#68 bugdro...@chromium.org
------------------------------------------------------------------
r292060 | jabdelmalek@google.com | 2014-09-22T16:21:17.863231Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/android/tester.py?r1=292060&r2=292059&pathrev=292060
   A http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/android/tester.expected/no_provision_devices_when_no_tests.json?r1=292060&r2=292059&pathrev=292060

If analyze.py only gives compile targets, don't run test steps like provisioning devices.

BUG=405584, 109173

Review URL: https://codereview.chromium.org/584813003
-----------------------------------------------------------------
Oct 1, 2014
#69 jam@chromium.org
Marking as fixed since it's also now been implemented on GPU and Android bots.

Scott: thanks so much for doing this, it's had a huge impact.
Status: Fixed
Oct 16 (6 days ago)
#70 serg...@chromium.org
Issue 352615 has been merged into this issue.
Sign in to add a comment

Powered by Google Project Hosting