My favorites | Sign in
Project Home Downloads Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 106967: REGRESSION: Popup windows show up maximized
24 people starred this issue and may be notified of changes. Back to list
 
Reported by bsdmanual, Dec 9, 2011
Chrome Version       : 17.0.963.2
OS Version: 5.1 (Windows XP), SP3
URLs (if applicable) : gmail.com, and others
Other browsers tested: OK

What steps will reproduce the problem?
1. goto i.e. gmail and compose a new email
2. click on "To:"
3. "choose from contacts" popup appears

What is the expected result?
popup size should be normal (see screenshot, correct.jpg)

What happens instead?
popup size is always maximized (see screenshot, maximized.jpg)

Please provide any additional information below. Attach a screenshot if possible.
It happens in all websites. Gmail was just an example

UserAgentString: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/535.11 (KHTML, like Gecko) Chrome/17.0.963.2 Safari/535.11


correct.jpg
260 KB   View   Download
maximized.jpg
188 KB   View   Download
Comment 1 by pavanv@chromium.org, Dec 9, 2011
To reproduce this issue, the gmail window needs to be in maximized state too.

FF and IE are ok.
Beta/Stable are fine. Need to find the regression window.
Status: Untriaged
Labels: -Type-Bug -Area-Undefined -OS-Windows Type-Regression Area-Compat OS-All
Comment 2 by pavanv@chromium.org, Dec 9, 2011
(No comment was entered for this change.)
Labels: -Pri-2 Pri-1 Mstone-17
Comment 3 by xich...@gmail.com, Dec 14, 2011
Duplicate of 106730
Comment 4 by kerz@google.com, Dec 19, 2011
Moving all Available/untriaged M17 bugs back to having no mstone.  Please retarget to a later milestone.
Labels: -Mstone-17 MovedFrom-17
Comment 5 by phist...@chromium.org, Dec 26, 2011
 Issue 108545  has been merged into this issue.
Comment 6 by phist...@chromium.org, Dec 26, 2011
 Issue 107676  has been merged into this issue.
Comment 7 by phist...@chromium.org, Dec 26, 2011
 Issue 105413  has been merged into this issue.
Comment 8 by phist...@chromium.org, Dec 26, 2011
 Issue 104714  has been merged into this issue.
Comment 9 by phist...@chromium.org, Dec 26, 2011
 Issue 104895  has been merged into this issue.
Comment 10 by phist...@chromium.org, Dec 26, 2011
 Issue 106730  has been merged into this issue.
Comment 11 by phist...@chromium.org, Dec 26, 2011
 Issue 108569  has been merged into this issue.
Comment 12 by phist...@chromium.org, Dec 26, 2011
This is a serious issue.
Summary: Popup windows show up maximized
Status: Available
Labels: -MovedFrom-17 Mstone-17 ReleaseBlock-Stable
Comment 13 by dhw@chromium.org, Dec 26, 2011
(No comment was entered for this change.)
Summary: REGRESSION: Popup windows show up maximized
Labels: -Area-Compat Area-UI Feature-Browser
Comment 14 by mille...@hotmail.com, Jan 2, 2012
Have noticed on 17.0.963.12 dev-m using Win7

that is the main window is maximised then the popup will also be maximised, but if the main isn't then the popup isn't.
Comment 15 by kerz@google.com, Jan 3, 2012
(No comment was entered for this change.)
Status: Assigned
Owner: stevenjb@chromium.org
Comment 16 by stevenjb@chromium.org, Jan 3, 2012
Does this happen on any OS other than WIndows? I do not have a Windows development device to investigate this, and can't think of what might have introduced this off the top of my head.

Status: Available
Owner: phist...@chromium.org
Cc: stevenjb@chromium.org kerz@chromium.org
Comment 17 by stevenjb@chromium.org, Jan 3, 2012
I can reproduce this on ChromeOS; will investigate.

Status: Assigned
Owner: stevenjb@chromium.org
Comment 18 by cem.koca...@gmail.com, Jan 3, 2012
I actually sent a patch for this bug:
http://codereview.chromium.org/9004046/

I looked at a lot of places to see where things went wrong, and this seemed to be the cause.
Comment 19 by stevenjb@chromium.org, Jan 3, 2012
That fix looks reasonable to me, I'll assign this to ben@.

Owner: ben@chromium.org
Comment 20 by mr.8b...@gmail.com, Jan 3, 2012
This happens on Windows XP and Vista.
Comment 21 by bugdro...@chromium.org, Jan 4, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=116389

------------------------------------------------------------------------
r116389 | cem.kocagil@gmail.com | Wed Jan 04 13:25:53 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS?r1=116389&r2=116388&pathrev=116389
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=116389&r2=116388&pathrev=116389

Popup windows' state should always be SHOW_STATE_NORMAL, not depend
on the saved window state.

BUG=106967
TEST=Windows opened by window.open should be unmaximized by default

Review URL: http://codereview.chromium.org/9004046
------------------------------------------------------------------------
Comment 22 by kerz@google.com, Jan 4, 2012
(No comment was entered for this change.)
Labels: Merge-Approved
Comment 23 by kerz@google.com, Jan 9, 2012
Took care of this.
Status: Fixed
Comment 24 by bugdro...@chromium.org, Jan 9, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=116950

------------------------------------------------------------------------
r116950 | kerz@chromium.org | Mon Jan 09 15:25:51 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/963/src/AUTHORS?r1=116950&r2=116949&pathrev=116950
 M http://src.chromium.org/viewvc/chrome/branches/963/src/chrome/browser/ui/views/frame/browser_view.cc?r1=116950&r2=116949&pathrev=116950

Merge 116389 - Popup windows' state should always be SHOW_STATE_NORMAL, not depend
on the saved window state.

BUG=106967
TEST=Windows opened by window.open should be unmaximized by default

Review URL: http://codereview.chromium.org/9004046

TBR=cem.kocagil@gmail.com
Review URL: http://codereview.chromium.org/9148013
------------------------------------------------------------------------
Labels: -merge-approved merge-merged-963
Comment 25 by mro.mich...@gmail.com, Jan 9, 2012
The status of this says "Fixed" and that it is closed "Today".... I am just curious as to when we will see this corrected?  As of today, right now (9:42 PM EST) Chrome still opens pop ups maximized.
Comment 26 by phistuck@gmail.com, Jan 9, 2012
@mro.michael -
Probably within the next dev/canary releases.
Comment 27 by spam-em...@abwesend.de, Jan 9, 2012
Why is it labeled as "fixed" when the bug actually has still not been fixed? Or has it? 
Comment 28 by kerz@google.com, Jan 9, 2012
This bug has been fixed.  It has not been pushed out to the release channels.
Comment 29 by pavanv@chromium.org, Jan 11, 2012
This bug is fixed in Windows and Mac, but it is still happening in Ubuntu for 17.0.963.33. 

 


Status: Assigned
Comment 30 by ben@chromium.org, Jan 11, 2012
Steven, is this related to any of the panel/disposition changes you've been working on lately? I haven't touched this code in ages.
Owner: stevenjb@chromium.org
Comment 31 by stevenjb@chromium.org, Jan 11, 2012
None of my recent changes are in R17. I confirmed that the fix is in R17. I will try building the branch and investigate.

Comment 32 by stevenjb@chromium.org, Jan 12, 2012
I could not reproduce this with a local Ubuntu build of the 963 branch @ 117157 (17.0.963.33). 
@pavanv, could you re-confirm and include your specific repro if it is definitely happening on 17.0.963.33+?

Cc: pavanv@chromium.org
Comment 33 by pavanv@chromium.org, Jan 12, 2012
@Steven, I maximized gmail, clicked on "To" which pops up the contacts in maximized state in Ubuntu 10.04 using 17.0.963.33. 

This doesn't happen on Mac and Windows 7.
Comment 34 by stevenjb@chromium.org, Jan 12, 2012
Ah, thanks, I had forgotten that the host window needed to be maximized first for this to occur. Investigating.

Status: Started
Comment 35 by cem.koca...@gmail.com, Jan 12, 2012
Maybe this function should set show_state_after_show_ to maximized in the case of a popup?
http://www.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/gtk/browser_window_gtk.cc&l=1705

I didn't try it, but the bug in views was very similar to this.
Comment 36 by cem.koca...@gmail.com, Jan 12, 2012
Sorry, "unmaximized" is what I meant.
Comment 37 by bugdro...@chromium.org, Jan 18, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=118174

------------------------------------------------------------------------
r118174 | stevenjb@chromium.org | Wed Jan 18 14:32:25 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=118174&r2=118173&pathrev=118174

Don't use command line or prefs for popup saved state

The bug is that popup windows are getting opened maximized on linux/gtk because of this call here: http://www.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/gtk/browser_window_gtk.cc&l=1705

It seemed more robust to fix the behavior in Browser::GetSavedWindowShowState().

BUG=106967
TEST=See issue. Also test that maximized state for main browser window is remembered correctly, and --start-maximized works.


Review URL: http://codereview.chromium.org/9211020
------------------------------------------------------------------------
Comment 38 by stevenjb@chromium.org, Jan 18, 2012
(No comment was entered for this change.)
Status: Fixed
Comment 39 by stevenjb@chromium.org, Jan 18, 2012
Merge requested for http://codereview.chromium.org/9211020 for branch 683 (R17).
Note: This issue was partially fixed by one CL, already merged, we now need the other (very small) CL.

Status: Started
Labels: -merge-merged-963 Merge-Requested
Comment 40 by kerz@google.com, Jan 20, 2012
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
Comment 41 by stevenjb@chromium.org, Jan 20, 2012
(No comment was entered for this change.)
Status: Fixed
Labels: -Merge-Approved Merge-Merged
Comment 42 by bugdro...@chromium.org, Jan 20, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=118463

------------------------------------------------------------------------
r118463 | stevenjb@google.com | Fri Jan 20 11:05:25 PST 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/963/src/chrome/browser/ui/browser.cc?r1=118463&r2=118462&pathrev=118463

Merge 118174 - Don't use command line or prefs for popup saved state

The bug is that popup windows are getting opened maximized on linux/gtk because of this call here: http://www.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/gtk/browser_window_gtk.cc&l=1705

It seemed more robust to fix the behavior in Browser::GetSavedWindowShowState().

BUG=106967
TEST=See issue. Also test that maximized state for main browser window is remembered correctly, and --start-maximized works.


Review URL: http://codereview.chromium.org/9211020

TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9270017
------------------------------------------------------------------------
Labels: merge-merged-963
Comment 44 by pavanv@chromium.org, Jan 20, 2012
verified in - Google Chrome	18.0.1014.0 (Official Build 118439)
OS: Ubuntu 64bit
Comment 45 by lordde...@gmail.com, Jan 26, 2012
Chrome Version       : 17.0.963.44 beta-m
OS Version: Windows XP, SP2

Area:
Google Chrome Extensions. Using "chrome.window.create".

What steps will reproduce the problem?
1. Call chrome.windows.create({url: "<URL>", left: 70, top: 70, width: 600, height: 800} in my extension when Chrome is maximized 


What is the expected output?
New window should be 800x600.


What do you see instead?
New maximized window with <URL> loaded.

How frequently does this problem reproduce?
Always


Please provide any additional information below.
Happens on all my Virtual Machines (XP, Vista, Win 7). Didn't try on Linux.
Comment 46 by phistuck@gmail.com, Jan 26, 2012
@lorddejan -
Please, file a new issue for this problem.
Comment 47 by lordde...@gmail.com, Jan 27, 2012
I done it here (http://code.google.com/p/chromium-os/issues/detail?id=25521), but somebody send me a email to also paste info here.

Comment 48 by phistuck@gmail.com, Jan 27, 2012
@lorddejan -
I still suggest that you create an issue in the Chromium issue tracker (you have created it in the wrong place before, that was the Chromium OS issue tracker).
When you do, post a comment here with the issue number so I would triage it.
Comment 49 by lordde...@gmail.com, Jan 27, 2012
Sorry, now I see it's reported in wrong place.
Here is new issue in Chromium: Issue ID: 111618.
Sign in to add a comment

Powered by Google Project Hosting