Issue 10531 - chromium - Going forward loses history midway at the page that causes redirection

Issue 10531:	Going forward loses history midway at the page that causes redirection
	3 people starred this issue and may be notified of changes.	Back to list

Status:	Verified
Owner:	----
Closed:	May 2009
Type-Bug
Pri-2
OS-Windows
Area-Misc
Size-Medium
Area-BrowserUI
Mstone-X

Reported by y...@google.com, Apr 14, 2009

What steps will reproduce the problem?

1. Open http://www.apple.com
2. Open http://www.hp.com
   The page is redirected to
   http://www.hp.com/#Product
3. Open http://www.cnn.com
4. Click back button 3 times quickly. Slow clicks may let redirection
happen. Now http://www.apple.com should be shown.
5. Click forward button. First, http://www.hp.com is shown.
   Then the page is redirected to http://www.hp.com/#Product.
   Notice that the forward button is now grayed out.
   The user cannot go forward any further. 


What is the expected output? What do you see instead?

In Step 5 above, the forward button is not grayed out.
Another click on forward button should bring up http://www.cnn.com

I think Chrome should behave the same way as IE7/FF3.

I tested this only with Windows XP.

IE7: Good: Clicks on forward button causes the following transition:
http://www.apple.com -> http://www.hp.com/#Product -> http://www.cnn.com
(Note: http://www.hp.com doesn't show up.)

FF3: Good: Same as IE7
Safari 4 Public Beta: Bad: Same as Chrome


Please use labels and text to provide additional information.

Comment 1 by laforge@chromium.org, Apr 28, 2009

(No comment was entered for this change.)

Status: Available
Owner: ---
Cc: bre...@chromium.org y...@google.com
Labels: Mstone-X

Comment 2 by y...@google.com, May 10, 2009

(No comment was entered for this change.)

Status: Started
Owner: y...@google.com

Comment 3 by bugdroid1@chromium.org, May 13, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=15950 

------------------------------------------------------------------------
r15950 | maruel@chromium.org | 2009-05-13 06:22:45 -0700 (Wed, 13 May 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.h?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/HistoryHelper.js?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test1.html?r1=15950&r2=15949
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test2.html?r1=15950&r2=15949
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_1.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_2.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_3.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_4.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/history_uitest.cc?r1=15950&r2=15949

This is the successor to http://codereview.chromium.org/67150

Make forward/backward navigation work even when redirection is involved.

Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.

With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.

BUG=9663,10531

Tested: unit_tests, ui_tests, manually.

Patch contributed by Yuzo Fujishima <yuzo@google.com>

Review: http://codereview.chromium.org/100245
------------------------------------------------------------------------

Comment 4 by progame, May 13, 2009

is this related to  Issue 11355 ?
it's not about back&forward but it is about history+redirections

Comment 5 by y...@google.com, May 14, 2009

 Issue 11355  is probably not related to this.
(At least it is not fixed by the change listed above.)

Comment 6 by y...@google.com, May 14, 2009

(No comment was entered for this change.)

Status: Fixed

Comment 7 by mberkow...@chromium.org, May 20, 2009

Verified in Chrome 2.0.181.1 (Official Build 16409) and Chromium 2.0.182.0 (Developer
Build 16485).

Status: Verified

Comment 8 by yvrams, Jul 14, 2009

Works fine on stable 2.0.172.38.

Comment 9 by venkataramana@chromium.org, Jul 14, 2009

Comment 8 is from me.

Owner: ---
Cc: -bre...@chromium.org -y...@google.com

Comment 10 by bugdroid1@chromium.org, Jul 23, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=21501 

------------------------------------------------------------------------
r21501 | laforge@chromium.org | 2009-07-23 19:00:09 -0700 (Thu, 23 Jul 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/navigation_controller.cc?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/navigation_controller.h?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/HistoryHelper.js?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test1.html?r1=21501&r2=21500
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/data/History/history_length_test2.html?r1=21501&r2=21500
   D /branches/172/src/chrome/test/data/History/history_length_test_page_1.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_2.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_3.html
   D /branches/172/src/chrome/test/data/History/history_length_test_page_4.html
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/test/ui/history_uitest.cc?r1=21501&r2=21500

Revert 19923 - Merge r15950.

Make forward/backward navigation work even when redirection is involved.

Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.

With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.

BUG=9663,10531

Tested: unit_tests, ui_tests, manually.

TBR=mal@chromium.org

Review URL: http://codereview.chromium.org/159329
------------------------------------------------------------------------

► Sign in to add a comment