My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 100866: Mac: Pressing TAB key in URL bar focuses bookmarks bar instead of page content
12 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  avi@chromium.org
Closed:  Jun 2012
Cc:  pkasting@chromium.org, dmazzoni@chromium.org, avi@chromium.org, rsesek@chromium.org, csilv@chromium.org

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Reported by unrealnet, Oct 19, 2011
Chrome Version       : 16.0.904.0
OS Version: OS X 10.7.2

What steps will reproduce the problem?
1. Click in URL bar (omnibox)
2. Press tab

What is the expected result?
Focus the first link (or tabindex=1) in the page

What happens instead?
The focus goes to the bookmark bar and pressing TAB cycles through ALL the items (first bookmarks, then the arrows for more bookmarks, then the Other Bookmarks folder)  in the bookmark bar and just then it focuses the page. 

Please provide any additional information below. Attach a screenshot if
possible.

I am not sure when this was introduced but it is very annoying when I want to return the focust to the page from the URL bar.


UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.904.0 Safari/535.7



Oct 19, 2011
#1 meh...@chromium.org
Confirmed.
Status: Untriaged
Labels: -Area-Undefined Area-UI
Oct 19, 2011
#2 meh...@chromium.org
Marking as "feature-bookmarks." Please relabel, if this is the wrong label here.
Labels: Feature-Bookmarks
Oct 19, 2011
#3 isherman@chromium.org
(No comment was entered for this change.)
Cc: pkasting@chromium.org
Oct 19, 2011
#4 pkasting@chromium.org
The bookmarks bar is part of the taborder in order to ensure that it's accessible.  It makes sense to be in the taborder after the main toolstrip because it's below the toolstrip.

CCing dmazzoni in case he sees something wrong in my analysis and wants to reopen.
Status: WontFix
Cc: dmazzoni@chromium.org
Oct 20, 2011
#5 unrealnet
I beg to differ. This way Chromium is breaking a non-written rule (if you can say so...) in the browser behavior! None of the other browsers selects bookmarks from the bookmarks bar in the tab order:

IE 9 - Tab in the URL focuses the page elements
Firefox - Tab in the URL focuses the search input, second tab focuses elements on the page
Safari (mac) - Cycles through inputs on the screen (url, search input, inputs on the page)
Chrome (yes, Chrome stable 14.0.835.202 on Windows) - Tab in URL focuses elements on the page and never goes through the bookmarks bar!

I can't see a reason to make me go through all my bookmarks on the bookmarks bar (25+ items) so I can focus the first Input element on the page (for example a login page with just two inputs for username and password).

Please reconsider the WontFix status and think of a better way of handling access to bookmarks bar.
Oct 20, 2011
#6 dmazzoni@chromium.org
Agreed, I'm reopening.

The correct behavior on Mac OS X is to make the bookmarks part of the tab order only if "Full Keyboard Access" is enabled in the Keyboard System Preference pane. Otherwise they should be skipped.

I didn't notice this because I have "Full Keyboard Access" on myself usually. :)

Summary: Mac: Pressing TAB key in URL bar focuses bookmarks bar instead of page content
Status: Assigned
Owner: rsesek@chromium.org
Labels: -Feature-Bookmarks Feature-OSIntegration
Oct 20, 2011
#7 rsesek@chromium.org
(No comment was entered for this change.)
Status: Untriaged
Owner: ---
Oct 20, 2011
#8 rsesek@chromium.org
Avi: I think you may have touched this in the past.
Status: Available
Cc: avi@chromium.org
Labels: -Pri-2 -Feature-OSIntegration Pri-3 Feature-Accessibility
Oct 20, 2011
#9 avi@chromium.org
Is this a regression?

Oct 20, 2011
#10 pkasting@chromium.org
Dominic, can you comment on what the correct behavior on non-Mac platforms should be?
Oct 20, 2011
#11 meh...@chromium.org
@avi: Yes, it is a regression. I am checking the range ...
Oct 20, 2011
#12 meh...@chromium.org
Regression Range: 87293-87427

Probably caused by http://codereview.chromium.org/7027017
Labels: -Type-Bug Type-Regression
Nov 10, 2011
#13 meh...@chromium.org
 Issue 103694  has been merged into this issue.
Dec 28, 2011
#14 jeffr...@google.com
any chance we could get someone to fix this on Mac?
Cc: rsesek@chromium.org csilv@chromium.org
Dec 29, 2011
#15 wiltz...@chromium.org
 Issue 108699  has been merged into this issue.
Cc: jeffr...@chromium.org
Mar 3, 2012
#17 meh...@chromium.org
 Issue 116660  has been merged into this issue.
Apr 20, 2012
#18 unrealnet
Is there any progress on this? It's pretty annoying and it is still reproducible in dev.
Jun 25, 2012
#19 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144036

------------------------------------------------------------------------
r144036 | avi@chromium.org | Mon Jun 25 15:35:16 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm?r1=144036&r2=144035&pathrev=144036

Fix key state.

-canBecomeKeyView: = "participates in Full Keyboard Access". BookmarkButton shouldn't say "yes" when it means to say no.

BUG=85691,100866
TEST=fixes both bugs!


Review URL: https://chromiumcodereview.appspot.com/10669015
------------------------------------------------------------------------
Jun 25, 2012
#20 avi@chromium.org
(No comment was entered for this change.)
Status: Fixed
Owner: avi@chromium.org
Aug 17, 2012
#21 heavyboo...@gmail.com
Is there an ETA when we'll see this in a stable build? Because in Chrome 21.0.1180.79 I am still seeing the exact same behavior.
Aug 17, 2012
#22 a...@google.com
This is in Chrome 22, so whenever you get that is when you'll see the fix.
Aug 17, 2012
#23 heavyboo...@gmail.com
Wonderful news! Thank you very much.
Oct 13, 2012
#24 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 9, 2013
#25 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Type-Regression -Feature-Accessibility Type-Bug-Regression Cr-UI-Accessibility Cr-UI
Jul 24, 2013
#26 lafo...@google.com
(No comment was entered for this change.)
Cc: -jeffr...@chromium.org
Sign in to add a comment

Powered by Google Project Hosting