My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 100678: Automated tests for full screen & mouse lock M16 features
3 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  scheib@chromium.org
Closed:  Apr 2012
Cc:  yzs...@chromium.org

Blocking:
issue 41781

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by scheib@chromium.org, Oct 17, 2011
There are very few tests currently for full screen & mouse lock M16 features
Oct 17, 2011
#1 scheib@chromium.org
(No comment was entered for this change.)
Cc: yzs...@chromium.org
Oct 17, 2011
#2 scheib@chromium.org
(No comment was entered for this change.)
Blocking: 41781
Oct 17, 2011
#3 scheib@chromium.org
(No comment was entered for this change.)
Labels: Feature-FullScreen Feature-MouseLock
Oct 18, 2011
#4 scheib@chromium.org
(No comment was entered for this change.)
Labels: Hotlist-ImportantForGames
Oct 19, 2011
#5 scheib@chromium.org
(No comment was entered for this change.)
Blocking: 95136
Oct 24, 2011
#6 lafo...@google.com
(No comment was entered for this change.)
Labels: -Mstone-16 MovedFrom-16 Mstone-17
Dec 19, 2011
#7 kerz@google.com
Moving all Available/untriaged M17 bugs back to having no mstone.  Please retarget to a later milestone.
Labels: -Mstone-17 MovedFrom-17
Jan 9, 2012
#8 wiltz...@chromium.org
(No comment was entered for this change.)
Labels: GamesRoadmapped
Feb 8, 2012
#9 scheib@chromium.org
(No comment was entered for this change.)
Labels: -Feature-MouseLock Feature-Input-MouseLock
Mar 6, 2012
#10 lafo...@google.com
Available + Owner == Default to Assigned
Status: Assigned
Mar 15, 2012
#11 scheib@chromium.org
(No comment was entered for this change.)
Status: Started
Mar 28, 2012
#12 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=129448

------------------------------------------------------------------------
r129448 | scheib@chromium.org | Wed Mar 28 11:30:35 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.cc?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.h?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_unittest.cc?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=129448&r2=129447&pathrev=129448
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tests/browser_uitest.cc?r1=129448&r2=129447&pathrev=129448

Automated tests for full screen & mouse lock M16 features

Tests added to browsertest to improve coverage for fullscreen and mouse lock transitions.

Several helper functions added to BrowserTest. Removes need to friend many tests and simplifies tests to increases readability.

IsFullscreenForTab() removed globally leaving only IsFullscreenForTabOrPending.

IsFullscreenForBrowser() added to fullscreen controller to enable testing.

typedef BrowserWithTestWindowTest BrowserTest; removed due to name conflict.

BUG=100678
TEST=


Review URL: http://codereview.chromium.org/9702055
------------------------------------------------------------------------
Mar 28, 2012
#13 scheib@chromium.org
(No comment was entered for this change.)
Status: Fixed
Labels: Mstone-19
Mar 28, 2012
#14 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=129474

------------------------------------------------------------------------
r129474 | jhawkins@chromium.org | Wed Mar 28 13:17:20 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.cc?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.h?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_unittest.cc?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=129474&r2=129473&pathrev=129474
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tests/browser_uitest.cc?r1=129474&r2=129473&pathrev=129474

Reverting due to memory (Valgrind) errors.

Revert 129448 - Automated tests for full screen & mouse lock M16 features

Tests added to browsertest to improve coverage for fullscreen and mouse lock transitions.

Several helper functions added to BrowserTest. Removes need to friend many tests and simplifies tests to increases readability.

IsFullscreenForTab() removed globally leaving only IsFullscreenForTabOrPending.

IsFullscreenForBrowser() added to fullscreen controller to enable testing.

typedef BrowserWithTestWindowTest BrowserTest; removed due to name conflict.

BUG=100678
TEST=


Review URL: http://codereview.chromium.org/9702055

TBR=scheib@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9875028
------------------------------------------------------------------------
Mar 28, 2012
#15 scheib@chromium.org
sad trombone
Status: Started
Apr 4, 2012
#16 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=130642

------------------------------------------------------------------------
r130642 | scheib@chromium.org | Wed Apr 04 09:19:38 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tab_contents/tab_contents.cc?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.cc?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.h?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_unittest.cc?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=130642&r2=130641&pathrev=130642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tests/browser_uitest.cc?r1=130642&r2=130641&pathrev=130642

Automated tests for full screen & mouse lock M16 features

Tests added to browsertest to improve coverage for fullscreen and mouse lock transitions.

Several helper functions added to BrowserTest. Removes need to friend many tests and simplifies tests to increases readability.

IsFullscreenForTab() removed globally leaving only IsFullscreenForTabOrPending.

IsFullscreenForBrowser() added to fullscreen controller to enable testing.

typedef BrowserWithTestWindowTest BrowserTest; removed due to name conflict.

BUG=100678
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129448

Review URL: https://chromiumcodereview.appspot.com/9702055
------------------------------------------------------------------------
Apr 4, 2012
#17 scheib@chromium.org
(No comment was entered for this change.)
Status: Fixed
Oct 13, 2012
#18 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Blocking: -chromium:41781 -chromium:95136 chromium:41781 chromium:95136
Mar 10, 2013
#19 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Feature-FullScreen -Feature-Input-MouseLock -Mstone-19 Cr-UI M-19 Cr-IO-MouseLock Cr-UI-Browser-FullScreen
Mar 13, 2013
#20 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment

Powered by Google Project Hosting