Export to GitHub

chromium-os - issue #9915

Signing out from non-first window sometimes shows quick flip through open windows


Posted on Dec 2, 2010 by Happy Elephant

Chrome OS Version : 0.9.128.6 Chrome Version : 8.0.552.339 Type of computer : Mario DVT Network info : GoogleGuest

Signing Out

What steps will reproduce the problem? 1. Sign in and visit a website 2. Type Ctrl+N to create a new window and visit a site there. Do this one more time so you have 3 windows. 3. Now sign out while viewing the 3rd window

What is the expected output? The sign out should just happen from that window

What do you see instead? Prior to / during sign out you can see the 2nd & 1st windows swipe by quickly (as if the windows are being torn down one by one and the lucky user gets to see this under-the-hood behavior)

Comment #1

Posted on Dec 2, 2010 by Massive Elephant

Issue 9916 has been merged into this issue.

Comment #2

Posted on Dec 2, 2010 by Massive Elephant

I only see this happen when signing out while the left-most (i.e. first) window is active, not while the last one is active. Is that what you meant?

We could work around this by sending a message to the window manager on signout so that it'll avoid focusing new windows (or will black the screen, or do whatever) regardless of how Chrome shuts itself down.

Comment #3

Posted on Dec 2, 2010 by Happy Elephant

Nope, this works for me when the rightmost / most-recent window is focused... if I sign out with the leftmost / oldest window focused then I don't see any window flipping.

As far as visual treatment, I think going to black sooner will be better so the user knows right away that the request to sign out was received by the OS.

Comment #4

Posted on Dec 22, 2010 by Quick Rabbit

Commit: 5bcc95e158da97e34b1a039c5193f2bc2c257464 Email: derat@chromium.org

cros: Add message for Chrome notifying WM about signout.

Change-Id: I2cdd0179a7f498a27abb9c79eca667673df38e72

BUG=chromium-os:9915 TEST=none TBR=cmasone

Review URL: http://codereview.chromium.org/6058005

M chromeos_wm_ipc_enums.h

Comment #5

Posted on Dec 22, 2010 by Quick Rabbit

Commit: 08c38e03b4c5b182052c0a0ce14bff37c3298ac9 Email: derat@chromium.org

cros: Add enum to helper function that I forgot to update.

This should have been included in http://codereview.chromium.org/6058005/. I have forgotten to do this this before and will forget to do it again.

Change-Id: I5cc76561414dc36f5d76fe52c5e3e56d2d2ed9c6

BUG=chromium-os:9915 TEST=built it TBR=cmasone

Review URL: http://codereview.chromium.org/5971006

M chromeos_wm_ipc_enums.h

Comment #6

Posted on Dec 23, 2010 by Massive Elephant

(No comment was entered for this change.)

Comment #7

Posted on Dec 30, 2010 by Quick Rabbit

Commit: df1c098de14e145aa964900ecb829a02fe6f13c0 Email: derat@chromium.org

wm: Fade screen on signout.

Upon receiving a message from Chrome letting us know that the user is signing out, we grab the pointer (to hide the cursor) and make the screen fade quickly to black.

BUG=chromium-os:9915 TEST=added; also built an image and checked that the previous shutting-down animation still works pre- and post-login and that the new animation is shown when signing out

Review URL: http://codereview.chromium.org/6011011

Change-Id: I36c3b6067fb96af10daee6451def01c568369dea

M real_x_connection.cc M screen_locker_handler.cc M screen_locker_handler.h M screen_locker_handler_test.cc M window_manager.cc M window_manager.h

Comment #8

Posted on Dec 30, 2010 by Massive Elephant

http://codereview.chromium.org/6047005/

Comment #9

Posted on Jan 12, 2011 by Grumpy Camel

I still see a 2nd & 1st windows swipe by quickly with the latest ToT build Hence re-opening... Google Chrome: 0.10.141.0 (Official Build 86176235) Chrome: 10.0.634.0

Comment #10

Posted on Jan 12, 2011 by Massive Elephant

9: Please include details of what you're doing. How many windows are you opening? Which is visible when you sign out? How are you signing out? Do you see the screen quickly fading to black while the windows are sliding by?

Comment #11

Posted on Jan 14, 2011 by Massive Elephant

I still haven't seen the windows slide by yet, but I've seen cases where Chrome doesn't appear to be notifying the window manager about signout. Investigating.

Comment #12

Posted on Jan 14, 2011 by Massive Elephant

Sent http://codereview.chromium.org/6353001/ for review.

Comment #13

Posted on Jan 20, 2011 by Massive Elephant

This will still happen if you have a page with a beforeunload handler (which seems reasonable, since we're going to need to show a dialog), or an unload handler (less reasonable; we ought to blank the screen immediately if we know that there's no further user action needed or any chance of signout being aborted), or some other subtle cases buried deep within WebKit. I don't think that there's any easy way to distinguish between the beforeunload case and the other ones, unfortunately -- WebKit just gives us a broad "is sudden termination allowed?" state for each renderer. amazon.com is an example of a page that triggers the flip through the windows if you have it open.

Comment #14

Posted on Jun 30, 2011 by Grumpy Wombat

Bulk punt R11->R14

Comment #15

Posted on Aug 23, 2011 by Grumpy Horse

(No comment was entered for this change.)

Comment #16

Posted on Nov 1, 2011 by Grumpy Wombat

Moving non-essential bugs to R17. please move back if this was done in error and your bug is a blocker for R15 or R16.

Comment #17

Posted on Dec 12, 2011 by Grumpy Wombat

Moving non-essential bugs to R18. please move back if this was done in error and your bug is a blocker for R17.

Comment #18

Posted on Mar 1, 2012 by Happy Wombat

Bulk move of non-blocking issues from R18 to R19.

Comment #19

Posted on Mar 22, 2012 by Swift Ox

(No comment was entered for this change.)

Comment #20

Posted on Mar 27, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #21

Posted on Apr 5, 2012 by Grumpy Wombat

(No comment was entered for this change.)

Comment #22

Posted on Apr 6, 2012 by Happy Wombat

(No comment was entered for this change.)

Comment #23

Posted on May 3, 2012 by Swift Bird

We changed a lot since this bug was opened. If you feel strongly about this feature, please re-open it in crbug.com. Thanks!

Comment #24

Posted on Mar 7, 2013 by Grumpy Hippo

(No comment was entered for this change.)

Comment #25

Posted on Mar 10, 2013 by Quick Rabbit

(No comment was entered for this change.)

Comment #26

Posted on Mar 14, 2013 by Happy Horse

Moved to: Issue chromium:192340

Status: Moved

Labels:
Type-Bug Pri-2 Sev-3 bulkmove OS-Chrome M-20 Cr-UI