Export to GitHub

chromium-os - issue #9666

Give more detailed info in SignedSettings callbacks


Posted on Nov 26, 2010 by Helpful Giraffe

Chrome OS Version : 0.9.129.2010_11_25_1928 (Developer Build bce3668d - Thu Nov 25 19:28:28 MSK 2010 - dilmah) developer x86-generic Chrome Version : 9.0.595.0 (Developer Build 67410) Type of computer : L13

Currently chrome/browser/chromeos/login/signed_settings* subsystem gives zero information about reason of failure to retrieve a property.

Retrieval of setting can fail in a number of circumstances: (1) device is still not owned (2) setting is missing (3) device is under attack (4) I/O error

Consumer of SignedSettings can tell if a reason of failure is (1) by separately checking whether device is owned. Also there is probably not much sense or possibility to discriminate (3) and (4).

However it is beneficial (if it is ever possible with current implementation) to discriminate (2) from other reasons. Otherwise consumer of SignedSettings basically has no means to support default values for missing settings and we must explicitly set values for all missing settings after device is owned.

Comment #1

Posted on Nov 29, 2010 by Massive Ox

(No comment was entered for this change.)

Comment #2

Posted on Dec 1, 2010 by Grumpy Horse

(No comment was entered for this change.)

Comment #3

Posted on Dec 1, 2010 by Grumpy Horse

(No comment was entered for this change.)

Comment #4

Posted on Dec 2, 2010 by Massive Ox

As this is blocking some other fixes, moving to p0 and starting now

Comment #5

Posted on Dec 10, 2010 by Massive Ox

pushed in r68866

Comment #6

Posted on Dec 16, 2010 by Happy Monkey

(No comment was entered for this change.)

Comment #7

Posted on Mar 7, 2013 by Grumpy Hippo

(No comment was entered for this change.)

Comment #8

Posted on Mar 10, 2013 by Quick Rabbit

(No comment was entered for this change.)

Comment #9

Posted on Mar 14, 2013 by Happy Horse

Moved to: Issue chromium:192087

Status: Moved

Labels:
Type-Feature Pri-0 Area-DesktopUI Sev-2 OS-Chrome M-10 Cr-UI-Shell