Building the chromeos-chrome package with CHROME_ORIGIN=LOCAL_SOURCE from within a chroot appears to leave some junk in the chrome/src directory, namely, directories with names of the form "x86-generic_out" and a symlink named "c" pointing to one of them. None of these are listed in .gitignore, so "git status" shows them and it's likely that someone will accidentally commit one of them sooner or later.

Chrome's .gitignore file already contains /out. The x86-*_out directories should be moved into the out/ sudirectory so they'll get ignored by git, and the 'c' symlink should be either removed or moved under out/ as well and given a descriptive name.

This looks pretty straightforward in the ebuild, so I'll give it a shot.

I found the previous discussion of the symlink at http://codereview.chromium.org/3322017/show. How close was the command line to the limit? Does something like "out/c" instead of "c" work?

For future reference, the Chromium bug about the long command lines is at http://crbug.com/54866.

For the actual question c/out should work as there was enough slack space in the command line length when the patch was submitted. Although if libraries have added more object files the amount of slack would decrease. I can go back and check exact numbers (I think the bug report listed them) but I believe 20 characters was too many and 10 worked. However be aware that it appears (I could be mistaken) that the second issue (the flock line) mentioned in the bug you references is probably already too long and its more luck that its truncation isn't hurting the build process.

And my own thoughts on this:

The *_out directories are created as a result of building from within Chrome OS (it's meant to allow multiple cross-compile targets to each have their own output directory). As they are build directories they are not cleaned up automatically (I don't believe the Makefiles support a 'make clean' or 'make distclean' which would be the right way to remove them).

Moving them directly into the out/ directory concerns me - that directory is used for builds locally and I'd consider it at the same level as x86-_out (or arm-_out or others) so putting those inside of it can be confusing.

Using a new directory would make more sense to me so that all builds are at the same level. As you mentioned its pretty easy to actually make the change since the build is well behaved and uses a define at the top.

My Chrome builds using make don't write directly into the out/ directory; subdirectories are created within it for different types of builds (e.g. Release and Debug).

You mean out/Release? Or similar? Mine do that too.

I guess I was thinking it'd be confusing to have:

out/Release out/x86-generic_out/Release

The current scheme I can easily clobber a build target (rm -rf out or rm -rf x86-generic_out). Its not that much harder with out/ being used for both the local build and to hold all others but could be a bit confusing.

Maybe add a directory builds that contains everything but out (so all ebuilds from Chrome OS go into builds). Not sure - just brainstorming and trying to keep things mostly clean.

As a related note I'm in the tail end of testing a change to move 90% of the code from the ebuilds into a chrome eclass file. Which would mean changes you make would only need to be made to the eclass and not to multiple ebuild files. I hope to have a CL submitted for review by end of week (probably not pushed until next week however). If this affects your timing (if you're ready before me that's fine just want to make sure I don't accidentally lose your changes if you submit about when i do).

Ah, I see. Sorry, I didn't realize that Release directory was created within x86-generic_out; that certainly makes a case for it living alongside out/ instead of within it.

A good approach might be renaming x86-generic_out to something like out_x86-generic, adding either "/out_" or "out_x86-" and "out_arm-*" to Chrome's .gitignore, and deciding what to do with the symlink (for now, I was just going to the update the ebuild to remove it after it's done using it).

If these changes sound okay to you, I can do them. Or, feel free to steal this bug if it's easier to include it in your refactoring. This isn't urgent; it's just something that bugs me a bit every time I run "git status".

Switching them to be out_* is fine to me and lets you do the wildcard in git as well as a rm -rf out* if you want to clobber all. Most users won't have that many of these anyways.

And clobbering the sym link in the ebuild is fine as long as you make sure that a partial ebuild (if someone were to just run src_install) recreates it.

This isn't a change I really have time to do so if you want it its all yours :) I just wanted to mainly remind myself to pay attention to a future CL coming and make sure I don't clobber/ignore it.

Commit: 272689465e8fc6029c86c5b08e96e64a97210d56 Email: derat@chromium.org

build: Build Chrome in out_$BOARD rather than $BOARD_out.

I think that this will make ignoring the various output directories via the Chromium repo's .gitignore a bit cleaner.

BUG=chromium-os:7967 TEST=ran "USE='-build_tests' FEATURES='-usersandbox' CHROME_ORIGIN=LOCAL_SOURCE emerge-x86-mario chromeos-chrome" with an existing x86-mario_out directory and checked that it was renamed. ran it with build_tests enabled with an existing out_x86-mario directory.

Review URL: http://codereview.chromium.org/5598002

Change-Id: I59c083160551fea83bb5ce7d2de4fa5cc924dfcd

M chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild M chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

http://codereview.chromium.org/5535005/

Commit: d7621a9d6b7bf05cf85fe5f34d60831687da6495 Email: derat@chromium.org

build: Build Chrome in out_$BOARD rather than $BOARD_out.

I think that this will make ignoring the various output directories via the Chromium repo's .gitignore a bit cleaner.

BUG=chromium-os:7967 TEST=ran "USE='-build_tests' FEATURES='-usersandbox' CHROME_ORIGIN=LOCAL_SOURCE emerge-x86-mario chromeos-chrome" with an existing x86-mario_out directory and checked that it was renamed. ran it with build_tests enabled with an existing out_x86-mario directory.

Review URL: http://codereview.chromium.org/5598002

Change-Id: I59c083160551fea83bb5ce7d2de4fa5cc924dfcd

M chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild M chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Moved to: Issue chromium:190281