[Tracking bug]

Build:

Chrome OS:0.7.53.0 (Continous build 87b16942 - Build 824) Chromium: 6.0.464.0 (Developer build 52071) Webkit: 534.3

Please specify Area-* of the system to which this bug/feature applies.

What steps will reproduce the problem? 1. Power on the system 2. Press the brightness key to brighten or darken the display

What is the expected output? An on screen display meter shows the level of the brightness.

What do you see instead? Brightness of display can be changed but cannot see the brightness level. There is no on screen display for brightness

Please use labels and text to provide additional information.

Let's add the same overlay as we do for volume.

since you can see the brightness of the screen this isn't very high priority. removing i13

Commit: 23a13a83815f6840facf9b4f97e8419c7c50581e Email: derat@chromium.org

dbus: Add power manager "BrightnessChanged" signal.

Change-Id: Ie530d92d3bc0233b805fe29a2c87de773a868a0a

BUG=chromium-os:4816 TEST=built it

Review URL: http://codereview.chromium.org/3804002

M chromeos/dbus/service_constants.cc M chromeos/dbus/service_constants.h

Commit: 7ecd6e9a3681b00b0b212235059f82bbbecfd223 Email: derat@chromium.org

power_manager: Send BrightnessChanged signal.

This sends a signal to the system bus announcing the new brightness level after the user presses one of the brightness keys.

Change-Id: I2a375602248c8d9df698aa939de41d9da09dec33

BUG=chromium-os:4816 TEST=built and ran it; watched the signals with "dbus-monitor --system"

Review URL: http://codereview.chromium.org/3771002

M powerd.cc M powerd.h M powerman.cc M util.cc M util.h

When verifying, make sure brightness indicator appears on sign-in screens (both normal sign-in, and when unlocking screen).

16: No, those are unrelated to this issue. Issue 9809 (recently opened) tracks the brightness keys not doing anything while the screen is locked. Issue 8232 tracks the volume bubble not being displayed while the screen is locked. Issue 7966 tracks the volume not being settable on the sign-in screen (but it sounds like that's maybe the desired behavior).

Commit: 7537f1e8866ac28580179d1903e6455a0ff53597 Email: derat@chromium.org

libcros: Watch for display brightness changes.

This adds a function that Chrome can use to get notified when the power manager sends a D-Bus signal saying that the user has changed the display's brightness.

BUG=chromium-os:4816 TEST=built and installed this and a corresponding Chrome patch; then checked that Chrome is notified when I press the brightness keys

Review URL: http://codereview.chromium.org/5640003

Change-Id: I021819f127c01961fb4b7e89f010cd642fb169cd

M SConstruct.chromiumos A chromeos_brightness.cc A chromeos_brightness.h M chromeos_cros_api.h M load.cc

Chrome change: http://codereview.chromium.org/5620004/

Please confirm if the fix should be in the ToT build:

Google Chrome OS: 0.9.131.0(Official Build 97432e7e) dev x86- test Google Chrome: 10.0.605.0

Re-opening...

Yes, this is in and I have confirmed across multiple builds that it works.

You are not using a ToT build, or at least your build is not using ToT Chrome. Per http://src.chromium.org/viewvc/chrome/releases/, the 10.0.605.0 branch of Chrome is eight days old. This particular feature was turned on by r68879. 10.0.605.0 doesn't currently include any revisions newer than r68588.

Kris, can you make sure that testing is done using images that include ToT Chrome instead of older branches?

Side request: please include the full version details from the build that you are testing, particularly the Chrome revision number (that is, the "69418" in "10.0.614.0 (Official Build 69418)" on about:version) -- this makes it easier to see what's actually included without having to use ViewVC.

Sorry about that... The ToT build currently we are testing in QA is:

Google Chrome OS: 0.9.131.0(Official Build 97432e7e) dev x86- test Google Chrome: 10.0.605.0 (Official Build 68547) WebKit: 534.14 V8: 3.0.0.1

I will verify this issue once we get an newer version to test.

verified! I see the fix in ToT test build:

Google Chrome os: 0.9.131.0 (Official Build 4e32890c) dev x86- test Google Chrome: 10.0.617.0 (Official Build 69707) Web kit: 534.16 V8: 3.0.3

Moved to: Issue chromium:186643