Export to GitHub

chromium-os - issue #10250

Cannot login with accounts with hyphen in domain name


Posted on Dec 12, 2010 by Happy Dog

Chrome OS Version : 0.9.128.8 (Official Build 9d2c13d8) beta x86-mario Chrome Version : 8.0.552.341 (Official Build 68102) Type of computer : Cr-48 Network info : wifi

Please specify Area-* of the system to which this bug/feature applies. - accounts / users / login

What steps will reproduce the problem? 1. Go to Settings -> Users. 2. Add the user "a@bb.c". It gets added without problems. 3. Now try adding "a@b-b.c". The hyphen prevents it from being recognized as a valid login.

This problem prevents accounts with hyphens from logging into Chrome OS at the login screen.

Comment #1

Posted on Dec 13, 2010 by Massive Elephant

I don't know whether this is a UI problem or something at a lower level.

Comment #2

Posted on Dec 13, 2010 by Quick Rhino

saizawa, do you see any error bubble when trying to login as a@b-b.c?

Comment #3

Posted on Dec 13, 2010 by Quick Rhino

Chris, I think this is because session manager doesn't support emails like this: it does allow only letters, digits, . and @ as valid email characters.

Comment #4

Posted on Dec 13, 2010 by Happy Dog

Yes, in the Users Setting, after I type "a@bb.c", as soon as I type the hyphen between the 2 b's, the text field becomes red and I can't hit enter.

FYI, I can't login to any account at the Chrome OS login screen, unless I add them in the Users Setting first (except the very first time of course). The "Restrict sign-in to the following users" option is NOT checked. Perhaps this is a related bug.

Comment #5

Posted on Dec 13, 2010 by Quick Rhino

The hyphen char not allowed in domain name is a bug. We should allow it and I'll get it fixed.

Unable to set "Restrict sign-in..." pref properly is related to issue 9788 and you need a Chrome 8.0.552.343 or later.

Comment #6

Posted on Dec 14, 2010 by Happy Monkey

(No comment was entered for this change.)

Comment #7

Posted on Dec 14, 2010 by Quick Rhino

Review: http://codereview.chromium.org/5812004 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69153

Comment #8

Posted on Dec 23, 2010 by Grumpy Camel

I am unable to add a users as "abc@d-e" or "abc@de". Please let me know if this is expected. Although I am able to add as "abc@d-e.f"

Comment #9

Posted on Dec 23, 2010 by Massive Elephant

Neither 'd-e' nor 'de' is a well-formed, non-top-level FQDN.

Bikeshedding: the regexp in that change seems a bit broad, though. It looks like it uses this for the domain:

[A-Za-z0-9-]{2,63}..+

Something like

[-A-Za-z0-9]{2,63}(.[-A-Za-z0-9]{2,63})+.?

would be better.

Comment #10

Posted on Jan 12, 2011 by Happy Lion

VErified in 0.10.141.0 (r86176235)

Comment #11

Posted on Mar 7, 2013 by Grumpy Hippo

(No comment was entered for this change.)

Comment #12

Posted on Mar 14, 2013 by Happy Horse

Moved to: Issue chromium:192684

Status: Moved

Labels:
Type-Bug Pri-2 Area-DesktopUI Sev- OS-Chrome