Product: Chrome_ChromeOS Stack Signature: LanguageList::GetLanguageNameAt-1D76C83 New Signature Label: LanguageList::GetLanguageNameAt New Signature Hash: dac36efb_27a0857a_fa4e0903_9faf8e51_d4db3e3d

Report link: http://go/crash/reportdetail?reportid=9c1d9b6677d923d3

Meta information: Product Name: Chrome_ChromeOS Product Version: 8.0.552.341 Report ID: 9c1d9b6677d923d3 Report Time: 2010/12/06 01:37:54, Mon Uptime: 0 sec Cumulative Uptime: 0 sec OS Name: Linux OS Version: 0.0.0 Linux 2.6.32.23+drm33.10 #1 SMP Thu Dec 2 21:39:42 PST 2010 i686 CPU Architecture: x86

CPU Info: GenuineIntel family 6 model 28 stepping 10

Thread 0 CRASHED ( SIGSEGV @ 0x000000fd )

0x74e04b28 [chrome - stl_tree.h:1029] LanguageList::GetLanguageNameAt 0x74c8df12 [chrome - chrome/browser/chromeos/login/language_switch_menu.cc:71] chromeos::LanguageSwitchMenu::GetCurrentLocaleName 0x74c9702e [chrome - chrome/browser/chromeos/login/new_user_view.cc:284] chromeos::NewUserView::UpdateLocalizedStrings 0x74c97715 [chrome - chrome/browser/chromeos/login/new_user_view.cc:289] chromeos::NewUserView::OnLocaleChanged 0x74c97b06 [chrome - chrome/browser/chromeos/login/new_user_view.cc:185] chromeos::NewUserView::Init 0x74ca619b [chrome - chrome/browser/chromeos/login/user_controller.cc:345] chromeos::UserController::CreateControlsWindow 0x74ca672f [chrome - chrome/browser/chromeos/login/user_controller.cc:173] chromeos::UserController::Init 0x74c845cc [chrome - chrome/browser/chromeos/login/existing_user_controller.cc:189] chromeos::ExistingUserController::Init 0x74903a3e [chrome - chrome/browser/chromeos/login/wizard_controller.cc:430] WizardController::ShowLoginScreen 0x749046cf [chrome - chrome/browser/chromeos/login/wizard_controller.cc:623] WizardController::OnExit 0x74ca2b7e [chrome - chrome/browser/chromeos/login/update_screen.cc:156] chromeos::UpdateScreen::ExitUpdate 0x74ca2ed7 [chrome - chrome/browser/chromeos/login/update_screen.cc:95] chromeos::UpdateScreen::UpdateStatusChanged 0x748e004e [chrome - chrome/browser/chromeos/cros/update_library.cc:92] chromeos::UpdateLibraryImpl::ChangedHandler 0x6d9bf1ca [libcros.so - chromeos_update_engine.cc:132] chromeos::OpaqueUpdateStatusConnection::StaticSignalHandler 0x6d9bf541 [libcros.so - marshal.glibmarshal.c:121] marshal_VOID__INT64_DOUBLE_STRING_STRING_INT64 0x73a71213 [libdbus-glib-1.so.2.1.0 - dbus-gproxy.c:1681] marshal_dbus_message_to_g_marshaller 0x73ef5d4a [libgobject-2.0.so.0.2200.4 - gclosure.c:767] IA__g_closure_invoke 0x73f0da9b [libgobject-2.0.so.0.2200.4 - gsignal.c:3247] signal_emit_unlocked_R 0x73f0ed3a [libgobject-2.0.so.0.2200.4 - gsignal.c:2980] IA__g_signal_emit_valist 0x73f0f1c1 [libgobject-2.0.so.0.2200.4 - gsignal.c:3037] IA__g_signal_emit 0x73a72338 [libdbus-glib-1.so.2.1.0 - dbus-gproxy.c:1734] dbus_g_proxy_manager_filter 0x7337fada [libdbus-1.so.3.4.0 - dbus-connection.c:4444] dbus_connection_dispatch 0x73a67bf8 [libdbus-glib-1.so.2.1.0 - dbus-gmain.c:101] message_queue_dispatch 0x73e44e03 [libglib-2.0.so.0.2200.4 - gmain.c:1960] IA__g_main_context_dispatch 0x73e48814 [libglib-2.0.so.0.2200.4 - gmain.c:2591] g_main_context_iterate 0x73e4894d [libglib-2.0.so.0.2200.4 - gmain.c:2654] IA__g_main_context_iteration 0x752506d4 [chrome - base/message_pump_glib.cc:211] base::MessagePumpForUI::RunWithDispatcher 0x7521b65a [chrome - base/message_loop.cc:253] MessageLoop::RunInternal 0x7521b6b8 [chrome - base/message_loop.cc:230] MessageLoopForUI::Run 0x748ad40a [chrome - chrome/browser/browser_main.cc:474] BrowserMain 0x748a67c5 [chrome - chrome/app/chrome_dll_main.cc:950] ChromeMain 0x748a70a8 [chrome - chrome/app/chrome_exe_main_gtk.cc:49] main 0x737c0a95 [libc-2.10.1.so + 0x00016a95]
0x748a4cf0 [chrome + 0x001aacf0]
0x748a705f [chrome + 0x001ad05f]
0x746ea7ff [ld-2.10.1.so + 0x0000e7ff]

I have prepared a fix http://codereview.chromium.org/5939002/ and would like to have a general comment before I commit.

The problem was because of the current locale could not be found amoung known locales. This could be as a resoult of either: 1. Pref file was corrupt. Or user could modify it, but this looks improbable because the crash is in the OOBE, which is supposed to work only once in the very beginning of the machine use. 2. Resource file for the current locale could not have been loaded (in this case current locale becomes empty string). This looks probable, because we never get this crash again from the same machine - the second run might have fixed the loading.

So, if I commit this fix - the error would be fixed and I am not sure what breaks next in alike situation. My question is that maybe we should continue committing a crash, just save some more information on the stack so it could be retrieved from the minidump?

glotov@, I agree with you. If 2 is the case (locale string is empty), ignoring error here may cause a bigger problem later. Maybe we could add something like below to confirm if 2 is really the case.

CHECK(g_browser_process->GetApplicationLocale() != "");

Agree with Denis and Satoru, we should also check for the root cause.

Root cause (assumed) is that resource bundle is not loaded -> app locale is empty.

Per crash stats this crash happened only once per client and at pretty low rate overall.

This means (assumed): - Resource bundle loading from file failed, app locale set to "". - Crash happened - Chrome restarted, resource bundle loaded successfully.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69953 Will merge as buildbots run.

Merged to 597: Committed revision 70052.

Sidenote: The code I have committed is not a real fix of the bug. Because we do not have complete picture of what was going on. This patch just introduces CHECKs in different places to gather more info and help track the bug if it appears again.

Crash not seen with latest CrOS builds. Hence closing the bug.

Build tested:

Chrome OS 0.10.138.0 (Official Build 53f189e9) dev x86-mario Google Chrome 10.0.631.0 (Official Build 70676)

Moved to: Issue chromium:192462