Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In new caliper, make sure allocation measurement isn't fragile, and fails fast if it's going to fail #114

Closed
GoogleCodeExporter opened this issue May 19, 2015 · 7 comments
Labels
Milestone

Comments

@GoogleCodeExporter
Copy link

There should be some kind of check to see if the enviroment variable 
ALLOCATION_JAR has been set.

For example,
if (type == MeasurementType.INSTANCE || type == MeasurementType.MEMORY) {
      String allocationJarFile = System.getenv("ALLOCATION_JAR");
      if (allocationJarFile == null) {
        throw new Error("Enviroment variable ALLOCATION_JAR must be set before --measureMemory option can be used")
      }
}

Current version just fails with

> Failed to execute java -javaagent:null -cp  ....
> Error occurred during initialization of VM
> agent library failed to init: instrument
> Error opening zip file or JAR manifest missing : null

If ALLOCATION_JAR has not been specified. 

Also there is no mention in any of Calipers documentation about the need for 
settings this variable

Original issue reported on code.google.com by kaspe...@gmail.com on 31 Jan 2011 at 6:50

@GoogleCodeExporter
Copy link
Author

Original comment by kevinb@google.com on 19 Mar 2011 at 2:16

  • Added labels: Milestone-1.0

@GoogleCodeExporter
Copy link
Author

Original comment by kevinb@google.com on 19 Mar 2011 at 2:45

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

need to find out if this still makes sense in new-caliper.  do we still read an 
environment variable?

Original comment by kevinb@google.com on 14 Nov 2011 at 8:52

@GoogleCodeExporter
Copy link
Author

Original comment by kevinb@google.com on 8 Feb 2012 at 9:49

  • Added labels: Component-Runner

@GoogleCodeExporter
Copy link
Author

Original comment by kevinb@google.com on 1 Nov 2012 at 8:32

@GoogleCodeExporter
Copy link
Author

Original comment by kevinb@google.com on 1 Nov 2012 at 8:42

  • Changed title: In new caliper, make sure allocation measurement isn't fragile, and fails fast if it's going to fail

@GoogleCodeExporter
Copy link
Author

I think we're in a much better place with this.  I'm going to mark it fixed.

Original comment by gak@google.com on 11 Apr 2013 at 11:14

  • Changed state: Fixed

@cgdecker cgdecker modified the milestone: 1.0 May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants