Avoid a badly-timed SIGINT from calling sys.exit #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inclusion of that code was probably unintentional to begin with. Would manifest as (without overridden signal handlers): SIGINT causing sudden termination of a Python process when unlucky. Signed-off-by: Daniel Farina <drfarina@acm.org>
|
I agree that the sys.exit() is undesirable but it seems it could still be useful to be able to ^C out of a retry loop when in interactive mode. |
|
Does the only other exception handling at this level -- |
|
You are right. It is completely unnecessary. Now removed. |
msabramo
pushed a commit
to msabramo/boto
that referenced
this pull request
Nov 28, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inclusion of that code was probably unintentional to begin with.
Would manifest as (without overridden signal handlers): SIGINT causing
sudden termination of a Python process when unlucky.
Signed-off-by: Daniel Farina drfarina@acm.org