New ConnectionPool class. #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been seeing problems where AWS would time out a connection right before it was pulled from the connection pool, and then a variety of errors can happen, some of which boto catches, and some of which it doesn't. The biggest problem, though, was that it sometimes takes a long time to get those errors. The connection pool will now discard connections that are 'stale', meaning that they have been in the pool for too long. The threshold for staleness is currently set at 15 seconds. The test_pool program now uses real threads, not greenlets.
The method is used by the test program, so it ought to be a public method.
|
I have merged this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reimplementation of the connection pool. It discards connections when they haven't been used for 60 seconds, to avoid getting timeouts from AWS.
We've been running this code on our servers for the past week, and most of our connection errors have gone away, although we're still seeing an occasional 400 response code with the error "Your socket connection to the server was not read from or written to within the timeout period. Idle connections will be closed.". I haven't been able to reproduce this error, even when sleeping long enough to induce a timeout.