The enclosed patch adds additional information into the AVBin Source structures. The codec name used in each of the streams, along with the bitrate and the display aspect ratio for video streams.

Thanks. A number of fixes needed before I can apply this patch:

display_aspect_* scales the aspect ratio down to an arbitrary limit. This is a derived quantity anyway, so should not be in AVbin.

Follow naming convention for bitrate (bit_rate). It is unclear from the docstring if this is the compressed or uncompressed bitrate. There are no units given in the audio bitrate docstring.

fps should be a rational (separate num and den variables), and should be named frame_rate_* by convention.
The variables should have their own docstring (don't combine with bitrate).

A number of the docstrings were not formatted correctly (e.g., missing /** prefix); check the HTML output of doxygen first.

The switch over PCM bitrates can be done by grouping all PCM codecs together and reusing AVbin's sample_bits.

You also need to create one or more feature names describing your changes and implement them in avbin_have_feature (also update this function's docstring to describe these feature strings). Some example feature names (which in the next version would all return 1) are "bit_rate", "codec_name", "frame_rate", ...

Please follow style of the existing source w.r.t. spaces around punctuation, placement of braces and line breaks (wrap at 80 columns). If possible, remove carriage returns from the patch.

All noted.

I thought I'd been quite careful about following conventions and eliminating whitespace diffs, but it just goes to show :)

I'll rework the patch as you describe and resubmit.

TJ, I just took over maintenance of AVbin and would love to see the updated patch you mentioned...four years ago...

Would you happen to still be interested in providing that updated patch?

If you're not willing, then I'll probably just close this issue.

My goodness, that takes me back! I'm afraid, much as I'd like to help out, I'm not really in a position timewise to undertake to rework the patch. Frankly, I haven't used AVBin since that month (and I ended up using something else even then, for reasons I don't recall).

Sorry. Feel free to close the issue; at least it could provide the starting point for a patch if someone else were interested enough :)

Thanks for responding! After all this time I didn't know if I'd even get a response. I'll close this issue.