Export to GitHub

arduino - issue #688

Suppress warnings


Posted on Oct 22, 2011 by Swift Kangaroo

Lots of warnings have been cleaned up, but there are a few more. Attached patches clean then up.

Patch #4 may be controversial, as it redefines PROGMEM. This is the suggested workaround from the GNU bug tracker. Also, the bug has finally been fixed in avr-gcc so will hopefully start showing up in avr-gcc releases.

Attachments

Comment #1

Posted on Oct 30, 2011 by Swift Panda

I tried the same approach of redefining PROGMEM, and found that it has the same problem as declaring the variable extern before defining it: both are illegal to use for declaring variables inside functions. The best way is to upgrade the compiler. My attempt to compile avr-gcc 4.6.2 so far failed though.

See https://savannah.nongnu.org/bugs/index.php?28837 https://savannah.nongnu.org/bugs/index.php?34680

Comment #2

Posted on Dec 30, 2011 by Happy Rhino

I'm not seeing most of these. Maybe some were fixed by other patches?

Comment #3

Posted on Dec 31, 2011 by Swift Kangaroo

Just did a clean build on a fresh pull. Build output attached. Turn on -Wall -Werror to see them all.

Attachments

Comment #4

Posted on Jan 2, 2012 by Happy Rhino

I fixed most of these:

https://github.com/arduino/Arduino/commit/c441bc1a0df2b07422cc1fe0c2ec8b3dc027d253 https://github.com/arduino/Arduino/commit/cce4ef7c6932c8d93c180ce7990261223e490d63

Honestly, though, most of them weren't even showing up for me at all (even with -Wall) so I probably skipped some.

Comment #5

Posted on May 21, 2012 by Happy Rhino

(No comment was entered for this change.)

Status: Fixed

Labels:
Type-Defect Priority-Medium Component-Core Milestone-1.0.1