My favorites | Sign in
Project Home Downloads Wiki Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 316: Update to wiring_digital.c to use register #ifdefs instead of cpu #ifdefs
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  dmel...@gmail.com
Closed:  Oct 2010


Sign in to add a comment
 
Project Member Reported by mark.l.s...@gmail.com, Aug 4, 2010
What change would like to see?

I changed the #ifdefs in turnOffPWM() to be register centric instead of cpu centric. 

I also removed the inline part, it reduced the code size considerably on the mega, see comments in source code


Why?

This greatly simplifies the addition of new cpus

Would this cause any incompatibilities with previous versions?  If so, how
can these be mitigated?


No compatibility problems

wiring_digital.c
5.9 KB   View   Download
Oct 17, 2010
Project Member #1 dmel...@gmail.com
http://github.com/arduino/Arduino/commit/b0bc52d7d5bd92d35ba78619d9268cd574ffca94
Status: Fixed
Labels: Component-Core Milestone-0022
Sign in to add a comment

Powered by Google Project Hosting