New Lint check: get() on AsyncTask [36975253]

Assigned

Feature Request

[AOSP] assigned

Status Update

No update yet.

Description

mm...@commonsware.com

created issue #1

Jul 9, 2013 10:34PM

The get() method on AsyncTask blocks, waiting for the task to complete.

Calling this is almost always the wrong answer. Too many developers do this on the main application thread, then wonder why they still freeze their UI. While in principle you might be able to call get() on another background thread, to block that thread waiting for the task to finish, even that worries me -- you might want to check with Romain about how much trouble developers might get themselves in this way.

I'd argue that a Lint warning for calls to get() on an AsyncTask would be worth considering.

Thanks!

Comments

sb...@google.com <sb...@google.com> Jul 30, 2013 04:24PM

Assigned to tn...@google.com.

j....@gmail.com <j....@gmail.com> #2Sep 6, 2013 10:36PM

Any updates on when we can expect RxJava 3 support in the androidx.paging library? It looks like some of the other androidx libraries already support it. Example

https://android-review.googlesource.com/c/platform/frameworks/support/+/1277904

mm...@commonsware.com <mm...@commonsware.com> #3Sep 6, 2013 10:41PM

We're working on it!

https://android-review.googlesource.com/c/platform/frameworks/support/+/1355043

j....@gmail.com <j....@gmail.com> #4Sep 7, 2013 04:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 83b0d9c4c606cc5d5aa86eef303ceb538367ad9f
Author: Zac Sweers <pandanomic@gmail.com>
Date: Fri Jul 03 00:22:37 2020

Add paging-rxjava3 artifact

This adds an rxjava3 extensions artifact for paging v3. It's ported from the rx2 artifact, but with all the deprecated APIs from that artifact removed.

I had to update the coroutines version to 1.3.7 (technically 1.3.6 was when it was introduced, but with a serious issue affecting android lint that is fixed in 1.3.7). I don't know how to get those prebuilts updates included in my CL though, not sure if it's necessary. Let me know.

RelNote: "Add RxJava3 compatibility wrappers for PagingSource and
RemoteMediator"
Fixes: 161480176
Test: ./gradlew paging:paging-rxjava3:test

Change-Id: I49ef38fde9b84f92dd272ed0b1cd1719fbbf1761

M buildSrc/build_dependencies.gradle
M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
A paging/rxjava3/api/3.0.0-alpha04.txt
A paging/rxjava3/api/current.txt
A paging/rxjava3/api/public_plus_experimental_3.0.0-alpha04.txt
A paging/rxjava3/api/public_plus_experimental_current.txt
A paging/rxjava3/api/res-3.0.0-alpha04.txt
A paging/rxjava3/api/res-current.txt
A paging/rxjava3/api/restricted_3.0.0-alpha04.txt
A paging/rxjava3/api/restricted_current.txt
A paging/rxjava3/build.gradle
A paging/rxjava3/src/main/AndroidManifest.xml
A paging/rxjava3/src/main/java/androidx/paging/rxjava3/PagingRx.kt
A paging/rxjava3/src/main/java/androidx/paging/rxjava3/RxPagingSource.kt
A paging/rxjava3/src/main/java/androidx/paging/rxjava3/RxRemoteMediator.kt
A paging/rxjava3/src/test/java/androidx/paging/RxPagingSourceTest.kt
A paging/rxjava3/src/test/java/androidx/paging/RxRemoteMediatorTest.kt
M settings.gradle

https://android-review.googlesource.com/1355043

yb...@google.com <yb...@google.com> #5Oct 18, 2016 05:27PM

afaik Lint already has an understanding of Main Thread vs Worker Thread.
I think it is appropriate to have a lint error level warning if get is ever called on the main thread.

si...@google.com <si...@google.com> Feb 27, 2018 10:32AM

Reassigned to yb...@google.com.

tn...@google.com <tn...@google.com> Feb 27, 2018 03:21PM

Reassigned to tn...@google.com.