Issue 1300 - android - Calendar agenda view shows too many reminders

Issue 1300:	Calendar agenda view shows too many reminders
	10 people starred this issue and may be notified of changes.	Back to list

Status:	Declined
Owner:	----
Closed:	Jul 23
Type-Defect
Priority-Medium
Component-Applications

Reported by chris.boyle.name, Nov 14, 2008

1. Go to Agenda view, in a month with some events with reminders, and some
without.
2. Observe that reminders are correct, or mostly so.
3. Scroll to the top and bottom, so you've seen all the events.
4. Observe that all or nearly all events have reminders; some events
without reminders appear to have copied the reminder times from those with
reminders.
5. Click on an event that mistakenly shows a reminder; observe that it
actually doesn't have one, i.e. this is just a display bug.

This looks like it might be the result of someone mis-handling ListView's
view recycling (convertView), perhaps adding reminders but never removing
them. I say this because I made the same mistake in my own app. :-)

Comment 1 by chris.boyle.name, Nov 14, 2008

Might I suggest this patch? Untested though.

	AgendaAdapter1300.patch
	584 bytes Download

Comment 2 by chris.boyle.name, Nov 17, 2008

For what it's worth, I've had this patch on my G1 for a couple of days now; it seems
to work.

Comment 3 by fadgeng, Dec 04, 2008

I have the same issue on my G1.   I have not manually patched the G1 before.  How do
I install this patch?  Considering it is untested......how do I uninstall if there is
an issue?

Comment 4 by chris.boyle.name, Dec 04, 2008

Well, I didn't want to make a whole new firmware image and lose Google Maps and
future updates, and we (non-Googlers) can't replace a built-in app (different
signatures), so I ended up adding a second app named "Calendar*". It's a very ugly
process (with glitches such as seeing all appointment reminders twice), which I wrote
up in this blog post: http://shortcipher.insanejournal.com/79756.html It ends up with
a new Calendar.apk which you install to provide that second app, and you can
uninstall "Calendar*" like any other app (settings/applications/manage).

I'm hoping there's a better way to do it than this... any Googlers care to comment?

Comment 5 by chris.boyle.name, Jan 27, 2009

Patch submitted as http://review.source.android.com/8673

Comment 6 by earl.s.capell, Apr 22, 2009

Please remind me of my appointment with Doctor Hall on June 8th. 2009 at 2.30 P.M.

Comment 7 by jlapenna...@google.com, Jul 23, 2009

logic for reminders removed from master.

Status: Declined

Comment 8 by jbq@google.com, Aug 25, 2009

(No comment was entered for this change.)

Labels: Component-Applications