Issue 49 - agentsmithplugin - Pascal case for constants is not working

Issue 49:	Pascal case for constants is not working	‹ Prev 9 of 51 Next ›
	2 people starred this issue and may be notified of changes.	Back to list

Status:	New
Owner:	----
Type-Defect
Priority-Medium

Reported by agr...@therightstuff.de, Apr 16, 2008

What steps will reproduce the problem?
1. Create a rule that forces Pascal case for any contant.
2. Implement a constant field: const int FOO;
3. Implement another constant field: const int Foo;

What is the expected output? What do you see instead?
Expected:
#2: Agent Smith should show a quick fix to rename FOO to Foo
#3: Agent Smith should show no quick fix

Shown:
#2: No quick fix/squiggly line <- Here's problem
#3: No quick fix/squiggly line

What version of the product are you using? On what operating system?
VS 2008/Re# 4.0 Build 767/Vista

Please provide any additional information below.

There's a screenshot attached resembling the missing squiggly line. Also,
there's my ReShaper code style to import and a test project for almost all
Agent Smith rules.

Besides that: Great work, I really appreciate the time you put into this
plugin!

Code Style.xml
51.2 KB Download

	2008-04-16_23-41-36.png 21.6 KB View Download

CodeStyleTest.zip
4.4 KB Download

Comment 1 by forever.zet, Apr 17, 2008

Naming convention verification engine thinks that FOO is in Pascal, because first 
letter is capital. I think problem here is rule 'Acronyms should not have more than 
2 characters'. The regular expression is incorrect and should be something like this:
   ^(?>(XML|SQL|[A-Z]{0,2})([A-Z][^A-Z]|$)|[^A-Z]+)*$

Thanks for very detailed description :)